[INFO] updating cached repository golddranks/tokio-loop [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/golddranks/tokio-loop [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/golddranks/tokio-loop" "work/ex/clippy-test-run/sources/stable/gh/golddranks/tokio-loop"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/golddranks/tokio-loop'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/golddranks/tokio-loop" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/golddranks/tokio-loop"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/golddranks/tokio-loop'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eb21d491d19caae40be717216f5b0a9a51a5dcab [INFO] sha for GitHub repo golddranks/tokio-loop: eb21d491d19caae40be717216f5b0a9a51a5dcab [INFO] validating manifest of golddranks/tokio-loop on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of golddranks/tokio-loop on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing golddranks/tokio-loop [INFO] finished frobbing golddranks/tokio-loop [INFO] frobbed toml for golddranks/tokio-loop written to work/ex/clippy-test-run/sources/stable/gh/golddranks/tokio-loop/Cargo.toml [INFO] started frobbing golddranks/tokio-loop [INFO] finished frobbing golddranks/tokio-loop [INFO] frobbed toml for golddranks/tokio-loop written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/golddranks/tokio-loop/Cargo.toml [INFO] crate golddranks/tokio-loop has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting golddranks/tokio-loop against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/golddranks/tokio-loop:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b7d8dea5801324ef9e1d0d4b43b6c2cfffad7595170df8bee7779727e4137f36 [INFO] running `"docker" "start" "-a" "b7d8dea5801324ef9e1d0d4b43b6c2cfffad7595170df8bee7779727e4137f36"` [INFO] [stderr] Checking futures v0.1.13 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.29 [INFO] [stderr] Checking env_logger v0.4.2 [INFO] [stderr] Checking bytes v0.4.3 [INFO] [stderr] Checking mio v0.6.7 [INFO] [stderr] Checking tokio-io v0.1.1 [INFO] [stderr] Checking tokio-core v0.1.7 [INFO] [stderr] Checking tokio_loop v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `HttpCodec<'a>` [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn new() -> Self { [INFO] [stderr] 124 | | Self { [INFO] [stderr] 125 | | phantom: PhantomData, [INFO] [stderr] 126 | | regex: Regex::new("\r\n\r\n").expect("Invariant: the regex is always correct"), [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | impl Default for HttpCodec<'a> { [INFO] [stderr] 123 | fn default() -> Self { [INFO] [stderr] 124 | Self::new() [INFO] [stderr] 125 | } [INFO] [stderr] 126 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:126:31 [INFO] [stderr] | [INFO] [stderr] 126 | regex: Regex::new("\r\n\r\n").expect("Invariant: the regex is always correct"), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `HttpCodec<'a>` [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn new() -> Self { [INFO] [stderr] 124 | | Self { [INFO] [stderr] 125 | | phantom: PhantomData, [INFO] [stderr] 126 | | regex: Regex::new("\r\n\r\n").expect("Invariant: the regex is always correct"), [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | impl Default for HttpCodec<'a> { [INFO] [stderr] 123 | fn default() -> Self { [INFO] [stderr] 124 | Self::new() [INFO] [stderr] 125 | } [INFO] [stderr] 126 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:126:31 [INFO] [stderr] | [INFO] [stderr] 126 | regex: Regex::new("\r\n\r\n").expect("Invariant: the regex is always correct"), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.18s [INFO] running `"docker" "inspect" "b7d8dea5801324ef9e1d0d4b43b6c2cfffad7595170df8bee7779727e4137f36"` [INFO] running `"docker" "rm" "-f" "b7d8dea5801324ef9e1d0d4b43b6c2cfffad7595170df8bee7779727e4137f36"` [INFO] [stdout] b7d8dea5801324ef9e1d0d4b43b6c2cfffad7595170df8bee7779727e4137f36