[INFO] updating cached repository gokultp/rust-starter
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/gokultp/rust-starter
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/gokultp/rust-starter" "work/ex/clippy-test-run/sources/stable/gh/gokultp/rust-starter"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gokultp/rust-starter'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/gokultp/rust-starter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gokultp/rust-starter"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gokultp/rust-starter'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c851239a528916279783680366ba3c4d5c7ecb52
[INFO] sha for GitHub repo gokultp/rust-starter: c851239a528916279783680366ba3c4d5c7ecb52
[INFO] validating manifest of gokultp/rust-starter on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gokultp/rust-starter on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gokultp/rust-starter
[INFO] finished frobbing gokultp/rust-starter
[INFO] frobbed toml for gokultp/rust-starter written to work/ex/clippy-test-run/sources/stable/gh/gokultp/rust-starter/Cargo.toml
[INFO] started frobbing gokultp/rust-starter
[INFO] finished frobbing gokultp/rust-starter
[INFO] frobbed toml for gokultp/rust-starter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gokultp/rust-starter/Cargo.toml
[INFO] crate gokultp/rust-starter has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gokultp/rust-starter against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gokultp/rust-starter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e23eabe7523ebfa81d8a56b4f921ecb2971c6fb8adb9712dda845455c23c8746
[INFO] running `"docker" "start" "-a" "e23eabe7523ebfa81d8a56b4f921ecb2971c6fb8adb9712dda845455c23c8746"`
[INFO] [stderr]     Checking helloword v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:9:5
[INFO] [stderr]    |
[INFO] [stderr] 9  | /     return if n==0{
[INFO] [stderr] 10 | |         1
[INFO] [stderr] 11 | |     }else{
[INFO] [stderr] 12 | |         n * fact(n -1)
[INFO] [stderr] 13 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 9  |     if n==0{
[INFO] [stderr] 10 |         1
[INFO] [stderr] 11 |     }else{
[INFO] [stderr] 12 |         n * fact(n -1)
[INFO] [stderr] 13 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     return val;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `val`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:16:15
[INFO] [stderr]    |
[INFO] [stderr] 16 |       let val = match boolean {
[INFO] [stderr]    |  _______________^
[INFO] [stderr] 17 | |        true =>1,
[INFO] [stderr] 18 | |        false =>0,
[INFO] [stderr] 19 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if boolean { 1 } else { 0 }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:9:5
[INFO] [stderr]    |
[INFO] [stderr] 9  | /     return if n==0{
[INFO] [stderr] 10 | |         1
[INFO] [stderr] 11 | |     }else{
[INFO] [stderr] 12 | |         n * fact(n -1)
[INFO] [stderr] 13 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 9  |     if n==0{
[INFO] [stderr] 10 |         1
[INFO] [stderr] 11 |     }else{
[INFO] [stderr] 12 |         n * fact(n -1)
[INFO] [stderr] 13 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     return val;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `val`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:16:15
[INFO] [stderr]    |
[INFO] [stderr] 16 |       let val = match boolean {
[INFO] [stderr]    |  _______________^
[INFO] [stderr] 17 | |        true =>1,
[INFO] [stderr] 18 | |        false =>0,
[INFO] [stderr] 19 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if boolean { 1 } else { 0 }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.05s
[INFO] running `"docker" "inspect" "e23eabe7523ebfa81d8a56b4f921ecb2971c6fb8adb9712dda845455c23c8746"`
[INFO] running `"docker" "rm" "-f" "e23eabe7523ebfa81d8a56b4f921ecb2971c6fb8adb9712dda845455c23c8746"`
[INFO] [stdout] e23eabe7523ebfa81d8a56b4f921ecb2971c6fb8adb9712dda845455c23c8746