[INFO] updating cached repository goertzenator/cargo-erlangapp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/goertzenator/cargo-erlangapp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/goertzenator/cargo-erlangapp" "work/ex/clippy-test-run/sources/stable/gh/goertzenator/cargo-erlangapp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/goertzenator/cargo-erlangapp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/goertzenator/cargo-erlangapp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/goertzenator/cargo-erlangapp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/goertzenator/cargo-erlangapp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 37693fd7be19e2ced208a4ad90729df9508ed7ca [INFO] sha for GitHub repo goertzenator/cargo-erlangapp: 37693fd7be19e2ced208a4ad90729df9508ed7ca [INFO] validating manifest of goertzenator/cargo-erlangapp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of goertzenator/cargo-erlangapp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing goertzenator/cargo-erlangapp [INFO] finished frobbing goertzenator/cargo-erlangapp [INFO] frobbed toml for goertzenator/cargo-erlangapp written to work/ex/clippy-test-run/sources/stable/gh/goertzenator/cargo-erlangapp/Cargo.toml [INFO] started frobbing goertzenator/cargo-erlangapp [INFO] finished frobbing goertzenator/cargo-erlangapp [INFO] frobbed toml for goertzenator/cargo-erlangapp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/goertzenator/cargo-erlangapp/Cargo.toml [INFO] crate goertzenator/cargo-erlangapp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting goertzenator/cargo-erlangapp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/goertzenator/cargo-erlangapp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b4241902f7f6491bdf660ae9da923599fa2a9a58e91b491fec31a9c1fb0f6301 [INFO] running `"docker" "start" "-a" "b4241902f7f6491bdf660ae9da923599fa2a9a58e91b491fec31a9c1fb0f6301"` [INFO] [stderr] Checking num-traits v0.1.33 [INFO] [stderr] Checking serde v0.7.14 [INFO] [stderr] Checking itertools v0.4.16 [INFO] [stderr] Checking walkdir v0.1.5 [INFO] [stderr] Checking serde_json v0.7.4 [INFO] [stderr] Checking cargo-erlangapp v0.1.5-pre (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | build_type: build_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | build_type: build_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self { [INFO] [stderr] 43 | | &Msg(s) => s, [INFO] [stderr] 44 | | &MsgIo(s, ref _err) => s, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | Msg(s) => s, [INFO] [stderr] 44 | MsgIo(s, ref _err) => s, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match self { [INFO] [stderr] 52 | | &Msg(s) => [INFO] [stderr] 53 | | write!(f, "{}", s), [INFO] [stderr] 54 | | &MsgIo(s, ref err) => [INFO] [stderr] 55 | | write!(f, "{} ({})", s, err), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *self { [INFO] [stderr] 52 | Msg(s) => [INFO] [stderr] 53 | write!(f, "{}", s), [INFO] [stderr] 54 | MsgIo(s, ref err) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:62:41 [INFO] [stderr] | [INFO] [stderr] 62 | let args_string: Vec = args.into_iter().cloned().map(From::from).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | writeln!(stderr(), "Usage:").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | writeln!(stderr(), "\tcargo-erlangapp build [cargo rustc args]").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | writeln!(stderr(), "\tcargo-erlangapp clean [cargo clean args]").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | writeln!(stderr(), "\tcargo-erlangapp test [cargo test args]").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | writeln!(stderr(), "Error: {}", err).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self { [INFO] [stderr] 43 | | &Msg(s) => s, [INFO] [stderr] 44 | | &MsgIo(s, ref _err) => s, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | Msg(s) => s, [INFO] [stderr] 44 | MsgIo(s, ref _err) => s, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match self { [INFO] [stderr] 52 | | &Msg(s) => [INFO] [stderr] 53 | | write!(f, "{}", s), [INFO] [stderr] 54 | | &MsgIo(s, ref err) => [INFO] [stderr] 55 | | write!(f, "{} ({})", s, err), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *self { [INFO] [stderr] 52 | Msg(s) => [INFO] [stderr] 53 | write!(f, "{}", s), [INFO] [stderr] 54 | MsgIo(s, ref err) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:62:41 [INFO] [stderr] | [INFO] [stderr] 62 | let args_string: Vec = args.into_iter().cloned().map(From::from).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | / match m.is_dir() { [INFO] [stderr] 294 | | true => fs::remove_dir_all(path), [INFO] [stderr] 295 | | false => Ok(()), [INFO] [stderr] 296 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if m.is_dir() { fs::remove_dir_all(path) } else { Ok(()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | writeln!(stderr(), "Usage:").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | writeln!(stderr(), "\tcargo-erlangapp build [cargo rustc args]").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | writeln!(stderr(), "\tcargo-erlangapp clean [cargo clean args]").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | writeln!(stderr(), "\tcargo-erlangapp test [cargo test args]").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:309:13 [INFO] [stderr] | [INFO] [stderr] 309 | / match status.success() { [INFO] [stderr] 310 | | true => Ok(()), [INFO] [stderr] 311 | | false => Err(Msg("cargo command failed")), [INFO] [stderr] 312 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if status.success() { Ok(()) } else { Err(Msg("cargo command failed")) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | writeln!(stderr(), "Error: {}", err).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:369:35 [INFO] [stderr] | [INFO] [stderr] 369 | cargo_args: args[2..].into_iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | / match m.is_dir() { [INFO] [stderr] 294 | | true => fs::remove_dir_all(path), [INFO] [stderr] 295 | | false => Ok(()), [INFO] [stderr] 296 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if m.is_dir() { fs::remove_dir_all(path) } else { Ok(()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:309:13 [INFO] [stderr] | [INFO] [stderr] 309 | / match status.success() { [INFO] [stderr] 310 | | true => Ok(()), [INFO] [stderr] 311 | | false => Err(Msg("cargo command failed")), [INFO] [stderr] 312 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if status.success() { Ok(()) } else { Err(Msg("cargo command failed")) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:369:35 [INFO] [stderr] | [INFO] [stderr] 369 | cargo_args: args[2..].into_iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:417:39 [INFO] [stderr] | [INFO] [stderr] 417 | let argsv: Vec = args.into_iter().cloned().map(From::from).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/tests.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | const TEST_DIR: &'static str = "tests/testdir"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/tests.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | const APP_DIR: &'static str = "tests/testdir/testapp"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/tests.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | const APP_SRC: &'static str = "tests/testapp"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> tests/tests.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / match fs::metadata(s.as_ref()) [INFO] [stderr] 84 | | .map(|m| m.is_file()).unwrap_or(false) { [INFO] [stderr] 85 | | true => Ok(format!("{:?} exists!", s.as_ref())), [INFO] [stderr] 86 | | false => Err(format!("{:?} does not exist!", s.as_ref())), [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 83 | if fs::metadata(s.as_ref()) [INFO] [stderr] 84 | .map(|m| m.is_file()).unwrap_or(false) { Ok(format!("{:?} exists!", s.as_ref())) } else { Err(format!("{:?} does not exist!", s.as_ref())) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.18s [INFO] running `"docker" "inspect" "b4241902f7f6491bdf660ae9da923599fa2a9a58e91b491fec31a9c1fb0f6301"` [INFO] running `"docker" "rm" "-f" "b4241902f7f6491bdf660ae9da923599fa2a9a58e91b491fec31a9c1fb0f6301"` [INFO] [stdout] b4241902f7f6491bdf660ae9da923599fa2a9a58e91b491fec31a9c1fb0f6301