[INFO] updating cached repository gobanos/cargo-aoc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gobanos/cargo-aoc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gobanos/cargo-aoc" "work/ex/clippy-test-run/sources/stable/gh/gobanos/cargo-aoc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gobanos/cargo-aoc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gobanos/cargo-aoc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gobanos/cargo-aoc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gobanos/cargo-aoc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 54e0a80a9bd7dc339c7d2c9dbbf43076d9112e3a [INFO] sha for GitHub repo gobanos/cargo-aoc: 54e0a80a9bd7dc339c7d2c9dbbf43076d9112e3a [INFO] validating manifest of gobanos/cargo-aoc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gobanos/cargo-aoc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gobanos/cargo-aoc [INFO] finished frobbing gobanos/cargo-aoc [INFO] frobbed toml for gobanos/cargo-aoc written to work/ex/clippy-test-run/sources/stable/gh/gobanos/cargo-aoc/Cargo.toml [INFO] started frobbing gobanos/cargo-aoc [INFO] finished frobbing gobanos/cargo-aoc [INFO] frobbed toml for gobanos/cargo-aoc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gobanos/cargo-aoc/Cargo.toml [INFO] crate gobanos/cargo-aoc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gobanos/cargo-aoc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gobanos/cargo-aoc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a172e4ed0a17cf24d91ad2591dd729b75ebf6ebf00bcdb1bde24164d9b73c039 [INFO] running `"docker" "start" "-a" "a172e4ed0a17cf24d91ad2591dd729b75ebf6ebf00bcdb1bde24164d9b73c039"` [INFO] [stderr] Compiling regex-syntax v0.6.4 [INFO] [stderr] Checking aoc-runner-internal v0.1.0 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Compiling parse-zoneinfo v0.2.0 [INFO] [stderr] Compiling chrono-tz v0.5.0 [INFO] [stderr] Checking cargo-aoc v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/app.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match sub_args.value_of("set") { [INFO] [stderr] 30 | | Some(new_session) => { [INFO] [stderr] 31 | | // Tries to set the session token [INFO] [stderr] 32 | | match creds_manager.set_session_token(new_session.into()) { [INFO] [stderr] ... | [INFO] [stderr] 37 | | _ => {} [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | if let Some(new_session) = sub_args.value_of("set") { [INFO] [stderr] 30 | // Tries to set the session token [INFO] [stderr] 31 | match creds_manager.set_session_token(new_session.into()) { [INFO] [stderr] 32 | Ok(()) => println!("Credentials sucessfully changed!"), [INFO] [stderr] 33 | Err(e) => println!("Error changing credentials: {}", e), [INFO] [stderr] 34 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/app.rs:80:46 [INFO] [stderr] | [INFO] [stderr] 80 | fs::create_dir_all(&dir).expect(&format!("Could not create input directory: {}", dir)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not create input directory: {}", dir))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/app.rs:84:60 [INFO] [stderr] | [INFO] [stderr] 84 | let mut file = File::create(&filename).expect(&format!("Could not create file {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not create file {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/app.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | file.write(body.as_bytes()).expect(&format!("Could not write to {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/app.rs:85:49 [INFO] [stderr] | [INFO] [stderr] 85 | file.write(body.as_bytes()).expect(&format!("Could not write to {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not write to {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | day: day.0 as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(day.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/app.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | file.write(body.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/credentials.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | .ok_or("No session token available".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "No session token available".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/date.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | .unwrap_or(today.day()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| today.day())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/date.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | .unwrap_or(today.year()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| today.year())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/app.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match sub_args.value_of("set") { [INFO] [stderr] 30 | | Some(new_session) => { [INFO] [stderr] 31 | | // Tries to set the session token [INFO] [stderr] 32 | | match creds_manager.set_session_token(new_session.into()) { [INFO] [stderr] ... | [INFO] [stderr] 37 | | _ => {} [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | if let Some(new_session) = sub_args.value_of("set") { [INFO] [stderr] 30 | // Tries to set the session token [INFO] [stderr] 31 | match creds_manager.set_session_token(new_session.into()) { [INFO] [stderr] 32 | Ok(()) => println!("Credentials sucessfully changed!"), [INFO] [stderr] 33 | Err(e) => println!("Error changing credentials: {}", e), [INFO] [stderr] 34 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/app.rs:80:46 [INFO] [stderr] | [INFO] [stderr] 80 | fs::create_dir_all(&dir).expect(&format!("Could not create input directory: {}", dir)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not create input directory: {}", dir))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/app.rs:84:60 [INFO] [stderr] | [INFO] [stderr] 84 | let mut file = File::create(&filename).expect(&format!("Could not create file {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not create file {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/app.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | file.write(body.as_bytes()).expect(&format!("Could not write to {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/app.rs:85:49 [INFO] [stderr] | [INFO] [stderr] 85 | file.write(body.as_bytes()).expect(&format!("Could not write to {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not write to {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | day: day.0 as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(day.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/app.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | file.write(body.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-aoc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/credentials.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | .ok_or("No session token available".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "No session token available".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/date.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | .unwrap_or(today.day()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| today.day())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/date.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | .unwrap_or(today.year()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| today.year())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-aoc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a172e4ed0a17cf24d91ad2591dd729b75ebf6ebf00bcdb1bde24164d9b73c039"` [INFO] running `"docker" "rm" "-f" "a172e4ed0a17cf24d91ad2591dd729b75ebf6ebf00bcdb1bde24164d9b73c039"` [INFO] [stdout] a172e4ed0a17cf24d91ad2591dd729b75ebf6ebf00bcdb1bde24164d9b73c039