[INFO] updating cached repository gobanos/adventofcode-2016 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gobanos/adventofcode-2016 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gobanos/adventofcode-2016" "work/ex/clippy-test-run/sources/stable/gh/gobanos/adventofcode-2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gobanos/adventofcode-2016'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gobanos/adventofcode-2016" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gobanos/adventofcode-2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gobanos/adventofcode-2016'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5d3f369f0921c25d0734cf710f9fcb8717c1b776 [INFO] sha for GitHub repo gobanos/adventofcode-2016: 5d3f369f0921c25d0734cf710f9fcb8717c1b776 [INFO] validating manifest of gobanos/adventofcode-2016 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gobanos/adventofcode-2016 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gobanos/adventofcode-2016 [INFO] finished frobbing gobanos/adventofcode-2016 [INFO] frobbed toml for gobanos/adventofcode-2016 written to work/ex/clippy-test-run/sources/stable/gh/gobanos/adventofcode-2016/Cargo.toml [INFO] started frobbing gobanos/adventofcode-2016 [INFO] finished frobbing gobanos/adventofcode-2016 [INFO] frobbed toml for gobanos/adventofcode-2016 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gobanos/adventofcode-2016/Cargo.toml [INFO] crate gobanos/adventofcode-2016 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gobanos/adventofcode-2016 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gobanos/adventofcode-2016:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b2844f48e77db165b764685c84273b5b4b46b792b4ea68d1f81c5486b185e5d [INFO] running `"docker" "start" "-a" "4b2844f48e77db165b764685c84273b5b4b46b792b4ea68d1f81c5486b185e5d"` [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking adventofcode-2016 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem1.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem1.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem1.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem2.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem2.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem2.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day4/problem1.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day4/problem2.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day7/problem2.rs:12:15 [INFO] [stderr] | [INFO] [stderr] 12 | ABA { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day7/problem2.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | ABA { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem1.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem1.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem1.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem1.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/day8/problem2.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/day8/problem2.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem2.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem2.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem2.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem2.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem1.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem1.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem1.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem2.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem2.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day3/problem2.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | Triangle { a: a, b: b, c: c } [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day4/problem1.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day4/problem2.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day7/problem2.rs:12:15 [INFO] [stderr] | [INFO] [stderr] 12 | ABA { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day7/problem2.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | ABA { a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem1.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem1.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem1.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem1.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/day8/problem2.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/day8/problem2.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem2.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem2.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem2.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day8/problem2.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `nb_pixel_on` [INFO] [stderr] --> src/day8/problem2.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | fn nb_pixel_on(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem1.rs:39:23 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(md5[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem1.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(md5[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem1.rs:39:55 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(md5[2] >> 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem2.rs:39:23 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(md5[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem2.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(md5[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem2.rs:39:55 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(md5[2] >> 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/day8/problem2.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | let tmp = self.pixels[rot.index].iter().map(|p| *p).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.pixels[rot.index].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: method is never used: `nb_pixel_on` [INFO] [stderr] --> src/day8/problem1.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | fn nb_pixel_on(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 163 | make_sized_screen!(TestScreen, width: 7, height: 3); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `nb_pixel_on` [INFO] [stderr] --> src/day8/problem2.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | fn nb_pixel_on(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem1.rs:39:23 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(md5[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem1.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(md5[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem1.rs:39:55 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(md5[2] >> 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem2.rs:39:23 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(md5[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem2.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(md5[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/day5/problem2.rs:39:55 [INFO] [stderr] | [INFO] [stderr] 39 | let sum = md5[0] as i32 + md5[1] as i32 + (md5[2] >> 4) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(md5[2] >> 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/day8/problem2.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | let tmp = self.pixels[rot.index].iter().map(|p| *p).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.pixels[rot.index].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.34s [INFO] running `"docker" "inspect" "4b2844f48e77db165b764685c84273b5b4b46b792b4ea68d1f81c5486b185e5d"` [INFO] running `"docker" "rm" "-f" "4b2844f48e77db165b764685c84273b5b4b46b792b4ea68d1f81c5486b185e5d"` [INFO] [stdout] 4b2844f48e77db165b764685c84273b5b4b46b792b4ea68d1f81c5486b185e5d