[INFO] updating cached repository gobanos/TAoCP-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gobanos/TAoCP-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gobanos/TAoCP-rust" "work/ex/clippy-test-run/sources/stable/gh/gobanos/TAoCP-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gobanos/TAoCP-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gobanos/TAoCP-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gobanos/TAoCP-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gobanos/TAoCP-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a8e08ba4ef275f72e740e54f3be539cbcae46351 [INFO] sha for GitHub repo gobanos/TAoCP-rust: a8e08ba4ef275f72e740e54f3be539cbcae46351 [INFO] validating manifest of gobanos/TAoCP-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gobanos/TAoCP-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gobanos/TAoCP-rust [INFO] finished frobbing gobanos/TAoCP-rust [INFO] frobbed toml for gobanos/TAoCP-rust written to work/ex/clippy-test-run/sources/stable/gh/gobanos/TAoCP-rust/Cargo.toml [INFO] started frobbing gobanos/TAoCP-rust [INFO] finished frobbing gobanos/TAoCP-rust [INFO] frobbed toml for gobanos/TAoCP-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gobanos/TAoCP-rust/Cargo.toml [INFO] crate gobanos/TAoCP-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gobanos/TAoCP-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gobanos/TAoCP-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8b0d1eb23810244d9e55a22c4fd0965ffd2815cdeb681881adfa573d4cea7f6 [INFO] running `"docker" "start" "-a" "d8b0d1eb23810244d9e55a22c4fd0965ffd2815cdeb681881adfa573d4cea7f6"` [INFO] [stderr] Checking the-art-of-computer-programming v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/information_structure/linear_lists/mod.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | / match compare(unsafe { &*a }, unsafe { &*b }) { [INFO] [stderr] 103 | | Ordering::Greater => { [INFO] [stderr] 104 | | sorted = false; [INFO] [stderr] 105 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 109 | | _ => () [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | if let Ordering::Greater = compare(unsafe { &*a }, unsafe { &*b }) { [INFO] [stderr] 103 | sorted = false; [INFO] [stderr] 104 | unsafe { [INFO] [stderr] 105 | ::std::ptr::swap(a, b); [INFO] [stderr] 106 | } [INFO] [stderr] 107 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/information_structure/linear_lists/mod.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | / match compare(unsafe { &*a }, unsafe { &*b }) { [INFO] [stderr] 103 | | Ordering::Greater => { [INFO] [stderr] 104 | | sorted = false; [INFO] [stderr] 105 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 109 | | _ => () [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | if let Ordering::Greater = compare(unsafe { &*a }, unsafe { &*b }) { [INFO] [stderr] 103 | sorted = false; [INFO] [stderr] 104 | unsafe { [INFO] [stderr] 105 | ::std::ptr::swap(a, b); [INFO] [stderr] 106 | } [INFO] [stderr] 107 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.04s [INFO] running `"docker" "inspect" "d8b0d1eb23810244d9e55a22c4fd0965ffd2815cdeb681881adfa573d4cea7f6"` [INFO] running `"docker" "rm" "-f" "d8b0d1eb23810244d9e55a22c4fd0965ffd2815cdeb681881adfa573d4cea7f6"` [INFO] [stdout] d8b0d1eb23810244d9e55a22c4fd0965ffd2815cdeb681881adfa573d4cea7f6