[INFO] updating cached repository gnuvince/boobool [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gnuvince/boobool [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gnuvince/boobool" "work/ex/clippy-test-run/sources/stable/gh/gnuvince/boobool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gnuvince/boobool'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gnuvince/boobool" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gnuvince/boobool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gnuvince/boobool'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9196c11fa1f9b8e20452c46aca92a4a29a3bce2a [INFO] sha for GitHub repo gnuvince/boobool: 9196c11fa1f9b8e20452c46aca92a4a29a3bce2a [INFO] validating manifest of gnuvince/boobool on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gnuvince/boobool on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gnuvince/boobool [INFO] finished frobbing gnuvince/boobool [INFO] frobbed toml for gnuvince/boobool written to work/ex/clippy-test-run/sources/stable/gh/gnuvince/boobool/Cargo.toml [INFO] started frobbing gnuvince/boobool [INFO] finished frobbing gnuvince/boobool [INFO] frobbed toml for gnuvince/boobool written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gnuvince/boobool/Cargo.toml [INFO] crate gnuvince/boobool has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gnuvince/boobool against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gnuvince/boobool:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6405aa87e4c395a743f6e6c7ea1b697d98a5172ff7a8e78924b2bd0c4cd68abd [INFO] running `"docker" "start" "-a" "6405aa87e4c395a743f6e6c7ea1b697d98a5172ff7a8e78924b2bd0c4cd68abd"` [INFO] [stderr] Checking boobool v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:30:35 [INFO] [stderr] | [INFO] [stderr] 30 | let mut parser = Parser { tokens: tokens, offset: 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:20:37 [INFO] [stderr] | [INFO] [stderr] 20 | let mut scanner = Scanner { src: src, offset: 0 }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | ty: ty [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | ty: ty [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | ty: ty [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:30:35 [INFO] [stderr] | [INFO] [stderr] 30 | let mut parser = Parser { tokens: tokens, offset: 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:20:37 [INFO] [stderr] | [INFO] [stderr] 20 | let mut scanner = Scanner { src: src, offset: 0 }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | ty: ty [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transformers/ors.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | ty: ty [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | ty: ty [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typechecker.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/errors.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / return UntypedExpr { [INFO] [stderr] 17 | | category: ec, [INFO] [stderr] 18 | | pos: pos, [INFO] [stderr] 19 | | ty: () [INFO] [stderr] 20 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | UntypedExpr { [INFO] [stderr] 17 | category: ec, [INFO] [stderr] 18 | pos: pos, [INFO] [stderr] 19 | ty: () [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return parser.parse_expr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parser.parse_expr()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(expr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(expr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | return Ok(mkexpr(ExprCategory::Or(subexprs), pos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(mkexpr(ExprCategory::Or(subexprs), pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | return Ok(expr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(expr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | return Ok(mkexpr(ExprCategory::And(subexprs), pos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(mkexpr(ExprCategory::And(subexprs), pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | return Ok(op1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return Err(Error::InvalidOperator(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::InvalidOperator(self.offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | return Err(Error::InvalidOperator(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::InvalidOperator(self.offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(mkexpr(ExprCategory::List(exprs), initial_offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(mkexpr(ExprCategory::List(exprs), initial_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | return Ok(exprs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(exprs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | return self.peek_at(self.offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peek_at(self.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | return self.peek_at(self.offset - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peek_at(self.offset - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | return &self.tokens[self.tokens.len() - 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.tokens[self.tokens.len() - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | return &self.tokens[offset]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.tokens[offset]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | return t.cat == TC::Eof; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `t.cat == TC::Eof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return scanner.scan_expr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `scanner.scan_expr()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(toks); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(toks)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return Err(Error::UnknownCharacter(self.offset, self.peek())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::UnknownCharacter(self.offset, self.peek()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(Token::new(TC::StrLiteral, Some(buf), initial_offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::new(TC::StrLiteral, Some(buf), initial_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return Ok(Token::new(TC::Var, Some(buf), initial_offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::new(TC::Var, Some(buf), initial_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(Token::new(TC::FloatLiteral, Some(whole), initial_offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::new(TC::FloatLiteral, Some(whole), initial_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(Token::new(TC::IntLiteral, Some(integral_part), initial_offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::new(TC::IntLiteral, Some(integral_part), initial_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return self.peek_at(self.offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peek_at(self.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | return self.src[offset]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.src[offset]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | return self.peek() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peek() == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return Token { cat, lexeme, offset }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token { cat, lexeme, offset }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return s.parse::().map_err(|_| Error::InvalidIntLiteral(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.parse::().map_err(|_| Error::InvalidIntLiteral(self.offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return s.parse::().map_err(|_| Error::InvalidFloatLiteral(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.parse::().map_err(|_| Error::InvalidFloatLiteral(self.offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | / return TypedExpr { [INFO] [stderr] 19 | | category: ExprCategory::Or(subexprs), [INFO] [stderr] 20 | | pos: expr.pos, [INFO] [stderr] 21 | | ty: expr.ty [INFO] [stderr] 22 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 18 | TypedExpr { [INFO] [stderr] 19 | category: ExprCategory::Or(subexprs), [INFO] [stderr] 20 | pos: expr.pos, [INFO] [stderr] 21 | ty: expr.ty [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / return TypedExpr { [INFO] [stderr] 29 | | category: ExprCategory::And(subexprs), [INFO] [stderr] 30 | | pos: expr.pos, [INFO] [stderr] 31 | | ty: expr.ty [INFO] [stderr] 32 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | TypedExpr { [INFO] [stderr] 29 | category: ExprCategory::And(subexprs), [INFO] [stderr] 30 | pos: expr.pos, [INFO] [stderr] 31 | ty: expr.ty [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | / return TypedExpr { [INFO] [stderr] 37 | | category: ExprCategory::Not(Box::new(subexpr)), [INFO] [stderr] 38 | | pos: expr.pos, [INFO] [stderr] 39 | | ty: expr.ty [INFO] [stderr] 40 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | TypedExpr { [INFO] [stderr] 37 | category: ExprCategory::Not(Box::new(subexpr)), [INFO] [stderr] 38 | pos: expr.pos, [INFO] [stderr] 39 | ty: expr.ty [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | _ => { return expr; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | / return Some(TypedExpr { [INFO] [stderr] 131 | | category: ExprCategory::In( [INFO] [stderr] 132 | | Box::new(var), [INFO] [stderr] 133 | | Box::new(list) [INFO] [stderr] ... | [INFO] [stderr] 136 | | ty: ty [INFO] [stderr] 137 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 130 | Some(TypedExpr { [INFO] [stderr] 131 | category: ExprCategory::In( [INFO] [stderr] 132 | Box::new(var), [INFO] [stderr] 133 | Box::new(list) [INFO] [stderr] 134 | ), [INFO] [stderr] 135 | pos: pos, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | / return Some(TypedExpr { [INFO] [stderr] 208 | | category: ExprCategory::SetOp( [INFO] [stderr] 209 | | SetOp::OneOf, [INFO] [stderr] 210 | | Box::new(var), [INFO] [stderr] ... | [INFO] [stderr] 214 | | ty: ty [INFO] [stderr] 215 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 207 | Some(TypedExpr { [INFO] [stderr] 208 | category: ExprCategory::SetOp( [INFO] [stderr] 209 | SetOp::OneOf, [INFO] [stderr] 210 | Box::new(var), [INFO] [stderr] 211 | Box::new(list) [INFO] [stderr] 212 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/sort_lists.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return TypedExpr { category: new_cat, .. expr }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TypedExpr { category: new_cat, .. expr }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/sort_lists.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return sort_ints(exprs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sort_ints(exprs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/sort_lists.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return sort_strs(exprs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sort_strs(exprs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/sort_lists.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / return vals.into_iter() [INFO] [stderr] 67 | | .map(|x| TypedExpr { [INFO] [stderr] 68 | | category: ExprCategory::Int(x), [INFO] [stderr] 69 | | pos: 0, [INFO] [stderr] 70 | | ty: Type::Int [INFO] [stderr] 71 | | }) [INFO] [stderr] 72 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | vals.into_iter() [INFO] [stderr] 67 | .map(|x| TypedExpr { [INFO] [stderr] 68 | category: ExprCategory::Int(x), [INFO] [stderr] 69 | pos: 0, [INFO] [stderr] 70 | ty: Type::Int [INFO] [stderr] 71 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/sort_lists.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / return vals.into_iter() [INFO] [stderr] 85 | | .map(|x| TypedExpr { [INFO] [stderr] 86 | | category: ExprCategory::Str(x), [INFO] [stderr] 87 | | pos: 0, [INFO] [stderr] 88 | | ty: Type::Str [INFO] [stderr] 89 | | }) [INFO] [stderr] 90 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | vals.into_iter() [INFO] [stderr] 85 | .map(|x| TypedExpr { [INFO] [stderr] 86 | category: ExprCategory::Str(x), [INFO] [stderr] 87 | pos: 0, [INFO] [stderr] 88 | ty: Type::Str [INFO] [stderr] 89 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/null_checks.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / return TypedExpr { [INFO] [stderr] 134 | | category: ExprCategory::And(clauses), [INFO] [stderr] 135 | | pos: 0, [INFO] [stderr] 136 | | ty: Type::Bool [INFO] [stderr] 137 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 133 | TypedExpr { [INFO] [stderr] 134 | category: ExprCategory::And(clauses), [INFO] [stderr] 135 | pos: 0, [INFO] [stderr] 136 | ty: Type::Bool [INFO] [stderr] 137 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return expr; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Ok(texpr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(texpr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | / return Ok(TypedExpr { [INFO] [stderr] 93 | | category: ExprCategory::Not(Box::new(texpr)), [INFO] [stderr] 94 | | pos: pos, [INFO] [stderr] 95 | | ty: Type::Bool [INFO] [stderr] 96 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 92 | Ok(TypedExpr { [INFO] [stderr] 93 | category: ExprCategory::Not(Box::new(texpr)), [INFO] [stderr] 94 | pos: pos, [INFO] [stderr] 95 | ty: Type::Bool [INFO] [stderr] 96 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / return Ok(TypedExpr { [INFO] [stderr] 124 | | category: ExprCategory::List(texprs), [INFO] [stderr] 125 | | pos: pos, [INFO] [stderr] 126 | | ty: Type::List(Box::new(ty)) [INFO] [stderr] 127 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 123 | Ok(TypedExpr { [INFO] [stderr] 124 | category: ExprCategory::List(texprs), [INFO] [stderr] 125 | pos: pos, [INFO] [stderr] 126 | ty: Type::List(Box::new(ty)) [INFO] [stderr] 127 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | / return Ok(TypedExpr { [INFO] [stderr] 162 | | category: ExprCategory::Compare(op, Box::new(te1), Box::new(te2)), [INFO] [stderr] 163 | | pos: pos, [INFO] [stderr] 164 | | ty: Type::Bool [INFO] [stderr] 165 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 161 | Ok(TypedExpr { [INFO] [stderr] 162 | category: ExprCategory::Compare(op, Box::new(te1), Box::new(te2)), [INFO] [stderr] 163 | pos: pos, [INFO] [stderr] 164 | ty: Type::Bool [INFO] [stderr] 165 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | return Err(Error::InvalidOperation(pos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::InvalidOperation(pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | return Err(Error::IncorrectType(te2.pos, te1.ty, te2.ty)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::IncorrectType(te2.pos, te1.ty, te2.ty))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / return Ok(TypedExpr { [INFO] [stderr] 192 | | category: ExprCategory::In(Box::new(te1), Box::new(te2)), [INFO] [stderr] 193 | | pos: pos, [INFO] [stderr] 194 | | ty: Type::Bool [INFO] [stderr] 195 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 191 | Ok(TypedExpr { [INFO] [stderr] 192 | category: ExprCategory::In(Box::new(te1), Box::new(te2)), [INFO] [stderr] 193 | pos: pos, [INFO] [stderr] 194 | ty: Type::Bool [INFO] [stderr] 195 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / return Ok(TypedExpr { [INFO] [stderr] 215 | | category: ExprCategory::SetOp(op, Box::new(te1), Box::new(te2)), [INFO] [stderr] 216 | | pos: pos, [INFO] [stderr] 217 | | ty: Type::Bool [INFO] [stderr] 218 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 214 | Ok(TypedExpr { [INFO] [stderr] 215 | category: ExprCategory::SetOp(op, Box::new(te1), Box::new(te2)), [INFO] [stderr] 216 | pos: pos, [INFO] [stderr] 217 | ty: Type::Bool [INFO] [stderr] 218 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / return Ok(TypedExpr { [INFO] [stderr] 226 | | category: ExprCategory::IsNull(var), [INFO] [stderr] 227 | | pos: pos, [INFO] [stderr] 228 | | ty: Type::Bool, [INFO] [stderr] 229 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 225 | Ok(TypedExpr { [INFO] [stderr] 226 | category: ExprCategory::IsNull(var), [INFO] [stderr] 227 | pos: pos, [INFO] [stderr] 228 | ty: Type::Bool, [INFO] [stderr] 229 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(texprs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(texprs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | / return Ok(TypedExpr { [INFO] [stderr] 268 | | category: ExprCategory::Call(func_name, targs), [INFO] [stderr] 269 | | pos: pos, [INFO] [stderr] 270 | | ty: *result [INFO] [stderr] 271 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 267 | Ok(TypedExpr { [INFO] [stderr] 268 | category: ExprCategory::Call(func_name, targs), [INFO] [stderr] 269 | pos: pos, [INFO] [stderr] 270 | ty: *result [INFO] [stderr] 271 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return Symtable { symbols: HashMap::with_capacity(64) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Symtable { symbols: HashMap::with_capacity(64) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return self.symbols.get(var).map(|&(ref ty, _)| ty.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.symbols.get(var).map(|&(ref ty, _)| ty.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return self.symbols.get(var).map(|&(_, n)| n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.symbols.get(var).map(|&(_, n)| n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/errors.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / return UntypedExpr { [INFO] [stderr] 17 | | category: ec, [INFO] [stderr] 18 | | pos: pos, [INFO] [stderr] 19 | | ty: () [INFO] [stderr] 20 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | UntypedExpr { [INFO] [stderr] 17 | category: ec, [INFO] [stderr] 18 | pos: pos, [INFO] [stderr] 19 | ty: () [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return parser.parse_expr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parser.parse_expr()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(expr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(expr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | return Ok(mkexpr(ExprCategory::Or(subexprs), pos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(mkexpr(ExprCategory::Or(subexprs), pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | return Ok(expr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(expr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | return Ok(mkexpr(ExprCategory::And(subexprs), pos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(mkexpr(ExprCategory::And(subexprs), pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | return Ok(op1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return Err(Error::InvalidOperator(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::InvalidOperator(self.offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | return Err(Error::InvalidOperator(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::InvalidOperator(self.offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(mkexpr(ExprCategory::List(exprs), initial_offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(mkexpr(ExprCategory::List(exprs), initial_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | return Ok(exprs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(exprs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | return self.peek_at(self.offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peek_at(self.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | return self.peek_at(self.offset - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peek_at(self.offset - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | return &self.tokens[self.tokens.len() - 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.tokens[self.tokens.len() - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | return &self.tokens[offset]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.tokens[offset]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | return t.cat == TC::Eof; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `t.cat == TC::Eof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:446:9 [INFO] [stderr] | [INFO] [stderr] 446 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return scanner.scan_expr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `scanner.scan_expr()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(toks); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(toks)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return Err(Error::UnknownCharacter(self.offset, self.peek())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::UnknownCharacter(self.offset, self.peek()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(Token::new(TC::StrLiteral, Some(buf), initial_offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::new(TC::StrLiteral, Some(buf), initial_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return Ok(Token::new(TC::Var, Some(buf), initial_offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::new(TC::Var, Some(buf), initial_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(Token::new(TC::FloatLiteral, Some(whole), initial_offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::new(TC::FloatLiteral, Some(whole), initial_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(Token::new(TC::IntLiteral, Some(integral_part), initial_offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::new(TC::IntLiteral, Some(integral_part), initial_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return self.peek_at(self.offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peek_at(self.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | return self.src[offset]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.src[offset]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | return self.peek() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peek() == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return Token { cat, lexeme, offset }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token { cat, lexeme, offset }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return s.parse::().map_err(|_| Error::InvalidIntLiteral(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.parse::().map_err(|_| Error::InvalidIntLiteral(self.offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokens.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return s.parse::().map_err(|_| Error::InvalidFloatLiteral(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.parse::().map_err(|_| Error::InvalidFloatLiteral(self.offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | / return TypedExpr { [INFO] [stderr] 19 | | category: ExprCategory::Or(subexprs), [INFO] [stderr] 20 | | pos: expr.pos, [INFO] [stderr] 21 | | ty: expr.ty [INFO] [stderr] 22 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 18 | TypedExpr { [INFO] [stderr] 19 | category: ExprCategory::Or(subexprs), [INFO] [stderr] 20 | pos: expr.pos, [INFO] [stderr] 21 | ty: expr.ty [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / return TypedExpr { [INFO] [stderr] 29 | | category: ExprCategory::And(subexprs), [INFO] [stderr] 30 | | pos: expr.pos, [INFO] [stderr] 31 | | ty: expr.ty [INFO] [stderr] 32 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | TypedExpr { [INFO] [stderr] 29 | category: ExprCategory::And(subexprs), [INFO] [stderr] 30 | pos: expr.pos, [INFO] [stderr] 31 | ty: expr.ty [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | / return TypedExpr { [INFO] [stderr] 37 | | category: ExprCategory::Not(Box::new(subexpr)), [INFO] [stderr] 38 | | pos: expr.pos, [INFO] [stderr] 39 | | ty: expr.ty [INFO] [stderr] 40 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | TypedExpr { [INFO] [stderr] 37 | category: ExprCategory::Not(Box::new(subexpr)), [INFO] [stderr] 38 | pos: expr.pos, [INFO] [stderr] 39 | ty: expr.ty [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | _ => { return expr; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | / return Some(TypedExpr { [INFO] [stderr] 131 | | category: ExprCategory::In( [INFO] [stderr] 132 | | Box::new(var), [INFO] [stderr] 133 | | Box::new(list) [INFO] [stderr] ... | [INFO] [stderr] 136 | | ty: ty [INFO] [stderr] 137 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 130 | Some(TypedExpr { [INFO] [stderr] 131 | category: ExprCategory::In( [INFO] [stderr] 132 | Box::new(var), [INFO] [stderr] 133 | Box::new(list) [INFO] [stderr] 134 | ), [INFO] [stderr] 135 | pos: pos, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/ors.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | / return Some(TypedExpr { [INFO] [stderr] 208 | | category: ExprCategory::SetOp( [INFO] [stderr] 209 | | SetOp::OneOf, [INFO] [stderr] 210 | | Box::new(var), [INFO] [stderr] ... | [INFO] [stderr] 214 | | ty: ty [INFO] [stderr] 215 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 207 | Some(TypedExpr { [INFO] [stderr] 208 | category: ExprCategory::SetOp( [INFO] [stderr] 209 | SetOp::OneOf, [INFO] [stderr] 210 | Box::new(var), [INFO] [stderr] 211 | Box::new(list) [INFO] [stderr] 212 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/sort_lists.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return TypedExpr { category: new_cat, .. expr }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TypedExpr { category: new_cat, .. expr }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/sort_lists.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return sort_ints(exprs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sort_ints(exprs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/sort_lists.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return sort_strs(exprs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sort_strs(exprs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/sort_lists.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / return vals.into_iter() [INFO] [stderr] 67 | | .map(|x| TypedExpr { [INFO] [stderr] 68 | | category: ExprCategory::Int(x), [INFO] [stderr] 69 | | pos: 0, [INFO] [stderr] 70 | | ty: Type::Int [INFO] [stderr] 71 | | }) [INFO] [stderr] 72 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | vals.into_iter() [INFO] [stderr] 67 | .map(|x| TypedExpr { [INFO] [stderr] 68 | category: ExprCategory::Int(x), [INFO] [stderr] 69 | pos: 0, [INFO] [stderr] 70 | ty: Type::Int [INFO] [stderr] 71 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/sort_lists.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / return vals.into_iter() [INFO] [stderr] 85 | | .map(|x| TypedExpr { [INFO] [stderr] 86 | | category: ExprCategory::Str(x), [INFO] [stderr] 87 | | pos: 0, [INFO] [stderr] 88 | | ty: Type::Str [INFO] [stderr] 89 | | }) [INFO] [stderr] 90 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | vals.into_iter() [INFO] [stderr] 85 | .map(|x| TypedExpr { [INFO] [stderr] 86 | category: ExprCategory::Str(x), [INFO] [stderr] 87 | pos: 0, [INFO] [stderr] 88 | ty: Type::Str [INFO] [stderr] 89 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/null_checks.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / return TypedExpr { [INFO] [stderr] 134 | | category: ExprCategory::And(clauses), [INFO] [stderr] 135 | | pos: 0, [INFO] [stderr] 136 | | ty: Type::Bool [INFO] [stderr] 137 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 133 | TypedExpr { [INFO] [stderr] 134 | category: ExprCategory::And(clauses), [INFO] [stderr] 135 | pos: 0, [INFO] [stderr] 136 | ty: Type::Bool [INFO] [stderr] 137 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transformers/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return expr; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Ok(texpr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(texpr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | / return Ok(TypedExpr { [INFO] [stderr] 93 | | category: ExprCategory::Not(Box::new(texpr)), [INFO] [stderr] 94 | | pos: pos, [INFO] [stderr] 95 | | ty: Type::Bool [INFO] [stderr] 96 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 92 | Ok(TypedExpr { [INFO] [stderr] 93 | category: ExprCategory::Not(Box::new(texpr)), [INFO] [stderr] 94 | pos: pos, [INFO] [stderr] 95 | ty: Type::Bool [INFO] [stderr] 96 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / return Ok(TypedExpr { [INFO] [stderr] 124 | | category: ExprCategory::List(texprs), [INFO] [stderr] 125 | | pos: pos, [INFO] [stderr] 126 | | ty: Type::List(Box::new(ty)) [INFO] [stderr] 127 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 123 | Ok(TypedExpr { [INFO] [stderr] 124 | category: ExprCategory::List(texprs), [INFO] [stderr] 125 | pos: pos, [INFO] [stderr] 126 | ty: Type::List(Box::new(ty)) [INFO] [stderr] 127 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | / return Ok(TypedExpr { [INFO] [stderr] 162 | | category: ExprCategory::Compare(op, Box::new(te1), Box::new(te2)), [INFO] [stderr] 163 | | pos: pos, [INFO] [stderr] 164 | | ty: Type::Bool [INFO] [stderr] 165 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 161 | Ok(TypedExpr { [INFO] [stderr] 162 | category: ExprCategory::Compare(op, Box::new(te1), Box::new(te2)), [INFO] [stderr] 163 | pos: pos, [INFO] [stderr] 164 | ty: Type::Bool [INFO] [stderr] 165 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | return Err(Error::InvalidOperation(pos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::InvalidOperation(pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | return Err(Error::IncorrectType(te2.pos, te1.ty, te2.ty)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::IncorrectType(te2.pos, te1.ty, te2.ty))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / return Ok(TypedExpr { [INFO] [stderr] 192 | | category: ExprCategory::In(Box::new(te1), Box::new(te2)), [INFO] [stderr] 193 | | pos: pos, [INFO] [stderr] 194 | | ty: Type::Bool [INFO] [stderr] 195 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 191 | Ok(TypedExpr { [INFO] [stderr] 192 | category: ExprCategory::In(Box::new(te1), Box::new(te2)), [INFO] [stderr] 193 | pos: pos, [INFO] [stderr] 194 | ty: Type::Bool [INFO] [stderr] 195 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / return Ok(TypedExpr { [INFO] [stderr] 215 | | category: ExprCategory::SetOp(op, Box::new(te1), Box::new(te2)), [INFO] [stderr] 216 | | pos: pos, [INFO] [stderr] 217 | | ty: Type::Bool [INFO] [stderr] 218 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 214 | Ok(TypedExpr { [INFO] [stderr] 215 | category: ExprCategory::SetOp(op, Box::new(te1), Box::new(te2)), [INFO] [stderr] 216 | pos: pos, [INFO] [stderr] 217 | ty: Type::Bool [INFO] [stderr] 218 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / return Ok(TypedExpr { [INFO] [stderr] 226 | | category: ExprCategory::IsNull(var), [INFO] [stderr] 227 | | pos: pos, [INFO] [stderr] 228 | | ty: Type::Bool, [INFO] [stderr] 229 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 225 | Ok(TypedExpr { [INFO] [stderr] 226 | category: ExprCategory::IsNull(var), [INFO] [stderr] 227 | pos: pos, [INFO] [stderr] 228 | ty: Type::Bool, [INFO] [stderr] 229 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(texprs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(texprs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | / return Ok(TypedExpr { [INFO] [stderr] 268 | | category: ExprCategory::Call(func_name, targs), [INFO] [stderr] 269 | | pos: pos, [INFO] [stderr] 270 | | ty: *result [INFO] [stderr] 271 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 267 | Ok(TypedExpr { [INFO] [stderr] 268 | category: ExprCategory::Call(func_name, targs), [INFO] [stderr] 269 | pos: pos, [INFO] [stderr] 270 | ty: *result [INFO] [stderr] 271 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/typechecker.rs:431:9 [INFO] [stderr] | [INFO] [stderr] 431 | return typecheck(uexpr, &st); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `typecheck(uexpr, &st)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return Symtable { symbols: HashMap::with_capacity(64) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Symtable { symbols: HashMap::with_capacity(64) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return self.symbols.get(var).map(|&(ref ty, _)| ty.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.symbols.get(var).map(|&(ref ty, _)| ty.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return self.symbols.get(var).map(|&(_, n)| n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.symbols.get(var).map(|&(_, n)| n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/errors.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | format!("{}", name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/errors.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | format!("{}", name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | .ok_or(Error::MissingLexeme(self.offset)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingLexeme(self.offset))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/transformers/sort_lists.rs:19:53 [INFO] [stderr] | [INFO] [stderr] 19 | let subexprs = subexprs.into_iter().map(|x| sort_lists(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `sort_lists` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/transformers/sort_lists.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | let subexprs = subexprs.into_iter().map(|x| sort_lists(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `sort_lists` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/typechecker.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | let is_ok = match &texpr.ty { [INFO] [stderr] | _________________________^ [INFO] [stderr] 85 | | &Type::Bool => true, [INFO] [stderr] 86 | | _ => false [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 84 | let is_ok = match texpr.ty { [INFO] [stderr] 85 | Type::Bool => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/typechecker.rs:224:10 [INFO] [stderr] | [INFO] [stderr] 224 | .ok_or(Error::UndeclaredVariable(pos, var.clone()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::UndeclaredVariable(pos, var.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/typechecker.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | / match &texpr.ty { [INFO] [stderr] 238 | | &Type::Bool => texprs.push(texpr), [INFO] [stderr] 239 | | _ => { return Err(Error::IncorrectType(texpr.pos, Type::Bool, texpr.ty)) } [INFO] [stderr] 240 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 237 | match texpr.ty { [INFO] [stderr] 238 | Type::Bool => texprs.push(texpr), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/typechecker.rs:250:10 [INFO] [stderr] | [INFO] [stderr] 250 | .ok_or(Error::UndeclaredVariable(pos, func_name.clone()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::UndeclaredVariable(pos, func_name.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::Symtable` [INFO] [stderr] --> src/types.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new() -> Symtable { [INFO] [stderr] 56 | | return Symtable { symbols: HashMap::with_capacity(64) }; [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/errors.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | format!("{}", name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/errors.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | format!("{}", name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return st; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `st` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/parser.rs:374:1 [INFO] [stderr] | [INFO] [stderr] 374 | / fn test_list_ops() { [INFO] [stderr] 375 | | assert!(test::parse(b"x in xs").is_ok()); [INFO] [stderr] 376 | | assert!(test::parse(b"x in (1,2,3)").is_ok()); [INFO] [stderr] 377 | | assert!(test::parse(b"1 in (1,2,3)").is_ok()); [INFO] [stderr] ... | [INFO] [stderr] 402 | | assert!(test::parse(b"(1,2) all of xs").is_err()); [INFO] [stderr] 403 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/scanner.rs:172:1 [INFO] [stderr] | [INFO] [stderr] 172 | / fn test_scanner_basic_tokens() { [INFO] [stderr] 173 | | assert!(Scanner::scan(b"(".to_vec()).is_ok()); [INFO] [stderr] 174 | | assert!(Scanner::scan(b")".to_vec()).is_ok()); [INFO] [stderr] 175 | | assert!(Scanner::scan(b"=".to_vec()).is_ok()); [INFO] [stderr] ... | [INFO] [stderr] 208 | | }); [INFO] [stderr] 209 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/scanner.rs:290:35 [INFO] [stderr] | [INFO] [stderr] 290 | Scanner::scan(input.to_vec()).unwrap_or(vec![]).iter().map(|t| t.cat).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return st; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `st` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | .ok_or(Error::MissingLexeme(self.offset)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingLexeme(self.offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/transformers/sort_lists.rs:19:53 [INFO] [stderr] | [INFO] [stderr] 19 | let subexprs = subexprs.into_iter().map(|x| sort_lists(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `sort_lists` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/transformers/sort_lists.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | let subexprs = subexprs.into_iter().map(|x| sort_lists(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `sort_lists` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/typechecker.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | let is_ok = match &texpr.ty { [INFO] [stderr] | _________________________^ [INFO] [stderr] 85 | | &Type::Bool => true, [INFO] [stderr] 86 | | _ => false [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 84 | let is_ok = match texpr.ty { [INFO] [stderr] 85 | Type::Bool => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/typechecker.rs:224:10 [INFO] [stderr] | [INFO] [stderr] 224 | .ok_or(Error::UndeclaredVariable(pos, var.clone()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::UndeclaredVariable(pos, var.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/typechecker.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | / match &texpr.ty { [INFO] [stderr] 238 | | &Type::Bool => texprs.push(texpr), [INFO] [stderr] 239 | | _ => { return Err(Error::IncorrectType(texpr.pos, Type::Bool, texpr.ty)) } [INFO] [stderr] 240 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 237 | match texpr.ty { [INFO] [stderr] 238 | Type::Bool => texprs.push(texpr), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/typechecker.rs:250:10 [INFO] [stderr] | [INFO] [stderr] 250 | .ok_or(Error::UndeclaredVariable(pos, func_name.clone()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::UndeclaredVariable(pos, func_name.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/typechecker.rs:276:1 [INFO] [stderr] | [INFO] [stderr] 276 | / fn test_compare() { [INFO] [stderr] 277 | | assert!(test::tc(b"i = 1").is_ok()); [INFO] [stderr] 278 | | assert!(test::tc(b"i <> 1").is_ok()); [INFO] [stderr] 279 | | assert!(test::tc(b"i < 1").is_ok()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | }); [INFO] [stderr] 331 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/typechecker.rs:335:1 [INFO] [stderr] | [INFO] [stderr] 335 | / fn test_set_ops() { [INFO] [stderr] 336 | | assert!(test::tc(b"i in (1, 2, 3)").is_ok()); [INFO] [stderr] 337 | | assert!(test::tc(b"b in (1, 2, 3)").is_err()); [INFO] [stderr] 338 | | assert!(test::tc(b"f in (1, 2, 3)").is_err()); [INFO] [stderr] ... | [INFO] [stderr] 386 | | assert!(test::tc(b"s all of (1, 2, 3)").is_err()); [INFO] [stderr] 387 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::Symtable` [INFO] [stderr] --> src/types.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new() -> Symtable { [INFO] [stderr] 56 | | return Symtable { symbols: HashMap::with_capacity(64) }; [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.63s [INFO] running `"docker" "inspect" "6405aa87e4c395a743f6e6c7ea1b697d98a5172ff7a8e78924b2bd0c4cd68abd"` [INFO] running `"docker" "rm" "-f" "6405aa87e4c395a743f6e6c7ea1b697d98a5172ff7a8e78924b2bd0c4cd68abd"` [INFO] [stdout] 6405aa87e4c395a743f6e6c7ea1b697d98a5172ff7a8e78924b2bd0c4cd68abd