[INFO] updating cached repository gnmerritt/etf-balancer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gnmerritt/etf-balancer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gnmerritt/etf-balancer" "work/ex/clippy-test-run/sources/stable/gh/gnmerritt/etf-balancer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gnmerritt/etf-balancer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gnmerritt/etf-balancer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gnmerritt/etf-balancer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gnmerritt/etf-balancer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a7e9a0175b9ec07e237dd8d46417bfdcb19d1718 [INFO] sha for GitHub repo gnmerritt/etf-balancer: a7e9a0175b9ec07e237dd8d46417bfdcb19d1718 [INFO] validating manifest of gnmerritt/etf-balancer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gnmerritt/etf-balancer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gnmerritt/etf-balancer [INFO] finished frobbing gnmerritt/etf-balancer [INFO] frobbed toml for gnmerritt/etf-balancer written to work/ex/clippy-test-run/sources/stable/gh/gnmerritt/etf-balancer/Cargo.toml [INFO] started frobbing gnmerritt/etf-balancer [INFO] finished frobbing gnmerritt/etf-balancer [INFO] frobbed toml for gnmerritt/etf-balancer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gnmerritt/etf-balancer/Cargo.toml [INFO] crate gnmerritt/etf-balancer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gnmerritt/etf-balancer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gnmerritt/etf-balancer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12b0dd3a6bfcf21b4d0e75392713b61634446e4a9ed2285a1cd7366960551f13 [INFO] running `"docker" "start" "-a" "12b0dd3a6bfcf21b4d0e75392713b61634446e4a9ed2285a1cd7366960551f13"` [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling serde v1.0.66 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Compiling actix_derive v0.2.0 [INFO] [stderr] Checking streaming-stats v0.2.0 [INFO] [stderr] Checking h2 v0.1.9 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Compiling backtrace v0.3.8 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking spectral v0.6.0 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling serde_json v1.0.19 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Compiling cargo_metadata v0.5.5 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Compiling actix v0.5.7 [INFO] [stderr] Checking actix-web v0.6.10 [INFO] [stderr] Checking etf_balancer v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/accounts/balancer.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub fn run_balancing(portfolio: Portfolio) -> Results { [INFO] [stderr] 5 | | let total_value = portfolio.total_value(); [INFO] [stderr] 6 | | let allocations = c!{ s => w * total_value, for (s, w) in portfolio.target.iter() }; [INFO] [stderr] 7 | | let total_shares = portfolio.total_shares(); [INFO] [stderr] ... | [INFO] [stderr] 154 | | results [INFO] [stderr] 155 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/accounts/balancer.rs:11:73 [INFO] [stderr] | [INFO] [stderr] 11 | let cash_delta = c!{ s => a - total_shares.get(s).unwrap_or(&0.0) * prices.get(s).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&prices[s]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/accounts/balancer.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | / match results.buy_maybe(&account.name, sym, price, -1.0 * to_sell) { [INFO] [stderr] 57 | | Some(_) => { [INFO] [stderr] 58 | | *delta += to_sell; [INFO] [stderr] 59 | | println!("In acct={} sold {} x {}@{}, fc={:?}. Remaining delta={}", [INFO] [stderr] ... | [INFO] [stderr] 62 | | _ => () [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(_) = results.buy_maybe(&account.name, sym, price, -1.0 * to_sell) { [INFO] [stderr] 57 | *delta += to_sell; [INFO] [stderr] 58 | println!("In acct={} sold {} x {}@{}, fc={:?}. Remaining delta={}", [INFO] [stderr] 59 | account.name, to_sell, sym, price, &results.cash, delta); [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/accounts/balancer.rs:80:41 [INFO] [stderr] | [INFO] [stderr] 80 | Some(median) if *div_yield as f64 > median => (), // success! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(*div_yield)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/accounts/balancer.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / match results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 93 | | Some(_) => { [INFO] [stderr] 94 | | none_left = false; [INFO] [stderr] 95 | | *shares -= 1.0; [INFO] [stderr] ... | [INFO] [stderr] 98 | | _ => () [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(_) = results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 93 | none_left = false; [INFO] [stderr] 94 | *shares -= 1.0; [INFO] [stderr] 95 | println!("high-yield: acct={}, bought {}@{}, fc={:?}", account.name, sym, price, results.cash); [INFO] [stderr] 96 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/accounts/balancer.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | / match results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 116 | | Some(_) => { [INFO] [stderr] 117 | | none_left = false; [INFO] [stderr] 118 | | *shares -= 1.0; [INFO] [stderr] ... | [INFO] [stderr] 121 | | _ => () [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Some(_) = results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 116 | none_left = false; [INFO] [stderr] 117 | *shares -= 1.0; [INFO] [stderr] 118 | println!("acct={}, bought {}@{}, fc={:?}", account.name, sym, price, results.cash); [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/accounts/balancer.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | / match results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 137 | | Some(_) => { [INFO] [stderr] 138 | | none_left = false; [INFO] [stderr] 139 | | println!("extra: acct={}, bought {}@{}, fc={:?}", account.name, sym, price, results.cash); [INFO] [stderr] ... | [INFO] [stderr] 142 | | _ => () [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 136 | if let Some(_) = results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 137 | none_left = false; [INFO] [stderr] 138 | println!("extra: acct={}, bought {}@{}, fc={:?}", account.name, sym, price, results.cash); [INFO] [stderr] 139 | break; // we found an account to hold the extra share, move on to next fund [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `accounts::Portfolio` [INFO] [stderr] --> src/accounts/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Portfolio { [INFO] [stderr] 16 | | target: HashMap::new(), accounts: vec!(), market: vec!(), no_taxed_sales: None [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/accounts/mod.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | fn value(&self, market: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Investment]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/accounts/mod.rs:119:37 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn from_positions(accounts: &Vec) -> Results { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Account]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/accounts/mod.rs:140:65 [INFO] [stderr] | [INFO] [stderr] 140 | let account = self.positions.entry(account.to_string()).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/accounts/mod.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | *gross = *gross / total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*gross /= total` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/accounts/balancer.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub fn run_balancing(portfolio: Portfolio) -> Results { [INFO] [stderr] 5 | | let total_value = portfolio.total_value(); [INFO] [stderr] 6 | | let allocations = c!{ s => w * total_value, for (s, w) in portfolio.target.iter() }; [INFO] [stderr] 7 | | let total_shares = portfolio.total_shares(); [INFO] [stderr] ... | [INFO] [stderr] 154 | | results [INFO] [stderr] 155 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/accounts/balancer.rs:11:73 [INFO] [stderr] | [INFO] [stderr] 11 | let cash_delta = c!{ s => a - total_shares.get(s).unwrap_or(&0.0) * prices.get(s).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&prices[s]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/accounts/balancer.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | / match results.buy_maybe(&account.name, sym, price, -1.0 * to_sell) { [INFO] [stderr] 57 | | Some(_) => { [INFO] [stderr] 58 | | *delta += to_sell; [INFO] [stderr] 59 | | println!("In acct={} sold {} x {}@{}, fc={:?}. Remaining delta={}", [INFO] [stderr] ... | [INFO] [stderr] 62 | | _ => () [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(_) = results.buy_maybe(&account.name, sym, price, -1.0 * to_sell) { [INFO] [stderr] 57 | *delta += to_sell; [INFO] [stderr] 58 | println!("In acct={} sold {} x {}@{}, fc={:?}. Remaining delta={}", [INFO] [stderr] 59 | account.name, to_sell, sym, price, &results.cash, delta); [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/accounts/balancer.rs:80:41 [INFO] [stderr] | [INFO] [stderr] 80 | Some(median) if *div_yield as f64 > median => (), // success! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(*div_yield)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/accounts/balancer.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / match results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 93 | | Some(_) => { [INFO] [stderr] 94 | | none_left = false; [INFO] [stderr] 95 | | *shares -= 1.0; [INFO] [stderr] ... | [INFO] [stderr] 98 | | _ => () [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(_) = results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 93 | none_left = false; [INFO] [stderr] 94 | *shares -= 1.0; [INFO] [stderr] 95 | println!("high-yield: acct={}, bought {}@{}, fc={:?}", account.name, sym, price, results.cash); [INFO] [stderr] 96 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/accounts/balancer.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | / match results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 116 | | Some(_) => { [INFO] [stderr] 117 | | none_left = false; [INFO] [stderr] 118 | | *shares -= 1.0; [INFO] [stderr] ... | [INFO] [stderr] 121 | | _ => () [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Some(_) = results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 116 | none_left = false; [INFO] [stderr] 117 | *shares -= 1.0; [INFO] [stderr] 118 | println!("acct={}, bought {}@{}, fc={:?}", account.name, sym, price, results.cash); [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/accounts/balancer.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | / match results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 137 | | Some(_) => { [INFO] [stderr] 138 | | none_left = false; [INFO] [stderr] 139 | | println!("extra: acct={}, bought {}@{}, fc={:?}", account.name, sym, price, results.cash); [INFO] [stderr] ... | [INFO] [stderr] 142 | | _ => () [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 136 | if let Some(_) = results.buy_maybe(&account.name, sym, price, 1.0) { [INFO] [stderr] 137 | none_left = false; [INFO] [stderr] 138 | println!("extra: acct={}, bought {}@{}, fc={:?}", account.name, sym, price, results.cash); [INFO] [stderr] 139 | break; // we found an account to hold the extra share, move on to next fund [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `accounts::Portfolio` [INFO] [stderr] --> src/accounts/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Portfolio { [INFO] [stderr] 16 | | target: HashMap::new(), accounts: vec!(), market: vec!(), no_taxed_sales: None [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/accounts/mod.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | fn value(&self, market: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Investment]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/accounts/mod.rs:119:37 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn from_positions(accounts: &Vec) -> Results { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Account]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/accounts/mod.rs:140:65 [INFO] [stderr] | [INFO] [stderr] 140 | let account = self.positions.entry(account.to_string()).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/accounts/mod.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | *gross = *gross / total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*gross /= total` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/accounts/mod.rs:237:21 [INFO] [stderr] | [INFO] [stderr] 237 | assert_that(shares.get("A").unwrap()).is_close_to(5.0, 0.001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&shares["A"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/accounts/mod.rs:238:21 [INFO] [stderr] | [INFO] [stderr] 238 | assert_that(shares.get("B").unwrap()).is_close_to(30.0, 0.001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&shares["B"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/accounts/mod.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | assert_eq!(account.value(&market), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/accounts/mod.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | assert_eq!(account.value(&market), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/accounts/mod.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | assert_eq!(account.value(&market), account.cash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/accounts/mod.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | assert_eq!(account.value(&market), account.cash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/accounts/mod.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | assert_eq!(account.value(&market), 131.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/accounts/mod.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | assert_eq!(account.value(&market), 131.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `etf_balancer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "12b0dd3a6bfcf21b4d0e75392713b61634446e4a9ed2285a1cd7366960551f13"` [INFO] running `"docker" "rm" "-f" "12b0dd3a6bfcf21b4d0e75392713b61634446e4a9ed2285a1cd7366960551f13"` [INFO] [stdout] 12b0dd3a6bfcf21b4d0e75392713b61634446e4a9ed2285a1cd7366960551f13