[INFO] updating cached repository gmbeard/advent_of_code_day_1
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/gmbeard/advent_of_code_day_1
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/gmbeard/advent_of_code_day_1" "work/ex/clippy-test-run/sources/stable/gh/gmbeard/advent_of_code_day_1"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gmbeard/advent_of_code_day_1'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/gmbeard/advent_of_code_day_1" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmbeard/advent_of_code_day_1"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmbeard/advent_of_code_day_1'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8e597f3c28b4baf2a350e14ce11a55d5c754225d
[INFO] sha for GitHub repo gmbeard/advent_of_code_day_1: 8e597f3c28b4baf2a350e14ce11a55d5c754225d
[INFO] validating manifest of gmbeard/advent_of_code_day_1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gmbeard/advent_of_code_day_1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gmbeard/advent_of_code_day_1
[INFO] finished frobbing gmbeard/advent_of_code_day_1
[INFO] frobbed toml for gmbeard/advent_of_code_day_1 written to work/ex/clippy-test-run/sources/stable/gh/gmbeard/advent_of_code_day_1/Cargo.toml
[INFO] started frobbing gmbeard/advent_of_code_day_1
[INFO] finished frobbing gmbeard/advent_of_code_day_1
[INFO] frobbed toml for gmbeard/advent_of_code_day_1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmbeard/advent_of_code_day_1/Cargo.toml
[INFO] crate gmbeard/advent_of_code_day_1 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gmbeard/advent_of_code_day_1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gmbeard/advent_of_code_day_1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e7125740ae311b409dadb84673e247ee700f9784277f93e73e7433696afc95df
[INFO] running `"docker" "start" "-a" "e7125740ae311b409dadb84673e247ee700f9784277f93e73e7433696afc95df"`
[INFO] [stderr]     Checking day1 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/neighbour.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 |             current: current,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `current`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/neighbour.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 |             current: current,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `current`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/digits.rs:12:12
[INFO] [stderr]    |
[INFO] [stderr] 12 |         if self.0.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.0.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/digits.rs:20:46
[INFO] [stderr]    |
[INFO] [stderr] 20 |             b'0'...b'9' => Some(IsDigit::Yes((head[0] - b'0') as _)),
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(head[0] - b'0')`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/digits.rs:26:1
[INFO] [stderr]    |
[INFO] [stderr] 26 | / pub fn as_digits<'a>(chars: &'a str) -> AsDigitsIter<'a> {
[INFO] [stderr] 27 | |     AsDigitsIter(chars.as_bytes())
[INFO] [stderr] 28 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/digits.rs:36:25
[INFO] [stderr]    |
[INFO] [stderr] 36 |         const NUMBERS: &'static str = "123456";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/digits.rs:12:12
[INFO] [stderr]    |
[INFO] [stderr] 12 |         if self.0.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.0.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/digits.rs:20:46
[INFO] [stderr]    |
[INFO] [stderr] 20 |             b'0'...b'9' => Some(IsDigit::Yes((head[0] - b'0') as _)),
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(head[0] - b'0')`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/digits.rs:26:1
[INFO] [stderr]    |
[INFO] [stderr] 26 | / pub fn as_digits<'a>(chars: &'a str) -> AsDigitsIter<'a> {
[INFO] [stderr] 27 | |     AsDigitsIter(chars.as_bytes())
[INFO] [stderr] 28 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.69s
[INFO] running `"docker" "inspect" "e7125740ae311b409dadb84673e247ee700f9784277f93e73e7433696afc95df"`
[INFO] running `"docker" "rm" "-f" "e7125740ae311b409dadb84673e247ee700f9784277f93e73e7433696afc95df"`
[INFO] [stdout] e7125740ae311b409dadb84673e247ee700f9784277f93e73e7433696afc95df