[INFO] updating cached repository gmanlynam/rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gmanlynam/rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gmanlynam/rust" "work/ex/clippy-test-run/sources/stable/gh/gmanlynam/rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gmanlynam/rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gmanlynam/rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmanlynam/rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmanlynam/rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e1e6c99632fa54b8249fd749c53137230c2d2b4b [INFO] sha for GitHub repo gmanlynam/rust: e1e6c99632fa54b8249fd749c53137230c2d2b4b [INFO] validating manifest of gmanlynam/rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gmanlynam/rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gmanlynam/rust [INFO] finished frobbing gmanlynam/rust [INFO] frobbed toml for gmanlynam/rust written to work/ex/clippy-test-run/sources/stable/gh/gmanlynam/rust/Cargo.toml [INFO] started frobbing gmanlynam/rust [INFO] finished frobbing gmanlynam/rust [INFO] frobbed toml for gmanlynam/rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmanlynam/rust/Cargo.toml [INFO] crate gmanlynam/rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gmanlynam/rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gmanlynam/rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3b1b4b4fc4c0030742b8682495d3ff200bac1448401430d734845f6f95280326 [INFO] running `"docker" "start" "-a" "3b1b4b4fc4c0030742b8682495d3ff200bac1448401430d734845f6f95280326"` [INFO] [stderr] Checking simple_logger v0.5.0 [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking persistent v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking mars_rover v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/command_processor.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return (cord, lefty, direction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(cord, lefty, direction)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/command_processor.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return (cord, lefty, direction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(cord, lefty, direction)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command_processor.rs:74:30 [INFO] [stderr] | [INFO] [stderr] 74 | response.set_mut(format!("form data has no 'n' parameter\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"form data has no 'n' parameter\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command_processor.rs:74:30 [INFO] [stderr] | [INFO] [stderr] 74 | response.set_mut(format!("form data has no 'n' parameter\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"form data has no 'n' parameter\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.43s [INFO] running `"docker" "inspect" "3b1b4b4fc4c0030742b8682495d3ff200bac1448401430d734845f6f95280326"` [INFO] running `"docker" "rm" "-f" "3b1b4b4fc4c0030742b8682495d3ff200bac1448401430d734845f6f95280326"` [INFO] [stdout] 3b1b4b4fc4c0030742b8682495d3ff200bac1448401430d734845f6f95280326