[INFO] updating cached repository glynos/adventofcode_2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/glynos/adventofcode_2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/glynos/adventofcode_2018" "work/ex/clippy-test-run/sources/stable/gh/glynos/adventofcode_2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/glynos/adventofcode_2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/glynos/adventofcode_2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/glynos/adventofcode_2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/glynos/adventofcode_2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7a56d1ea92d4ba101765b3dca8315d86941f17f6
[INFO] sha for GitHub repo glynos/adventofcode_2018: 7a56d1ea92d4ba101765b3dca8315d86941f17f6
[INFO] validating manifest of glynos/adventofcode_2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of glynos/adventofcode_2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing glynos/adventofcode_2018
[INFO] finished frobbing glynos/adventofcode_2018
[INFO] frobbed toml for glynos/adventofcode_2018 written to work/ex/clippy-test-run/sources/stable/gh/glynos/adventofcode_2018/Cargo.toml
[INFO] started frobbing glynos/adventofcode_2018
[INFO] finished frobbing glynos/adventofcode_2018
[INFO] frobbed toml for glynos/adventofcode_2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/glynos/adventofcode_2018/Cargo.toml
[INFO] crate glynos/adventofcode_2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting glynos/adventofcode_2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/glynos/adventofcode_2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c7b4246182b47f884a153acf11227ba9b22a9b8b5f840960f1cbcb2cf7c6dcfe
[INFO] running `"docker" "start" "-a" "c7b4246182b47f884a153acf11227ba9b22a9b8b5f840960f1cbcb2cf7c6dcfe"`
[INFO] [stderr]     Checking adventofcode_2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_2/bin/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     return (min(twos as u64, 1), min(threes as u64, 1));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(min(twos as u64, 1), min(threes as u64, 1))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_2/bin/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return differences;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `differences`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/day_2/bin/main.rs:13:9
[INFO] [stderr]    |
[INFO] [stderr] 13 | /         if ids.contains_key(&c) {
[INFO] [stderr] 14 | |             let mut count = *ids.get(&c).unwrap();
[INFO] [stderr] 15 | |             count += 1;
[INFO] [stderr] 16 | |             ids.insert(c, count);
[INFO] [stderr] 17 | |         } else {
[INFO] [stderr] 18 | |             ids.insert(c, 1);
[INFO] [stderr] 19 | |         }
[INFO] [stderr]    | |_________^ help: consider using: `ids.entry(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/day_2/bin/main.rs:14:30
[INFO] [stderr]    |
[INFO] [stderr] 14 |             let mut count = *ids.get(&c).unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^ help: try this: `&ids[&c]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day_2/bin/main.rs:38:21
[INFO] [stderr]    |
[INFO] [stderr] 38 | fn part_one(values: &Vec<&str>) {
[INFO] [stderr]    |                     ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day_2/bin/main.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 | fn part_two(values: &Vec<&str>) {
[INFO] [stderr]    |                     ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_2/bin/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     return (min(twos as u64, 1), min(threes as u64, 1));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(min(twos as u64, 1), min(threes as u64, 1))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_2/bin/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return differences;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `differences`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/day_2/bin/main.rs:13:9
[INFO] [stderr]    |
[INFO] [stderr] 13 | /         if ids.contains_key(&c) {
[INFO] [stderr] 14 | |             let mut count = *ids.get(&c).unwrap();
[INFO] [stderr] 15 | |             count += 1;
[INFO] [stderr] 16 | |             ids.insert(c, count);
[INFO] [stderr] 17 | |         } else {
[INFO] [stderr] 18 | |             ids.insert(c, 1);
[INFO] [stderr] 19 | |         }
[INFO] [stderr]    | |_________^ help: consider using: `ids.entry(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/day_2/bin/main.rs:14:30
[INFO] [stderr]    |
[INFO] [stderr] 14 |             let mut count = *ids.get(&c).unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^ help: try this: `&ids[&c]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day_2/bin/main.rs:38:21
[INFO] [stderr]    |
[INFO] [stderr] 38 | fn part_one(values: &Vec<&str>) {
[INFO] [stderr]    |                     ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day_2/bin/main.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 | fn part_two(values: &Vec<&str>) {
[INFO] [stderr]    |                     ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.37s
[INFO] running `"docker" "inspect" "c7b4246182b47f884a153acf11227ba9b22a9b8b5f840960f1cbcb2cf7c6dcfe"`
[INFO] running `"docker" "rm" "-f" "c7b4246182b47f884a153acf11227ba9b22a9b8b5f840960f1cbcb2cf7c6dcfe"`
[INFO] [stdout] c7b4246182b47f884a153acf11227ba9b22a9b8b5f840960f1cbcb2cf7c6dcfe