[INFO] updating cached repository gluaxspeed/r2wc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gluaxspeed/r2wc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gluaxspeed/r2wc" "work/ex/clippy-test-run/sources/stable/gh/gluaxspeed/r2wc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gluaxspeed/r2wc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gluaxspeed/r2wc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gluaxspeed/r2wc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gluaxspeed/r2wc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cdc59383aab43b4c6439f6b4eae38cd2208c082f [INFO] sha for GitHub repo gluaxspeed/r2wc: cdc59383aab43b4c6439f6b4eae38cd2208c082f [INFO] validating manifest of gluaxspeed/r2wc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gluaxspeed/r2wc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gluaxspeed/r2wc [INFO] finished frobbing gluaxspeed/r2wc [INFO] frobbed toml for gluaxspeed/r2wc written to work/ex/clippy-test-run/sources/stable/gh/gluaxspeed/r2wc/Cargo.toml [INFO] started frobbing gluaxspeed/r2wc [INFO] finished frobbing gluaxspeed/r2wc [INFO] frobbed toml for gluaxspeed/r2wc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gluaxspeed/r2wc/Cargo.toml [INFO] crate gluaxspeed/r2wc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gluaxspeed/r2wc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gluaxspeed/r2wc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afff22f15218e4e1d63214ee3b31863b0b7093a3fe27648aab77475f5c2ab2cf [INFO] running `"docker" "start" "-a" "afff22f15218e4e1d63214ee3b31863b0b7093a3fe27648aab77475f5c2ab2cf"` [INFO] [stderr] Compiling ncurses v5.94.0 [INFO] [stderr] Checking stopwatch v0.0.7 [INFO] [stderr] Checking r2wc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | who: who, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `who` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | taken: taken, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `taken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | who: who, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `who` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | taken: taken, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `taken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | who: who, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `who` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | taken: taken, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `taken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/peer.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | who: who, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `who` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | taken: taken, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `taken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | msg_size: msg_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return Peer { [INFO] [stderr] 41 | | stream: stream, [INFO] [stderr] 42 | | who: who, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | Peer { [INFO] [stderr] 41 | stream: stream, [INFO] [stderr] 42 | who: who, [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return &self.stream; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return &self.who; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.who` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return server; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return stream; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return self.peer.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peer.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / return Connection { [INFO] [stderr] 98 | | msg_size: msg_size, [INFO] [stderr] 99 | | taken: taken, [INFO] [stderr] 100 | | peer: None, [INFO] [stderr] 101 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 97 | Connection { [INFO] [stderr] 98 | msg_size: msg_size, [INFO] [stderr] 99 | taken: taken, [INFO] [stderr] 100 | peer: None, [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return ( [INFO] [stderr] 113 | | Connection { [INFO] [stderr] 114 | | msg_size: msg_size, [INFO] [stderr] 115 | | taken: Some(false), [INFO] [stderr] ... | [INFO] [stderr] 118 | | create_server(), [INFO] [stderr] 119 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | ( [INFO] [stderr] 113 | Connection { [INFO] [stderr] 114 | msg_size: msg_size, [INFO] [stderr] 115 | taken: Some(false), [INFO] [stderr] 116 | peer: None, [INFO] [stderr] 117 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / return Connection { [INFO] [stderr] 131 | | msg_size: msg_size, [INFO] [stderr] 132 | | taken: None, [INFO] [stderr] 133 | | peer: Some(Peer::new(connect_server(), String::from("Server"))), [INFO] [stderr] 134 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 130 | Connection { [INFO] [stderr] 131 | msg_size: msg_size, [INFO] [stderr] 132 | taken: None, [INFO] [stderr] 133 | peer: Some(Peer::new(connect_server(), String::from("Server"))), [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:190:21 [INFO] [stderr] | [INFO] [stderr] 190 | return (true, Peer::get_client(server)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(true, Peer::get_client(server))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | return (false, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | None => return (false, None), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | return (format!("Message sent {:?}", buff), sent_time); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(format!("Message sent {:?}", buff), sent_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | None => return (String::from("Empty"), Stopwatch::start_new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(String::from("Empty"), Stopwatch::start_new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:242:25 [INFO] [stderr] | [INFO] [stderr] 242 | return msg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | return String::from("Blocked") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Blocked")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:252:25 [INFO] [stderr] | [INFO] [stderr] 252 | return String::from("Disconnected"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Disconnected")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:256:21 [INFO] [stderr] | [INFO] [stderr] 256 | None => return String::from("Empty"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Empty")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return Peer { [INFO] [stderr] 41 | | stream: stream, [INFO] [stderr] 42 | | who: who, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | Peer { [INFO] [stderr] 41 | stream: stream, [INFO] [stderr] 42 | who: who, [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return &self.stream; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return &self.who; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.who` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return server; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return stream; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return self.peer.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peer.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / return Connection { [INFO] [stderr] 98 | | msg_size: msg_size, [INFO] [stderr] 99 | | taken: taken, [INFO] [stderr] 100 | | peer: None, [INFO] [stderr] 101 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 97 | Connection { [INFO] [stderr] 98 | msg_size: msg_size, [INFO] [stderr] 99 | taken: taken, [INFO] [stderr] 100 | peer: None, [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return ( [INFO] [stderr] 113 | | Connection { [INFO] [stderr] 114 | | msg_size: msg_size, [INFO] [stderr] 115 | | taken: Some(false), [INFO] [stderr] ... | [INFO] [stderr] 118 | | create_server(), [INFO] [stderr] 119 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | ( [INFO] [stderr] 113 | Connection { [INFO] [stderr] 114 | msg_size: msg_size, [INFO] [stderr] 115 | taken: Some(false), [INFO] [stderr] 116 | peer: None, [INFO] [stderr] 117 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / return Connection { [INFO] [stderr] 131 | | msg_size: msg_size, [INFO] [stderr] 132 | | taken: None, [INFO] [stderr] 133 | | peer: Some(Peer::new(connect_server(), String::from("Server"))), [INFO] [stderr] 134 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 130 | Connection { [INFO] [stderr] 131 | msg_size: msg_size, [INFO] [stderr] 132 | taken: None, [INFO] [stderr] 133 | peer: Some(Peer::new(connect_server(), String::from("Server"))), [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:190:21 [INFO] [stderr] | [INFO] [stderr] 190 | return (true, Peer::get_client(server)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(true, Peer::get_client(server))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | return (false, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | None => return (false, None), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | return (format!("Message sent {:?}", buff), sent_time); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(format!("Message sent {:?}", buff), sent_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | None => return (String::from("Empty"), Stopwatch::start_new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(String::from("Empty"), Stopwatch::start_new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:242:25 [INFO] [stderr] | [INFO] [stderr] 242 | return msg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | return String::from("Blocked") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Blocked")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:252:25 [INFO] [stderr] | [INFO] [stderr] 252 | return String::from("Disconnected"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Disconnected")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:256:21 [INFO] [stderr] | [INFO] [stderr] 256 | None => return String::from("Empty"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Empty")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return Peer { [INFO] [stderr] 41 | | stream: stream, [INFO] [stderr] 42 | | who: who, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | Peer { [INFO] [stderr] 41 | stream: stream, [INFO] [stderr] 42 | who: who, [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return &self.stream; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return &self.who; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.who` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return server; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return stream; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return self.peer.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peer.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / return Connection { [INFO] [stderr] 98 | | msg_size: msg_size, [INFO] [stderr] 99 | | taken: taken, [INFO] [stderr] 100 | | peer: None, [INFO] [stderr] 101 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 97 | Connection { [INFO] [stderr] 98 | msg_size: msg_size, [INFO] [stderr] 99 | taken: taken, [INFO] [stderr] 100 | peer: None, [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return ( [INFO] [stderr] 113 | | Connection { [INFO] [stderr] 114 | | msg_size: msg_size, [INFO] [stderr] 115 | | taken: Some(false), [INFO] [stderr] ... | [INFO] [stderr] 118 | | create_server(), [INFO] [stderr] 119 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | ( [INFO] [stderr] 113 | Connection { [INFO] [stderr] 114 | msg_size: msg_size, [INFO] [stderr] 115 | taken: Some(false), [INFO] [stderr] 116 | peer: None, [INFO] [stderr] 117 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / return Connection { [INFO] [stderr] 131 | | msg_size: msg_size, [INFO] [stderr] 132 | | taken: None, [INFO] [stderr] 133 | | peer: Some(Peer::new(connect_server(), String::from("Server"))), [INFO] [stderr] 134 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 130 | Connection { [INFO] [stderr] 131 | msg_size: msg_size, [INFO] [stderr] 132 | taken: None, [INFO] [stderr] 133 | peer: Some(Peer::new(connect_server(), String::from("Server"))), [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:190:21 [INFO] [stderr] | [INFO] [stderr] 190 | return (true, Peer::get_client(server)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(true, Peer::get_client(server))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | return (false, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | None => return (false, None), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | return (format!("Message sent {:?}", buff), sent_time); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(format!("Message sent {:?}", buff), sent_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | None => return (String::from("Empty"), Stopwatch::start_new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(String::from("Empty"), Stopwatch::start_new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:242:25 [INFO] [stderr] | [INFO] [stderr] 242 | return msg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | return String::from("Blocked") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Blocked")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:252:25 [INFO] [stderr] | [INFO] [stderr] 252 | return String::from("Disconnected"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Disconnected")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:256:21 [INFO] [stderr] | [INFO] [stderr] 256 | None => return String::from("Empty"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Empty")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_client` [INFO] [stderr] --> src/connection/peer.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn get_client(server: &TcpListener) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `set_port` [INFO] [stderr] --> src/connection.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn set_port() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `create_server` [INFO] [stderr] --> src/connection.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn create_server() -> TcpListener { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_peer` [INFO] [stderr] --> src/connection.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn get_peer(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_connection` [INFO] [stderr] --> src/connection.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn new_connection(msg_size: usize, taken: Option) -> Connection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_server_connection` [INFO] [stderr] --> src/connection.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn new_server_connection(msg_size: usize) -> (Connection, TcpListener) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `await_client` [INFO] [stderr] --> src/connection.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn await_client(&mut self, server: &TcpListener) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `await_client_timeout` [INFO] [stderr] --> src/connection.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | pub fn await_client_timeout(&mut self, server: &TcpListener) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reject_other_clients` [INFO] [stderr] --> src/connection.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | pub fn reject_other_clients(&self, server: &TcpListener) -> (bool, Option) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:67:29 [INFO] [stderr] | [INFO] [stderr] 67 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:67:51 [INFO] [stderr] | [INFO] [stderr] 67 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/connection.rs:271:23 [INFO] [stderr] | [INFO] [stderr] 271 | msg_size: self.msg_size.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.msg_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/connection.rs:272:20 [INFO] [stderr] | [INFO] [stderr] 272 | taken: self.taken.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.taken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/client.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / loop { [INFO] [stderr] 82 | | match chat_iter.next() { [INFO] [stderr] 83 | | Some((msg, client)) => { [INFO] [stderr] 84 | | mv(ln, 0); [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ help: try: `while let Some((msg, client)) = chat_iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_client` [INFO] [stderr] --> src/connection/peer.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn get_client(server: &TcpListener) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `set_port` [INFO] [stderr] --> src/connection.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn set_port() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `create_server` [INFO] [stderr] --> src/connection.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn create_server() -> TcpListener { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_peer` [INFO] [stderr] --> src/connection.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn get_peer(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_connection` [INFO] [stderr] --> src/connection.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn new_connection(msg_size: usize, taken: Option) -> Connection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_server_connection` [INFO] [stderr] --> src/connection.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn new_server_connection(msg_size: usize) -> (Connection, TcpListener) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `await_client` [INFO] [stderr] --> src/connection.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn await_client(&mut self, server: &TcpListener) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `await_client_timeout` [INFO] [stderr] --> src/connection.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | pub fn await_client_timeout(&mut self, server: &TcpListener) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reject_other_clients` [INFO] [stderr] --> src/connection.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | pub fn reject_other_clients(&self, server: &TcpListener) -> (bool, Option) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:67:29 [INFO] [stderr] | [INFO] [stderr] 67 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:67:51 [INFO] [stderr] | [INFO] [stderr] 67 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/connection.rs:271:23 [INFO] [stderr] | [INFO] [stderr] 271 | msg_size: self.msg_size.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.msg_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/connection.rs:272:20 [INFO] [stderr] | [INFO] [stderr] 272 | taken: self.taken.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.taken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/client.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / loop { [INFO] [stderr] 82 | | match chat_iter.next() { [INFO] [stderr] 83 | | Some((msg, client)) => { [INFO] [stderr] 84 | | mv(ln, 0); [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ help: try: `while let Some((msg, client)) = chat_iter.next() { .. }` [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return Peer { [INFO] [stderr] 41 | | stream: stream, [INFO] [stderr] 42 | | who: who, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | Peer { [INFO] [stderr] 41 | stream: stream, [INFO] [stderr] 42 | who: who, [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return &self.stream; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection/peer.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return &self.who; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.who` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return server; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return stream; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return self.peer.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peer.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / return Connection { [INFO] [stderr] 98 | | msg_size: msg_size, [INFO] [stderr] 99 | | taken: taken, [INFO] [stderr] 100 | | peer: None, [INFO] [stderr] 101 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 97 | Connection { [INFO] [stderr] 98 | msg_size: msg_size, [INFO] [stderr] 99 | taken: taken, [INFO] [stderr] 100 | peer: None, [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return ( [INFO] [stderr] 113 | | Connection { [INFO] [stderr] 114 | | msg_size: msg_size, [INFO] [stderr] 115 | | taken: Some(false), [INFO] [stderr] ... | [INFO] [stderr] 118 | | create_server(), [INFO] [stderr] 119 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | ( [INFO] [stderr] 113 | Connection { [INFO] [stderr] 114 | msg_size: msg_size, [INFO] [stderr] 115 | taken: Some(false), [INFO] [stderr] 116 | peer: None, [INFO] [stderr] 117 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / return Connection { [INFO] [stderr] 131 | | msg_size: msg_size, [INFO] [stderr] 132 | | taken: None, [INFO] [stderr] 133 | | peer: Some(Peer::new(connect_server(), String::from("Server"))), [INFO] [stderr] 134 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 130 | Connection { [INFO] [stderr] 131 | msg_size: msg_size, [INFO] [stderr] 132 | taken: None, [INFO] [stderr] 133 | peer: Some(Peer::new(connect_server(), String::from("Server"))), [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:190:21 [INFO] [stderr] | [INFO] [stderr] 190 | return (true, Peer::get_client(server)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(true, Peer::get_client(server))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | return (false, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | None => return (false, None), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | return (format!("Message sent {:?}", buff), sent_time); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(format!("Message sent {:?}", buff), sent_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | None => return (String::from("Empty"), Stopwatch::start_new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(String::from("Empty"), Stopwatch::start_new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:242:25 [INFO] [stderr] | [INFO] [stderr] 242 | return msg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | return String::from("Blocked") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Blocked")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:252:25 [INFO] [stderr] | [INFO] [stderr] 252 | return String::from("Disconnected"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Disconnected")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connection.rs:256:21 [INFO] [stderr] | [INFO] [stderr] 256 | None => return String::from("Empty"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Empty")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/connection/peer.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn new(stream: TcpStream, who: String) -> Peer { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `set_server_port` [INFO] [stderr] --> src/connection.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn set_server_port() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `connect_server` [INFO] [stderr] --> src/connection.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn connect_server() -> TcpStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_connection` [INFO] [stderr] --> src/connection.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn new_connection(msg_size: usize, taken: Option) -> Connection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_client_connection` [INFO] [stderr] --> src/connection.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn new_client_connection(msg_size: usize) -> Connection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `await_client` [INFO] [stderr] --> src/connection.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn await_client(&mut self, server: &TcpListener) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:67:29 [INFO] [stderr] | [INFO] [stderr] 67 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:67:51 [INFO] [stderr] | [INFO] [stderr] 67 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/connection.rs:271:23 [INFO] [stderr] | [INFO] [stderr] 271 | msg_size: self.msg_size.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.msg_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/connection.rs:272:20 [INFO] [stderr] | [INFO] [stderr] 272 | taken: self.taken.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.taken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/server.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / loop { [INFO] [stderr] 81 | | match chat_iter.next() { [INFO] [stderr] 82 | | Some((msg, client)) => { [INFO] [stderr] 83 | | mv(ln, 0); [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ help: try: `while let Some((msg, client)) = chat_iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | / match peer { [INFO] [stderr] 133 | | Some(p) => { [INFO] [stderr] 134 | | chat.push((format!("Client {} connected", p.who()), false)); [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | None => (), [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let Some(p) = peer { [INFO] [stderr] 133 | chat.push((format!("Client {} connected", p.who()), false)); [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/server.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | &line.pop(); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `line.pop();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/server.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | &line.push(char::from_u32(c as u32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line.push(char::from_u32(c as u32).unwrap());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/connection/peer.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn new(stream: TcpStream, who: String) -> Peer { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `set_server_port` [INFO] [stderr] --> src/connection.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn set_server_port() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `connect_server` [INFO] [stderr] --> src/connection.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn connect_server() -> TcpStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_connection` [INFO] [stderr] --> src/connection.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn new_connection(msg_size: usize, taken: Option) -> Connection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_client_connection` [INFO] [stderr] --> src/connection.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn new_client_connection(msg_size: usize) -> Connection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `await_client` [INFO] [stderr] --> src/connection.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn await_client(&mut self, server: &TcpListener) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:67:29 [INFO] [stderr] | [INFO] [stderr] 67 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/connection.rs:67:51 [INFO] [stderr] | [INFO] [stderr] 67 | return format!("{}:{}", args.get(1).unwrap(), args.get(2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/connection.rs:271:23 [INFO] [stderr] | [INFO] [stderr] 271 | msg_size: self.msg_size.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.msg_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/connection.rs:272:20 [INFO] [stderr] | [INFO] [stderr] 272 | taken: self.taken.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.taken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/server.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / loop { [INFO] [stderr] 81 | | match chat_iter.next() { [INFO] [stderr] 82 | | Some((msg, client)) => { [INFO] [stderr] 83 | | mv(ln, 0); [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ help: try: `while let Some((msg, client)) = chat_iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | / match peer { [INFO] [stderr] 133 | | Some(p) => { [INFO] [stderr] 134 | | chat.push((format!("Client {} connected", p.who()), false)); [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | None => (), [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let Some(p) = peer { [INFO] [stderr] 133 | chat.push((format!("Client {} connected", p.who()), false)); [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/server.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | &line.pop(); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `line.pop();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/server.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | &line.push(char::from_u32(c as u32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line.push(char::from_u32(c as u32).unwrap());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.01s [INFO] running `"docker" "inspect" "afff22f15218e4e1d63214ee3b31863b0b7093a3fe27648aab77475f5c2ab2cf"` [INFO] running `"docker" "rm" "-f" "afff22f15218e4e1d63214ee3b31863b0b7093a3fe27648aab77475f5c2ab2cf"` [INFO] [stdout] afff22f15218e4e1d63214ee3b31863b0b7093a3fe27648aab77475f5c2ab2cf