[INFO] updating cached repository glasses-n-contacts/cmdtodo-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/glasses-n-contacts/cmdtodo-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/glasses-n-contacts/cmdtodo-rs" "work/ex/clippy-test-run/sources/stable/gh/glasses-n-contacts/cmdtodo-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/glasses-n-contacts/cmdtodo-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/glasses-n-contacts/cmdtodo-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/glasses-n-contacts/cmdtodo-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/glasses-n-contacts/cmdtodo-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a17d016224a651d910cb875a1608bc1582b98eea [INFO] sha for GitHub repo glasses-n-contacts/cmdtodo-rs: a17d016224a651d910cb875a1608bc1582b98eea [INFO] validating manifest of glasses-n-contacts/cmdtodo-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of glasses-n-contacts/cmdtodo-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing glasses-n-contacts/cmdtodo-rs [INFO] finished frobbing glasses-n-contacts/cmdtodo-rs [INFO] frobbed toml for glasses-n-contacts/cmdtodo-rs written to work/ex/clippy-test-run/sources/stable/gh/glasses-n-contacts/cmdtodo-rs/Cargo.toml [INFO] started frobbing glasses-n-contacts/cmdtodo-rs [INFO] finished frobbing glasses-n-contacts/cmdtodo-rs [INFO] frobbed toml for glasses-n-contacts/cmdtodo-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/glasses-n-contacts/cmdtodo-rs/Cargo.toml [INFO] crate glasses-n-contacts/cmdtodo-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting glasses-n-contacts/cmdtodo-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/glasses-n-contacts/cmdtodo-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6a080763f94f2d7aae03f3d55478893239ed55e9fcb04cb071d4f1c84345ed6 [INFO] running `"docker" "start" "-a" "f6a080763f94f2d7aae03f3d55478893239ed55e9fcb04cb071d4f1c84345ed6"` [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking serde_json v1.0.21 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking todo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Client` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Client { [INFO] [stderr] 42 | | Client { [INFO] [stderr] 43 | | login_state: LogInState::new(), [INFO] [stderr] 44 | | client: reqwest::Client::new(), [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | impl Default for Client { [INFO] [stderr] 41 | fn default() -> Self { [INFO] [stderr] 42 | Self::new() [INFO] [stderr] 43 | } [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Client` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Client { [INFO] [stderr] 42 | | Client { [INFO] [stderr] 43 | | login_state: LogInState::new(), [INFO] [stderr] 44 | | client: reqwest::Client::new(), [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | impl Default for Client { [INFO] [stderr] 41 | fn default() -> Self { [INFO] [stderr] 42 | Self::new() [INFO] [stderr] 43 | } [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.08s [INFO] running `"docker" "inspect" "f6a080763f94f2d7aae03f3d55478893239ed55e9fcb04cb071d4f1c84345ed6"` [INFO] running `"docker" "rm" "-f" "f6a080763f94f2d7aae03f3d55478893239ed55e9fcb04cb071d4f1c84345ed6"` [INFO] [stdout] f6a080763f94f2d7aae03f3d55478893239ed55e9fcb04cb071d4f1c84345ed6