[INFO] updating cached repository gilbertw1/metaswitch-server
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/gilbertw1/metaswitch-server
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/gilbertw1/metaswitch-server" "work/ex/clippy-test-run/sources/stable/gh/gilbertw1/metaswitch-server"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gilbertw1/metaswitch-server'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/gilbertw1/metaswitch-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gilbertw1/metaswitch-server"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gilbertw1/metaswitch-server'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2bd0ad32fbc629e64fb565fca425491eb6ab6dfe
[INFO] sha for GitHub repo gilbertw1/metaswitch-server: 2bd0ad32fbc629e64fb565fca425491eb6ab6dfe
[INFO] validating manifest of gilbertw1/metaswitch-server on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gilbertw1/metaswitch-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gilbertw1/metaswitch-server
[INFO] finished frobbing gilbertw1/metaswitch-server
[INFO] frobbed toml for gilbertw1/metaswitch-server written to work/ex/clippy-test-run/sources/stable/gh/gilbertw1/metaswitch-server/Cargo.toml
[INFO] started frobbing gilbertw1/metaswitch-server
[INFO] finished frobbing gilbertw1/metaswitch-server
[INFO] frobbed toml for gilbertw1/metaswitch-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gilbertw1/metaswitch-server/Cargo.toml
[INFO] crate gilbertw1/metaswitch-server has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gilbertw1/metaswitch-server against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gilbertw1/metaswitch-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6f011ba39c1b8f2e189fd2ee77752fb35acb948d2ec5fcb0e1032cd4817d5fdf
[INFO] running `"docker" "start" "-a" "6f011ba39c1b8f2e189fd2ee77752fb35acb948d2ec5fcb0e1032cd4817d5fdf"`
[INFO] [stderr]    Compiling cc v1.0.19
[INFO] [stderr]    Compiling serde v1.0.72
[INFO] [stderr]     Checking strsim v0.8.0
[INFO] [stderr]     Checking tokio-io v0.1.7
[INFO] [stderr]     Checking http v0.1.10
[INFO] [stderr]    Compiling quote v0.6.7
[INFO] [stderr]     Checking tokio-threadpool v0.1.5
[INFO] [stderr]    Compiling mime_guess v2.0.0-alpha.6
[INFO] [stderr]    Compiling syn v0.14.9
[INFO] [stderr]     Checking tokio-codec v0.1.0
[INFO] [stderr]     Checking tokio-reactor v0.1.3
[INFO] [stderr]     Checking tokio-fs v0.1.3
[INFO] [stderr]     Checking tokio-udp v0.1.1
[INFO] [stderr]     Checking tokio-tcp v0.1.1
[INFO] [stderr]    Compiling openssl-sys v0.9.35
[INFO] [stderr]     Checking tokio v0.1.7
[INFO] [stderr]    Compiling openssl v0.9.24
[INFO] [stderr]     Checking h2 v0.1.12
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr]    Compiling serde_derive v1.0.72
[INFO] [stderr]     Checking hyper v0.11.27
[INFO] [stderr]     Checking native-tls v0.1.5
[INFO] [stderr]     Checking serde_json v1.0.26
[INFO] [stderr]     Checking serde_urlencoded v0.5.3
[INFO] [stderr]     Checking hyper v0.12.8
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking hyper-tls v0.1.4
[INFO] [stderr]     Checking reqwest v0.8.8
[INFO] [stderr]     Checking metaswitch-server v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/metacritic.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     client.get(&url).send().ok().map(|mut resp| parse_metacritic_games(&resp.text().unwrap_or("".to_owned()))).unwrap_or(Vec::new())
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `client.get(&url).send().ok().map(|mut resp| parse_metacritic_games(&resp.text().unwrap_or("".to_owned()))).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/metacritic.rs:46:85
[INFO] [stderr]    |
[INFO] [stderr] 46 |     client.get(&url).send().ok().map(|mut resp| parse_metacritic_games(&resp.text().unwrap_or("".to_owned()))).unwrap_or(Vec::new())
[INFO] [stderr]    |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/metacritic.rs:110:13
[INFO] [stderr]     |
[INFO] [stderr] 110 |             found_game.map(|g| g.clone())
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `found_game.cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/metacritic.rs:139:27
[INFO] [stderr]     |
[INFO] [stderr] 139 |     if game.name.contains(":") {
[INFO] [stderr]     |                           ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/metacritic.rs:140:30
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let truncated_name = game.name.split(':').collect::<Vec<&str>>()[0].clone();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let truncated_name = &(*game.name.split(':').collect::<Vec<&str>>()[0]).clone();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let truncated_name = &str::clone(game.name.split(':').collect::<Vec<&str>>()[0]);
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `metaswitch-server`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/metacritic.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     client.get(&url).send().ok().map(|mut resp| parse_metacritic_games(&resp.text().unwrap_or("".to_owned()))).unwrap_or(Vec::new())
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `client.get(&url).send().ok().map(|mut resp| parse_metacritic_games(&resp.text().unwrap_or("".to_owned()))).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/metacritic.rs:46:85
[INFO] [stderr]    |
[INFO] [stderr] 46 |     client.get(&url).send().ok().map(|mut resp| parse_metacritic_games(&resp.text().unwrap_or("".to_owned()))).unwrap_or(Vec::new())
[INFO] [stderr]    |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/metacritic.rs:110:13
[INFO] [stderr]     |
[INFO] [stderr] 110 |             found_game.map(|g| g.clone())
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `found_game.cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/metacritic.rs:139:27
[INFO] [stderr]     |
[INFO] [stderr] 139 |     if game.name.contains(":") {
[INFO] [stderr]     |                           ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/metacritic.rs:140:30
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let truncated_name = game.name.split(':').collect::<Vec<&str>>()[0].clone();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let truncated_name = &(*game.name.split(':').collect::<Vec<&str>>()[0]).clone();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let truncated_name = &str::clone(game.name.split(':').collect::<Vec<&str>>()[0]);
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `metaswitch-server`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "6f011ba39c1b8f2e189fd2ee77752fb35acb948d2ec5fcb0e1032cd4817d5fdf"`
[INFO] running `"docker" "rm" "-f" "6f011ba39c1b8f2e189fd2ee77752fb35acb948d2ec5fcb0e1032cd4817d5fdf"`
[INFO] [stdout] 6f011ba39c1b8f2e189fd2ee77752fb35acb948d2ec5fcb0e1032cd4817d5fdf