[INFO] updating cached repository gilbertw1/adventure-rust-future-tokio-code [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gilbertw1/adventure-rust-future-tokio-code [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gilbertw1/adventure-rust-future-tokio-code" "work/ex/clippy-test-run/sources/stable/gh/gilbertw1/adventure-rust-future-tokio-code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gilbertw1/adventure-rust-future-tokio-code'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gilbertw1/adventure-rust-future-tokio-code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gilbertw1/adventure-rust-future-tokio-code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gilbertw1/adventure-rust-future-tokio-code'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3231c9284db3c57f3f3cfb42ba7b4b6147b723ec [INFO] sha for GitHub repo gilbertw1/adventure-rust-future-tokio-code: 3231c9284db3c57f3f3cfb42ba7b4b6147b723ec [INFO] validating manifest of gilbertw1/adventure-rust-future-tokio-code on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gilbertw1/adventure-rust-future-tokio-code on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gilbertw1/adventure-rust-future-tokio-code [INFO] finished frobbing gilbertw1/adventure-rust-future-tokio-code [INFO] frobbed toml for gilbertw1/adventure-rust-future-tokio-code written to work/ex/clippy-test-run/sources/stable/gh/gilbertw1/adventure-rust-future-tokio-code/Cargo.toml [INFO] started frobbing gilbertw1/adventure-rust-future-tokio-code [INFO] finished frobbing gilbertw1/adventure-rust-future-tokio-code [INFO] frobbed toml for gilbertw1/adventure-rust-future-tokio-code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gilbertw1/adventure-rust-future-tokio-code/Cargo.toml [INFO] crate gilbertw1/adventure-rust-future-tokio-code has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting gilbertw1/adventure-rust-future-tokio-code against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gilbertw1/adventure-rust-future-tokio-code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dfaa0d17ea44ce32e82680fda932bb17725eacf05feda1ce16a0ef6b2974a61a [INFO] running `"docker" "start" "-a" "dfaa0d17ea44ce32e82680fda932bb17725eacf05feda1ce16a0ef6b2974a61a"` [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking http v0.1.10 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking domain v0.2.4 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking hyper v0.12.9 [INFO] [stderr] Checking adventure-rust-future-and-tokio-code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:111:80 [INFO] [stderr] | [INFO] [stderr] 111 | let result = self.request_sender.unbounded_send(ReverseLookupRequest { ip: ip, sender: resp_tx }); [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:111:80 [INFO] [stderr] | [INFO] [stderr] 111 | let result = self.request_sender.unbounded_send(ReverseLookupRequest { ip: ip, sender: resp_tx }); [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return SimpleDnsLookupHandle { resolv: rx.recv().unwrap() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SimpleDnsLookupHandle { resolv: rx.recv().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return SimpleDnsLookupHandle { resolv: rx.recv().unwrap() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SimpleDnsLookupHandle { resolv: rx.recv().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | let result = self.request_sender.unbounded_send(ReverseLookupRequest { ip: ip, sender: resp_tx }); [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | request.sender.send(response); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | tx.send(resolv); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | let result = self.request_sender.unbounded_send(ReverseLookupRequest { ip: ip, sender: resp_tx }); [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | request.sender.send(response); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | tx.send(resolv); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.93s [INFO] running `"docker" "inspect" "dfaa0d17ea44ce32e82680fda932bb17725eacf05feda1ce16a0ef6b2974a61a"` [INFO] running `"docker" "rm" "-f" "dfaa0d17ea44ce32e82680fda932bb17725eacf05feda1ce16a0ef6b2974a61a"` [INFO] [stdout] dfaa0d17ea44ce32e82680fda932bb17725eacf05feda1ce16a0ef6b2974a61a