[INFO] updating cached repository ghotiphud/pg_proxy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ghotiphud/pg_proxy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ghotiphud/pg_proxy" "work/ex/clippy-test-run/sources/stable/gh/ghotiphud/pg_proxy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ghotiphud/pg_proxy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ghotiphud/pg_proxy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ghotiphud/pg_proxy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ghotiphud/pg_proxy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0489f84ddfedbce215375d27a2b1ae8fa30e262c [INFO] sha for GitHub repo ghotiphud/pg_proxy: 0489f84ddfedbce215375d27a2b1ae8fa30e262c [INFO] validating manifest of ghotiphud/pg_proxy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ghotiphud/pg_proxy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ghotiphud/pg_proxy [INFO] finished frobbing ghotiphud/pg_proxy [INFO] frobbed toml for ghotiphud/pg_proxy written to work/ex/clippy-test-run/sources/stable/gh/ghotiphud/pg_proxy/Cargo.toml [INFO] started frobbing ghotiphud/pg_proxy [INFO] finished frobbing ghotiphud/pg_proxy [INFO] frobbed toml for ghotiphud/pg_proxy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ghotiphud/pg_proxy/Cargo.toml [INFO] crate ghotiphud/pg_proxy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ghotiphud/pg_proxy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ghotiphud/pg_proxy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c001d5326d860d862760a4373c8f4abc385686151c208b62952bf6c6e9d53e7 [INFO] running `"docker" "start" "-a" "4c001d5326d860d862760a4373c8f4abc385686151c208b62952bf6c6e9d53e7"` [INFO] [stderr] Checking md5 v0.2.1 [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking futures v0.1.6 [INFO] [stderr] Checking nix v0.7.0 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking dotenv v0.8.0 [INFO] [stderr] Checking postgres-protocol v0.1.1 [INFO] [stderr] Checking error-chain v0.7.1 [INFO] [stderr] Checking mio v0.6.1 [INFO] [stderr] Checking tokio-core v0.1.1 [INFO] [stderr] Checking pg_proxy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pg_parse.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | msg_type: msg_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pg_parse.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | body: body [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pg_parse.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | msg_type: msg_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pg_parse.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | body: body [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:71:40 [INFO] [stderr] | [INFO] [stderr] 71 | let bind_addr = env::args().nth(1).unwrap_or("127.0.0.1:5433".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:5433".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | let postgres_addr = env::args().nth(2).unwrap_or("127.0.0.1:5432".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:5432".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | / match msg_pkt.msg_type { [INFO] [stderr] 198 | | MessageType::Query => { [INFO] [stderr] 199 | | // let msg = msg_pkt.to_message().ok(); [INFO] [stderr] 200 | | [INFO] [stderr] ... | [INFO] [stderr] 206 | | _ => (), [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 197 | if let MessageType::Query = msg_pkt.msg_type { [INFO] [stderr] 198 | // let msg = msg_pkt.to_message().ok(); [INFO] [stderr] 199 | [INFO] [stderr] 200 | let query = std::ffi::CStr::from_bytes_with_nul(&msg_pkt.body[5..]).unwrap() [INFO] [stderr] 201 | .to_str().unwrap(); [INFO] [stderr] 202 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:71:40 [INFO] [stderr] | [INFO] [stderr] 71 | let bind_addr = env::args().nth(1).unwrap_or("127.0.0.1:5433".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:5433".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | let postgres_addr = env::args().nth(2).unwrap_or("127.0.0.1:5432".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:5432".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | / match msg_pkt.msg_type { [INFO] [stderr] 198 | | MessageType::Query => { [INFO] [stderr] 199 | | // let msg = msg_pkt.to_message().ok(); [INFO] [stderr] 200 | | [INFO] [stderr] ... | [INFO] [stderr] 206 | | _ => (), [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 197 | if let MessageType::Query = msg_pkt.msg_type { [INFO] [stderr] 198 | // let msg = msg_pkt.to_message().ok(); [INFO] [stderr] 199 | [INFO] [stderr] 200 | let query = std::ffi::CStr::from_bytes_with_nul(&msg_pkt.body[5..]).unwrap() [INFO] [stderr] 201 | .to_str().unwrap(); [INFO] [stderr] 202 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.13s [INFO] running `"docker" "inspect" "4c001d5326d860d862760a4373c8f4abc385686151c208b62952bf6c6e9d53e7"` [INFO] running `"docker" "rm" "-f" "4c001d5326d860d862760a4373c8f4abc385686151c208b62952bf6c6e9d53e7"` [INFO] [stdout] 4c001d5326d860d862760a4373c8f4abc385686151c208b62952bf6c6e9d53e7