[INFO] updating cached repository ghost-of-turek/arcana [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ghost-of-turek/arcana [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ghost-of-turek/arcana" "work/ex/clippy-test-run/sources/stable/gh/ghost-of-turek/arcana"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ghost-of-turek/arcana'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ghost-of-turek/arcana" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ghost-of-turek/arcana"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ghost-of-turek/arcana'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 05a01b2a33cb6dee8a72d3f74e0581c88a6d373f [INFO] sha for GitHub repo ghost-of-turek/arcana: 05a01b2a33cb6dee8a72d3f74e0581c88a6d373f [INFO] validating manifest of ghost-of-turek/arcana on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ghost-of-turek/arcana on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ghost-of-turek/arcana [INFO] finished frobbing ghost-of-turek/arcana [INFO] frobbed toml for ghost-of-turek/arcana written to work/ex/clippy-test-run/sources/stable/gh/ghost-of-turek/arcana/Cargo.toml [INFO] started frobbing ghost-of-turek/arcana [INFO] finished frobbing ghost-of-turek/arcana [INFO] frobbed toml for ghost-of-turek/arcana written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ghost-of-turek/arcana/Cargo.toml [INFO] crate ghost-of-turek/arcana has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ghost-of-turek/arcana against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ghost-of-turek/arcana:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e5e646be935add726ea44428cc5a0783c5926d5bfb4de87145d9d72a1ae954b [INFO] running `"docker" "start" "-a" "5e5e646be935add726ea44428cc5a0783c5926d5bfb4de87145d9d72a1ae954b"` [INFO] [stderr] Compiling libdbus-sys v0.1.3 [INFO] [stderr] Checking dbus v0.6.2 [INFO] [stderr] Checking arcana v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:12:40 [INFO] [stderr] | [INFO] [stderr] 12 | Ok(connection) => Daemon { connection: connection }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:12:40 [INFO] [stderr] | [INFO] [stderr] 12 | Ok(connection) => Daemon { connection: connection }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Daemon` [INFO] [stderr] --> src/lib.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Daemon { [INFO] [stderr] 11 | | let daemon = match Daemon::connect() { [INFO] [stderr] 12 | | Ok(connection) => Daemon { connection: connection }, [INFO] [stderr] 13 | | Err(_) => panic!("Failed to connect to DBus!"), [INFO] [stderr] ... | [INFO] [stderr] 17 | | daemon [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for Daemon { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | Err(_) => panic!("Failed to connect to DBus!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Daemon` [INFO] [stderr] --> src/lib.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Daemon { [INFO] [stderr] 11 | | let daemon = match Daemon::connect() { [INFO] [stderr] 12 | | Ok(connection) => Daemon { connection: connection }, [INFO] [stderr] 13 | | Err(_) => panic!("Failed to connect to DBus!"), [INFO] [stderr] ... | [INFO] [stderr] 17 | | daemon [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for Daemon { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | Err(_) => panic!("Failed to connect to DBus!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.56s [INFO] running `"docker" "inspect" "5e5e646be935add726ea44428cc5a0783c5926d5bfb4de87145d9d72a1ae954b"` [INFO] running `"docker" "rm" "-f" "5e5e646be935add726ea44428cc5a0783c5926d5bfb4de87145d9d72a1ae954b"` [INFO] [stdout] 5e5e646be935add726ea44428cc5a0783c5926d5bfb4de87145d9d72a1ae954b