[INFO] updating cached repository ghallberg/paperacers [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ghallberg/paperacers [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ghallberg/paperacers" "work/ex/clippy-test-run/sources/stable/gh/ghallberg/paperacers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ghallberg/paperacers'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ghallberg/paperacers" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ghallberg/paperacers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ghallberg/paperacers'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f7fa24c1e3d7f43e4121d20b4034f12d37a8596 [INFO] sha for GitHub repo ghallberg/paperacers: 9f7fa24c1e3d7f43e4121d20b4034f12d37a8596 [INFO] validating manifest of ghallberg/paperacers on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ghallberg/paperacers on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ghallberg/paperacers [INFO] finished frobbing ghallberg/paperacers [INFO] frobbed toml for ghallberg/paperacers written to work/ex/clippy-test-run/sources/stable/gh/ghallberg/paperacers/Cargo.toml [INFO] started frobbing ghallberg/paperacers [INFO] finished frobbing ghallberg/paperacers [INFO] frobbed toml for ghallberg/paperacers written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ghallberg/paperacers/Cargo.toml [INFO] crate ghallberg/paperacers has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ghallberg/paperacers against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ghallberg/paperacers:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbdd90b0fe0e079751a62fc9a0ef64b9c46d97bc4cda2f7b92f63e8d0b4dde5d [INFO] running `"docker" "start" "-a" "fbdd90b0fe0e079751a62fc9a0ef64b9c46d97bc4cda2f7b92f63e8d0b4dde5d"` [INFO] [stderr] Checking c_vec v1.3.2 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking paperacers v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/game.rs:63:55 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn update_state (&mut self, new_pos: GridPos) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:86:122 [INFO] [stderr] | [INFO] [stderr] 86 | fn draw_track(canvas: &sdl2::render::Canvas, track: Track, center_color: Color, track_color: Color) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:99:118 [INFO] [stderr] | [INFO] [stderr] 99 | fn draw_path(canvas: &sdl2::render::Canvas, path_iter: std::slice::Iter, color: Color) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:112:80 [INFO] [stderr] | [INFO] [stderr] 112 | fn draw_grid(canvas: &sdl2::render::Canvas, color: Color) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:134:148 [INFO] [stderr] | [INFO] [stderr] 134 | fn draw_next_move(mouse: &sdl2::mouse::MouseState, canvas: &sdl2::render::Canvas, game_state: &game::GameState, color: Color) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/game.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | fn is_on_starting_line(pos: GridPos) -> bool { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/game.rs:63:55 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn update_state (&mut self, new_pos: GridPos) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:86:122 [INFO] [stderr] | [INFO] [stderr] 86 | fn draw_track(canvas: &sdl2::render::Canvas, track: Track, center_color: Color, track_color: Color) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:99:118 [INFO] [stderr] | [INFO] [stderr] 99 | fn draw_path(canvas: &sdl2::render::Canvas, path_iter: std::slice::Iter, color: Color) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:112:80 [INFO] [stderr] | [INFO] [stderr] 112 | fn draw_grid(canvas: &sdl2::render::Canvas, color: Color) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:134:148 [INFO] [stderr] | [INFO] [stderr] 134 | fn draw_next_move(mouse: &sdl2::mouse::MouseState, canvas: &sdl2::render::Canvas, game_state: &game::GameState, color: Color) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GamePos` [INFO] [stderr] --> src/game.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub struct GamePos { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | fn is_adjacent(&self, other: GridPos) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | fn is_adjacent_or_equal(&self, other: GridPos) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/game.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | fn is_on_starting_line(pos: GridPos) -> bool { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / canvas.filled_polygon( [INFO] [stderr] 88 | | track.out_edge.xs.as_slice(), [INFO] [stderr] 89 | | track.out_edge.ys.as_slice(), [INFO] [stderr] 90 | | track_color [INFO] [stderr] 91 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / canvas.filled_polygon( [INFO] [stderr] 93 | | track.in_edge.xs.as_slice(), [INFO] [stderr] 94 | | track.in_edge.ys.as_slice(), [INFO] [stderr] 95 | | center_color [INFO] [stderr] 96 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | canvas.thick_line(start.x as i16, start.y as i16, end.x as i16, end.y as i16, 2, color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / match cur_pos { [INFO] [stderr] 107 | | Some(pos) => {canvas.filled_circle(pos.x as i16, pos.y as i16, 3, color);}, [INFO] [stderr] 108 | | None => {} [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(pos) = cur_pos {canvas.filled_circle(pos.x as i16, pos.y as i16, 3, color);}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | Some(pos) => {canvas.filled_circle(pos.x as i16, pos.y as i16, 3, color);}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | canvas.rectangle(x1, y1, x2, y2, color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | canvas.rectangle(x1, y1, x2, y2, color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match game_state.valid_move(mouse_pos) { [INFO] [stderr] 139 | | true => { [INFO] [stderr] 140 | | canvas.circle(mdp.x as i16, mdp.y as i16, 3, color); [INFO] [stderr] 141 | | }, [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 138 | if game_state.valid_move(mouse_pos) { [INFO] [stderr] 139 | canvas.circle(mdp.x as i16, mdp.y as i16, 3, color); [INFO] [stderr] 140 | } else { [INFO] [stderr] 141 | canvas.circle(mdp.x as i16, mdp.y as i16, 3, Color::RGB(150,0,0)); [INFO] [stderr] 142 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | canvas.circle(mdp.x as i16, mdp.y as i16, 3, color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | canvas.circle(mdp.x as i16, mdp.y as i16, 3, Color::RGB(150,0,0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:156:33 [INFO] [stderr] | [INFO] [stderr] 156 | fn to_drawing_point(game_point: &GridPos) -> Point { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `GridPos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GamePos` [INFO] [stderr] --> src/game.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub struct GamePos { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | fn is_adjacent(&self, other: GridPos) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | fn is_adjacent_or_equal(&self, other: GridPos) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / canvas.filled_polygon( [INFO] [stderr] 88 | | track.out_edge.xs.as_slice(), [INFO] [stderr] 89 | | track.out_edge.ys.as_slice(), [INFO] [stderr] 90 | | track_color [INFO] [stderr] 91 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / canvas.filled_polygon( [INFO] [stderr] 93 | | track.in_edge.xs.as_slice(), [INFO] [stderr] 94 | | track.in_edge.ys.as_slice(), [INFO] [stderr] 95 | | center_color [INFO] [stderr] 96 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | canvas.thick_line(start.x as i16, start.y as i16, end.x as i16, end.y as i16, 2, color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / match cur_pos { [INFO] [stderr] 107 | | Some(pos) => {canvas.filled_circle(pos.x as i16, pos.y as i16, 3, color);}, [INFO] [stderr] 108 | | None => {} [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(pos) = cur_pos {canvas.filled_circle(pos.x as i16, pos.y as i16, 3, color);}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | Some(pos) => {canvas.filled_circle(pos.x as i16, pos.y as i16, 3, color);}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | canvas.rectangle(x1, y1, x2, y2, color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | canvas.rectangle(x1, y1, x2, y2, color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match game_state.valid_move(mouse_pos) { [INFO] [stderr] 139 | | true => { [INFO] [stderr] 140 | | canvas.circle(mdp.x as i16, mdp.y as i16, 3, color); [INFO] [stderr] 141 | | }, [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 138 | if game_state.valid_move(mouse_pos) { [INFO] [stderr] 139 | canvas.circle(mdp.x as i16, mdp.y as i16, 3, color); [INFO] [stderr] 140 | } else { [INFO] [stderr] 141 | canvas.circle(mdp.x as i16, mdp.y as i16, 3, Color::RGB(150,0,0)); [INFO] [stderr] 142 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | canvas.circle(mdp.x as i16, mdp.y as i16, 3, color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | canvas.circle(mdp.x as i16, mdp.y as i16, 3, Color::RGB(150,0,0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:156:33 [INFO] [stderr] | [INFO] [stderr] 156 | fn to_drawing_point(game_point: &GridPos) -> Point { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `GridPos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.99s [INFO] running `"docker" "inspect" "fbdd90b0fe0e079751a62fc9a0ef64b9c46d97bc4cda2f7b92f63e8d0b4dde5d"` [INFO] running `"docker" "rm" "-f" "fbdd90b0fe0e079751a62fc9a0ef64b9c46d97bc4cda2f7b92f63e8d0b4dde5d"` [INFO] [stdout] fbdd90b0fe0e079751a62fc9a0ef64b9c46d97bc4cda2f7b92f63e8d0b4dde5d