[INFO] updating cached repository getwurl/wurl-tools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/getwurl/wurl-tools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/getwurl/wurl-tools" "work/ex/clippy-test-run/sources/stable/gh/getwurl/wurl-tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/getwurl/wurl-tools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/getwurl/wurl-tools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getwurl/wurl-tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getwurl/wurl-tools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ced9b3360a796f6e5322674bbeae811d0b3e0d36 [INFO] sha for GitHub repo getwurl/wurl-tools: ced9b3360a796f6e5322674bbeae811d0b3e0d36 [INFO] validating manifest of getwurl/wurl-tools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of getwurl/wurl-tools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing getwurl/wurl-tools [INFO] finished frobbing getwurl/wurl-tools [INFO] frobbed toml for getwurl/wurl-tools written to work/ex/clippy-test-run/sources/stable/gh/getwurl/wurl-tools/Cargo.toml [INFO] started frobbing getwurl/wurl-tools [INFO] finished frobbing getwurl/wurl-tools [INFO] frobbed toml for getwurl/wurl-tools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getwurl/wurl-tools/Cargo.toml [INFO] crate getwurl/wurl-tools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting getwurl/wurl-tools against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/getwurl/wurl-tools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 40ea8a6eb8c588fdefca1b1db0df7a82a7ff265646ba5ee74fe7ee3d88b4847a [INFO] running `"docker" "start" "-a" "40ea8a6eb8c588fdefca1b1db0df7a82a7ff265646ba5ee74fe7ee3d88b4847a"` [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking wurl-tools v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / return Err(InstructionParseError::new(format!( [INFO] [stderr] 101 | | "{} is not a valid duration", [INFO] [stderr] 102 | | interval [INFO] [stderr] 103 | | ))); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | Err(InstructionParseError::new(format!( [INFO] [stderr] 101 | "{} is not a valid duration", [INFO] [stderr] 102 | interval [INFO] [stderr] 103 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / return Err(InstructionParseError::new(format!( [INFO] [stderr] 101 | | "{} is not a valid duration", [INFO] [stderr] 102 | | interval [INFO] [stderr] 103 | | ))); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | Err(InstructionParseError::new(format!( [INFO] [stderr] 101 | "{} is not a valid duration", [INFO] [stderr] 102 | interval [INFO] [stderr] 103 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/instruction.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | message: matches [INFO] [stderr] | ______________________^ [INFO] [stderr] 68 | | .name("message") [INFO] [stderr] 69 | | .map_or(None, |m| Some(String::from(m.as_str()))), [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] 67 | message: matches [INFO] [stderr] 68 | .name("message").and_then(|m| Some(String::from(m.as_str()))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:86:37 [INFO] [stderr] | [INFO] [stderr] 86 | if interval.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | if interval.contains(".") || interval.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:93:60 [INFO] [stderr] | [INFO] [stderr] 93 | if interval.contains(".") || interval.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | / if let &Some(ref message) = instruction.message() { [INFO] [stderr] 82 | | let cloned = message.clone(); [INFO] [stderr] 83 | | pool.execute_after(*instruction.duration(), move || { [INFO] [stderr] 84 | | println!("{}{}", prefix, cloned); [INFO] [stderr] ... | [INFO] [stderr] 89 | | }); [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | if let Some(ref message) = *instruction.message() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | / if let &Some(ref message) = instruction.message() { [INFO] [stderr] 94 | | let cloned = message.clone(); [INFO] [stderr] 95 | | pool.execute_at_fixed_rate( [INFO] [stderr] 96 | | *instruction.duration(), [INFO] [stderr] ... | [INFO] [stderr] 109 | | ); [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(ref message) = *instruction.message() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/instruction.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | message: matches [INFO] [stderr] | ______________________^ [INFO] [stderr] 68 | | .name("message") [INFO] [stderr] 69 | | .map_or(None, |m| Some(String::from(m.as_str()))), [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] 67 | message: matches [INFO] [stderr] 68 | .name("message").and_then(|m| Some(String::from(m.as_str()))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:86:37 [INFO] [stderr] | [INFO] [stderr] 86 | if interval.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | if interval.contains(".") || interval.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:93:60 [INFO] [stderr] | [INFO] [stderr] 93 | if interval.contains(".") || interval.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | / if let &Some(ref message) = instruction.message() { [INFO] [stderr] 82 | | let cloned = message.clone(); [INFO] [stderr] 83 | | pool.execute_after(*instruction.duration(), move || { [INFO] [stderr] 84 | | println!("{}{}", prefix, cloned); [INFO] [stderr] ... | [INFO] [stderr] 89 | | }); [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | if let Some(ref message) = *instruction.message() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | / if let &Some(ref message) = instruction.message() { [INFO] [stderr] 94 | | let cloned = message.clone(); [INFO] [stderr] 95 | | pool.execute_at_fixed_rate( [INFO] [stderr] 96 | | *instruction.duration(), [INFO] [stderr] ... | [INFO] [stderr] 109 | | ); [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(ref message) = *instruction.message() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.47s [INFO] running `"docker" "inspect" "40ea8a6eb8c588fdefca1b1db0df7a82a7ff265646ba5ee74fe7ee3d88b4847a"` [INFO] running `"docker" "rm" "-f" "40ea8a6eb8c588fdefca1b1db0df7a82a7ff265646ba5ee74fe7ee3d88b4847a"` [INFO] [stdout] 40ea8a6eb8c588fdefca1b1db0df7a82a7ff265646ba5ee74fe7ee3d88b4847a