[INFO] updating cached repository getwurl/wurl-auth [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/getwurl/wurl-auth [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/getwurl/wurl-auth" "work/ex/clippy-test-run/sources/stable/gh/getwurl/wurl-auth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/getwurl/wurl-auth'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/getwurl/wurl-auth" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getwurl/wurl-auth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getwurl/wurl-auth'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d4beb4bb8c97f3b14552c32fa52a93ddc0f3ec6e [INFO] sha for GitHub repo getwurl/wurl-auth: d4beb4bb8c97f3b14552c32fa52a93ddc0f3ec6e [INFO] validating manifest of getwurl/wurl-auth on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of getwurl/wurl-auth on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing getwurl/wurl-auth [INFO] finished frobbing getwurl/wurl-auth [INFO] frobbed toml for getwurl/wurl-auth written to work/ex/clippy-test-run/sources/stable/gh/getwurl/wurl-auth/Cargo.toml [INFO] started frobbing getwurl/wurl-auth [INFO] finished frobbing getwurl/wurl-auth [INFO] frobbed toml for getwurl/wurl-auth written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getwurl/wurl-auth/Cargo.toml [INFO] crate getwurl/wurl-auth has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting getwurl/wurl-auth against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/getwurl/wurl-auth:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba3f2207e6e3df15ae3563540727991a738dd497b857bf74204bc197ecd759ef [INFO] running `"docker" "start" "-a" "ba3f2207e6e3df15ae3563540727991a738dd497b857bf74204bc197ecd759ef"` [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.16 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.26 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking wurl-auth v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | let headers = values_t!(matches, "headers", String).unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | let headers = if let Some ( vals ) = $ m . values_of ( $ v ) { [INFO] [stderr] 23 | let mut tmp = vec ! [ ] ; let mut err = None ; for pv in vals { [INFO] [stderr] 24 | match pv . parse :: < $ t > ( ) { [INFO] [stderr] 25 | Ok ( rv ) => tmp . push ( rv ) , Err ( .. ) => { [INFO] [stderr] 26 | err = Some ( [INFO] [stderr] 27 | :: clap :: Error :: value_validation_auto ( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:62:40 [INFO] [stderr] | [INFO] [stderr] 62 | cookie_values.push(header.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 62 | cookie_values.push(&(*header).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 62 | cookie_values.push(&str::clone(header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wurl-auth`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | let headers = values_t!(matches, "headers", String).unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | let headers = if let Some ( vals ) = $ m . values_of ( $ v ) { [INFO] [stderr] 23 | let mut tmp = vec ! [ ] ; let mut err = None ; for pv in vals { [INFO] [stderr] 24 | match pv . parse :: < $ t > ( ) { [INFO] [stderr] 25 | Ok ( rv ) => tmp . push ( rv ) , Err ( .. ) => { [INFO] [stderr] 26 | err = Some ( [INFO] [stderr] 27 | :: clap :: Error :: value_validation_auto ( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:62:40 [INFO] [stderr] | [INFO] [stderr] 62 | cookie_values.push(header.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 62 | cookie_values.push(&(*header).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 62 | cookie_values.push(&str::clone(header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wurl-auth`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ba3f2207e6e3df15ae3563540727991a738dd497b857bf74204bc197ecd759ef"` [INFO] running `"docker" "rm" "-f" "ba3f2207e6e3df15ae3563540727991a738dd497b857bf74204bc197ecd759ef"` [INFO] [stdout] ba3f2207e6e3df15ae3563540727991a738dd497b857bf74204bc197ecd759ef