[INFO] updating cached repository getsentry/eris [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/getsentry/eris [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/getsentry/eris" "work/ex/clippy-test-run/sources/stable/gh/getsentry/eris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/getsentry/eris'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/getsentry/eris" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getsentry/eris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getsentry/eris'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 179c4855ddde1c9ec6654e35785bf7e2d8cb3b78 [INFO] sha for GitHub repo getsentry/eris: 179c4855ddde1c9ec6654e35785bf7e2d8cb3b78 [INFO] validating manifest of getsentry/eris on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of getsentry/eris on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing getsentry/eris [INFO] finished frobbing getsentry/eris [INFO] frobbed toml for getsentry/eris written to work/ex/clippy-test-run/sources/stable/gh/getsentry/eris/Cargo.toml [INFO] started frobbing getsentry/eris [INFO] finished frobbing getsentry/eris [INFO] frobbed toml for getsentry/eris written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getsentry/eris/Cargo.toml [INFO] crate getsentry/eris has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting getsentry/eris against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/getsentry/eris:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2d0c972a4bf44734267b68f80362ad2b774647a315f447484957517eec514e6a [INFO] running `"docker" "start" "-a" "2d0c972a4bf44734267b68f80362ad2b774647a315f447484957517eec514e6a"` [INFO] [stderr] Checking socket2 v0.2.1 [INFO] [stderr] Checking serde_yaml v0.7.1 [INFO] [stderr] Checking backtrace-sys v0.1.11 [INFO] [stderr] Checking libz-sys v1.0.16 [INFO] [stderr] Compiling serde_derive_internals v0.15.1 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking curl-sys v0.3.14 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking curl v0.4.7 [INFO] [stderr] Checking dotenv v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.9 [INFO] [stderr] Checking eris v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(&mut io::stderr(), "")` [INFO] [stderr] --> src/cli.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | writeln!(&mut io::stderr(), "").ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut io::stderr())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut io::stderr(), "")` [INFO] [stderr] --> src/cli.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | writeln!(&mut io::stderr(), "").ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut io::stderr())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use] extern crate serde_derive; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ArgMatches`, `Arg` [INFO] [stderr] --> src/cli.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use clap::{App, Arg, AppSettings, ArgMatches}; [INFO] [stderr] | ^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const ABOUT: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/cli.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let matches = app.get_matches_from_safe(args)?; [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / if let &ErrorKind::Clap(ref clap_err) = err.kind() { [INFO] [stderr] 34 | | clap_err.exit(); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | if let ErrorKind::Clap(ref clap_err) = *err.kind() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use] extern crate serde_derive; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ArgMatches`, `Arg` [INFO] [stderr] --> src/cli.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use clap::{App, Arg, AppSettings, ArgMatches}; [INFO] [stderr] | ^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const ABOUT: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/cli.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let matches = app.get_matches_from_safe(args)?; [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / if let &ErrorKind::Clap(ref clap_err) = err.kind() { [INFO] [stderr] 34 | | clap_err.exit(); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | if let ErrorKind::Clap(ref clap_err) = *err.kind() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.16s [INFO] running `"docker" "inspect" "2d0c972a4bf44734267b68f80362ad2b774647a315f447484957517eec514e6a"` [INFO] running `"docker" "rm" "-f" "2d0c972a4bf44734267b68f80362ad2b774647a315f447484957517eec514e6a"` [INFO] [stdout] 2d0c972a4bf44734267b68f80362ad2b774647a315f447484957517eec514e6a