[INFO] updating cached repository getreu/stringsext
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/getreu/stringsext
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/getreu/stringsext" "work/ex/clippy-test-run/sources/stable/gh/getreu/stringsext"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/getreu/stringsext'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/getreu/stringsext" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getreu/stringsext"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getreu/stringsext'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 323e3cc4dec133bfb99ac9708074644e8e5747a0
[INFO] sha for GitHub repo getreu/stringsext: 323e3cc4dec133bfb99ac9708074644e8e5747a0
[INFO] validating manifest of getreu/stringsext on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of getreu/stringsext on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing getreu/stringsext
[INFO] finished frobbing getreu/stringsext
[INFO] frobbed toml for getreu/stringsext written to work/ex/clippy-test-run/sources/stable/gh/getreu/stringsext/Cargo.toml
[INFO] started frobbing getreu/stringsext
[INFO] finished frobbing getreu/stringsext
[INFO] frobbed toml for getreu/stringsext written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/getreu/stringsext/Cargo.toml
[INFO] crate getreu/stringsext has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting getreu/stringsext against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/getreu/stringsext:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 69fe3f57cc393e012c8abd6063f3ace5060f263eb94e85c541dcf622a64a16bf
[INFO] running `"docker" "start" "-a" "69fe3f57cc393e012c8abd6063f3ace5060f263eb94e85c541dcf622a64a16bf"`
[INFO] [stderr]     Checking memmap v0.7.0
[INFO] [stderr]    Compiling serde_derive v1.0.81
[INFO] [stderr]     Checking docopt v1.0.2
[INFO] [stderr]     Checking stringsext v1.6.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mission.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             and_mask: and_mask,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `and_mask`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mission.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             and_result: and_result,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `and_result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mission.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |             is_some: is_some,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `is_some`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:246:25
[INFO] [stderr]     |
[INFO] [stderr] 246 |                         nbytes_min: nbytes_min,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nbytes_min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:247:25
[INFO] [stderr]     |
[INFO] [stderr] 247 |                         filter1: filter1,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `filter1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:248:25
[INFO] [stderr]     |
[INFO] [stderr] 248 |                         filter2: filter2,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `filter2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:254:25
[INFO] [stderr]     |
[INFO] [stderr] 254 |                         nbytes_min: nbytes_min,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nbytes_min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:255:25
[INFO] [stderr]     |
[INFO] [stderr] 255 |                         filter1: filter1,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `filter1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:256:25
[INFO] [stderr]     |
[INFO] [stderr] 256 |                         filter2: filter2,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `filter2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:266:21
[INFO] [stderr]     |
[INFO] [stderr] 266 |                     filter1: filter1,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `filter1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:267:21
[INFO] [stderr]     |
[INFO] [stderr] 267 |                     filter2: filter2,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `filter2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:268:21
[INFO] [stderr]     |
[INFO] [stderr] 268 |                     nbytes_min: nbytes_min,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nbytes_min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:283:20
[INFO] [stderr]     |
[INFO] [stderr] 283 |         Missions { v: v }
[INFO] [stderr]     |                    ^^^^ help: replace it with: `v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scanner.rs:131:38
[INFO] [stderr]     |
[INFO] [stderr] 131 |         let mut ms = ScannerStates { v: v };
[INFO] [stderr]     |                                      ^^^^ help: replace it with: `v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scanner.rs:527:13
[INFO] [stderr]     |
[INFO] [stderr] 527 |             completes_last_str: completes_last_str,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `completes_last_str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/finding.rs:348:13
[INFO] [stderr]     |
[INFO] [stderr] 348 |             filename: filename,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/finding.rs:350:13
[INFO] [stderr]     |
[INFO] [stderr] 350 |             mission: mission,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `mission`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/finding.rs:388:17
[INFO] [stderr]     |
[INFO] [stderr] 388 |                 filename: filename,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/finding.rs:390:17
[INFO] [stderr]     |
[INFO] [stderr] 390 |                 mission: mission,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^ help: replace it with: `mission`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mission.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             and_mask: and_mask,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `and_mask`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mission.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             and_result: and_result,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `and_result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mission.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |             is_some: is_some,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `is_some`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:246:25
[INFO] [stderr]     |
[INFO] [stderr] 246 |                         nbytes_min: nbytes_min,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nbytes_min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:247:25
[INFO] [stderr]     |
[INFO] [stderr] 247 |                         filter1: filter1,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `filter1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:248:25
[INFO] [stderr]     |
[INFO] [stderr] 248 |                         filter2: filter2,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `filter2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:254:25
[INFO] [stderr]     |
[INFO] [stderr] 254 |                         nbytes_min: nbytes_min,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nbytes_min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:255:25
[INFO] [stderr]     |
[INFO] [stderr] 255 |                         filter1: filter1,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `filter1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:256:25
[INFO] [stderr]     |
[INFO] [stderr] 256 |                         filter2: filter2,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `filter2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:266:21
[INFO] [stderr]     |
[INFO] [stderr] 266 |                     filter1: filter1,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `filter1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:267:21
[INFO] [stderr]     |
[INFO] [stderr] 267 |                     filter2: filter2,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `filter2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:268:21
[INFO] [stderr]     |
[INFO] [stderr] 268 |                     nbytes_min: nbytes_min,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nbytes_min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mission.rs:283:20
[INFO] [stderr]     |
[INFO] [stderr] 283 |         Missions { v: v }
[INFO] [stderr]     |                    ^^^^ help: replace it with: `v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scanner.rs:131:38
[INFO] [stderr]     |
[INFO] [stderr] 131 |         let mut ms = ScannerStates { v: v };
[INFO] [stderr]     |                                      ^^^^ help: replace it with: `v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scanner.rs:527:13
[INFO] [stderr]     |
[INFO] [stderr] 527 |             completes_last_str: completes_last_str,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `completes_last_str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/finding.rs:348:13
[INFO] [stderr]     |
[INFO] [stderr] 348 |             filename: filename,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/finding.rs:350:13
[INFO] [stderr]     |
[INFO] [stderr] 350 |             mission: mission,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `mission`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/finding.rs:388:17
[INFO] [stderr]     |
[INFO] [stderr] 388 |                 filename: filename,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/finding.rs:390:17
[INFO] [stderr]     |
[INFO] [stderr] 390 |                 mission: mission,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^ help: replace it with: `mission`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/options.rs:11:15
[INFO] [stderr]    |
[INFO] [stderr] 11 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/codec/ascii.rs:9:27
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const ASCII_GRAPHIC: &'static self::AsciiGraphicEncoding = &self::AsciiGraphicEncoding;
[INFO] [stderr]   |                          -^^^^^^^--------------------------- help: consider removing `'static`: `&self::AsciiGraphicEncoding`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:45:16
[INFO] [stderr]    |
[INFO] [stderr] 45 | const AUTHOR: &'static str = "(c) Jens Getreu, 2016-2018";
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/mission.rs:400:42
[INFO] [stderr]     |
[INFO] [stderr] 400 |                 UnicodeBlockFilter::new2(0xffffffc0, 0x40, true),
[INFO] [stderr]     |                                          ^^^^^^^^^^ help: consider: `0xffff_ffc0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/mission.rs:411:42
[INFO] [stderr]     |
[INFO] [stderr] 411 |                 UnicodeBlockFilter::new2(0xffffffe0, 0x60, true),
[INFO] [stderr]     |                                          ^^^^^^^^^^ help: consider: `0xffff_ffe0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/mission.rs:437:42
[INFO] [stderr]     |
[INFO] [stderr] 437 |                 UnicodeBlockFilter::new2(0xffffff00, 0x400, true),
[INFO] [stderr]     |                                          ^^^^^^^^^^ help: consider: `0xffff_ff00`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/mission.rs:448:42
[INFO] [stderr]     |
[INFO] [stderr] 448 |                 UnicodeBlockFilter::new2(0xfffffff0, 0x400, true),
[INFO] [stderr]     |                                          ^^^^^^^^^^ help: consider: `0xffff_fff0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/mission.rs:469:42
[INFO] [stderr]     |
[INFO] [stderr] 469 |                 UnicodeBlockFilter::new2(0xffffff00, 0x0, true),
[INFO] [stderr]     |                                          ^^^^^^^^^^ help: consider: `0xffff_ff00`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/mission.rs:470:42
[INFO] [stderr]     |
[INFO] [stderr] 470 |                 UnicodeBlockFilter::new2(0xfffffff0, 0x400, true)
[INFO] [stderr]     |                                          ^^^^^^^^^^ help: consider: `0xffff_fff0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/options.rs:11:15
[INFO] [stderr]    |
[INFO] [stderr] 11 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/finding.rs:451:50
[INFO] [stderr]     |
[INFO] [stderr] 451 |     pub const CONTROL_REPLACEMENT_STR: &'static &'static str = &"\u{fffd}";
[INFO] [stderr]     |                                                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:476:27
[INFO] [stderr]     |
[INFO] [stderr] 476 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:481:27
[INFO] [stderr]     |
[INFO] [stderr] 481 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:518:27
[INFO] [stderr]     |
[INFO] [stderr] 518 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:523:27
[INFO] [stderr]     |
[INFO] [stderr] 523 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:561:27
[INFO] [stderr]     |
[INFO] [stderr] 561 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:566:27
[INFO] [stderr]     |
[INFO] [stderr] 566 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:603:27
[INFO] [stderr]     |
[INFO] [stderr] 603 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:608:27
[INFO] [stderr]     |
[INFO] [stderr] 608 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:645:27
[INFO] [stderr]     |
[INFO] [stderr] 645 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:650:27
[INFO] [stderr]     |
[INFO] [stderr] 650 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:688:27
[INFO] [stderr]     |
[INFO] [stderr] 688 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:693:27
[INFO] [stderr]     |
[INFO] [stderr] 693 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:731:27
[INFO] [stderr]     |
[INFO] [stderr] 731 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:736:27
[INFO] [stderr]     |
[INFO] [stderr] 736 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:773:27
[INFO] [stderr]     |
[INFO] [stderr] 773 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:778:27
[INFO] [stderr]     |
[INFO] [stderr] 778 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:821:27
[INFO] [stderr]     |
[INFO] [stderr] 821 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:826:27
[INFO] [stderr]     |
[INFO] [stderr] 826 |                 and_mask: 0xffe00000,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffe0_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:865:27
[INFO] [stderr]     |
[INFO] [stderr] 865 |                 and_mask: 0xffffffe0,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffff_ffe0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/finding.rs:911:27
[INFO] [stderr]     |
[INFO] [stderr] 911 |                 and_mask: 0xffffffe0,
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0xffff_ffe0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/codec/ascii.rs:9:27
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const ASCII_GRAPHIC: &'static self::AsciiGraphicEncoding = &self::AsciiGraphicEncoding;
[INFO] [stderr]   |                          -^^^^^^^--------------------------- help: consider removing `'static`: `&self::AsciiGraphicEncoding`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:45:16
[INFO] [stderr]    |
[INFO] [stderr] 45 | const AUTHOR: &'static str = "(c) Jens Getreu, 2016-2018";
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/mission.rs:209:20
[INFO] [stderr]     |
[INFO] [stderr] 209 |         encodings: &Vec<String>,
[INFO] [stderr]     |                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/mission.rs:211:21
[INFO] [stderr]     |
[INFO] [stderr] 211 |         flag_bytes: &Option<u8>,
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider passing by value instead: `Option<u8>`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/mission.rs:292:5
[INFO] [stderr]     |
[INFO] [stderr] 292 | /     fn parse_enc_opt<'a>(
[INFO] [stderr] 293 | |         enc_opt: &'a str,
[INFO] [stderr] 294 | |         nbytes_min_default: u8,
[INFO] [stderr] 295 | |     ) -> Result<(&'a str, u8, UnicodeBlockFilter, UnicodeBlockFilter), CliError> {
[INFO] [stderr] ...   |
[INFO] [stderr] 367 | |         Ok((enc_name, nbytes_min, filter1, filter2))
[INFO] [stderr] 368 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/mission.rs:363:16
[INFO] [stderr]     |
[INFO] [stderr] 363 |           if let Some(_) = i.next() {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 364 | |             return Err(CliError::TooManyTokensError);
[INFO] [stderr] 365 | |         }
[INFO] [stderr]     | |_________- help: try this: `if i.next().is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/scanner.rs:156:23
[INFO] [stderr]     |
[INFO] [stderr] 156 |         byte_counter: &usize,
[INFO] [stderr]     |                       ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/scanner.rs:176:23
[INFO] [stderr]     |
[INFO] [stderr] 176 |         byte_counter: &usize,
[INFO] [stderr]     |                       ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/scanner.rs:240:23
[INFO] [stderr]     |
[INFO] [stderr] 240 |         byte_counter: &usize,
[INFO] [stderr]     |                       ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/scanner.rs:290:78
[INFO] [stderr]     |
[INFO] [stderr] 290 |             (end_pos + (UTF8_LEN_MAX as usize) >= WIN_OVERLAP + WIN_STEP) && ret.v.len() != 0;
[INFO] [stderr]     |                                                                              ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ret.v.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/finding.rs:92:30
[INFO] [stderr]    |
[INFO] [stderr] 92 |     pub fn print(&self, out: &mut Box<dyn Write>) -> Result<(), Box<std::io::Error>> {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn Write`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/finding.rs:360:30
[INFO] [stderr]     |
[INFO] [stderr] 360 |     pub fn print(&self, out: &mut Box<dyn Write>) -> Result<(), Box<std::io::Error>> {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn Write`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/finding.rs:378:12
[INFO] [stderr]     |
[INFO] [stderr] 378 |         if self.v.last().unwrap().s.len() != 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.v.last().unwrap().s.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/finding.rs:386:12
[INFO] [stderr]     |
[INFO] [stderr] 386 |         if self.v.last().unwrap().s.len() != 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.v.last().unwrap().s.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/codec/ascii.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 | /     pub fn new() -> Box<dyn RawEncoder> {
[INFO] [stderr] 38 | |         Box::new(AsciiGraphicEncoder)
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/codec/ascii.rs:91:5
[INFO] [stderr]    |
[INFO] [stderr] 91 | /     pub fn new() -> Box<dyn RawDecoder> {
[INFO] [stderr] 92 | |         Box::new(AsciiGraphicDecoder)
[INFO] [stderr] 93 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a `&[u8]` to a `&str`
[INFO] [stderr]    --> src/codec/ascii.rs:112:39
[INFO] [stderr]     |
[INFO] [stderr] 112 |             output.write_str(unsafe { mem::transmute(buf) });
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8(buf).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::transmute_bytes_to_str)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:107:12
[INFO] [stderr]     |
[INFO] [stderr] 107 |         if (ARGS.arg_FILE.len() == 0) || ((ARGS.arg_FILE.len() == 1) && ARGS.arg_FILE[0] == "-") {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ARGS.arg_FILE.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:110:17
[INFO] [stderr]     |
[INFO] [stderr] 110 |             for ref filename in ARGS.arg_FILE.iter() {
[INFO] [stderr]     |                 ^^^^^^^^^^^^    -------------------- help: try: `let filename = &ARGS.arg_FILE.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/mission.rs:209:20
[INFO] [stderr]     |
[INFO] [stderr] 209 |         encodings: &Vec<String>,
[INFO] [stderr]     |                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/mission.rs:211:21
[INFO] [stderr]     |
[INFO] [stderr] 211 |         flag_bytes: &Option<u8>,
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider passing by value instead: `Option<u8>`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/mission.rs:292:5
[INFO] [stderr]     |
[INFO] [stderr] 292 | /     fn parse_enc_opt<'a>(
[INFO] [stderr] 293 | |         enc_opt: &'a str,
[INFO] [stderr] 294 | |         nbytes_min_default: u8,
[INFO] [stderr] 295 | |     ) -> Result<(&'a str, u8, UnicodeBlockFilter, UnicodeBlockFilter), CliError> {
[INFO] [stderr] ...   |
[INFO] [stderr] 367 | |         Ok((enc_name, nbytes_min, filter1, filter2))
[INFO] [stderr] 368 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/mission.rs:363:16
[INFO] [stderr]     |
[INFO] [stderr] 363 |           if let Some(_) = i.next() {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 364 | |             return Err(CliError::TooManyTokensError);
[INFO] [stderr] 365 | |         }
[INFO] [stderr]     | |_________- help: try this: `if i.next().is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/scanner.rs:156:23
[INFO] [stderr]     |
[INFO] [stderr] 156 |         byte_counter: &usize,
[INFO] [stderr]     |                       ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/scanner.rs:176:23
[INFO] [stderr]     |
[INFO] [stderr] 176 |         byte_counter: &usize,
[INFO] [stderr]     |                       ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/scanner.rs:240:23
[INFO] [stderr]     |
[INFO] [stderr] 240 |         byte_counter: &usize,
[INFO] [stderr]     |                       ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/scanner.rs:290:78
[INFO] [stderr]     |
[INFO] [stderr] 290 |             (end_pos + (UTF8_LEN_MAX as usize) >= WIN_OVERLAP + WIN_STEP) && ret.v.len() != 0;
[INFO] [stderr]     |                                                                              ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ret.v.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/scanner.rs:943:19
[INFO] [stderr]     |
[INFO] [stderr] 943 |         let inp = "Hello world! How do you do?".as_bytes();
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello world! How do you do?"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/finding.rs:92:30
[INFO] [stderr]    |
[INFO] [stderr] 92 |     pub fn print(&self, out: &mut Box<dyn Write>) -> Result<(), Box<std::io::Error>> {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn Write`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/finding.rs:360:30
[INFO] [stderr]     |
[INFO] [stderr] 360 |     pub fn print(&self, out: &mut Box<dyn Write>) -> Result<(), Box<std::io::Error>> {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn Write`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/finding.rs:378:12
[INFO] [stderr]     |
[INFO] [stderr] 378 |         if self.v.last().unwrap().s.len() != 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.v.last().unwrap().s.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/finding.rs:386:12
[INFO] [stderr]     |
[INFO] [stderr] 386 |         if self.v.last().unwrap().s.len() != 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.v.last().unwrap().s.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/codec/ascii.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 | /     pub fn new() -> Box<dyn RawEncoder> {
[INFO] [stderr] 38 | |         Box::new(AsciiGraphicEncoder)
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/codec/ascii.rs:91:5
[INFO] [stderr]    |
[INFO] [stderr] 91 | /     pub fn new() -> Box<dyn RawDecoder> {
[INFO] [stderr] 92 | |         Box::new(AsciiGraphicDecoder)
[INFO] [stderr] 93 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a `&[u8]` to a `&str`
[INFO] [stderr]    --> src/codec/ascii.rs:112:39
[INFO] [stderr]     |
[INFO] [stderr] 112 |             output.write_str(unsafe { mem::transmute(buf) });
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8(buf).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::transmute_bytes_to_str)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:107:12
[INFO] [stderr]     |
[INFO] [stderr] 107 |         if (ARGS.arg_FILE.len() == 0) || ((ARGS.arg_FILE.len() == 1) && ARGS.arg_FILE[0] == "-") {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ARGS.arg_FILE.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:110:17
[INFO] [stderr]     |
[INFO] [stderr] 110 |             for ref filename in ARGS.arg_FILE.iter() {
[INFO] [stderr]     |                 ^^^^^^^^^^^^    -------------------- help: try: `let filename = &ARGS.arg_FILE.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.60s
[INFO] running `"docker" "inspect" "69fe3f57cc393e012c8abd6063f3ace5060f263eb94e85c541dcf622a64a16bf"`
[INFO] running `"docker" "rm" "-f" "69fe3f57cc393e012c8abd6063f3ace5060f263eb94e85c541dcf622a64a16bf"`
[INFO] [stdout] 69fe3f57cc393e012c8abd6063f3ace5060f263eb94e85c541dcf622a64a16bf