[INFO] updating cached repository georgeteo/rust-present
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/georgeteo/rust-present
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/georgeteo/rust-present" "work/ex/clippy-test-run/sources/stable/gh/georgeteo/rust-present"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/georgeteo/rust-present'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/georgeteo/rust-present" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/georgeteo/rust-present"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/georgeteo/rust-present'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 785827d8c00ed065801e46fd115266155edb9e93
[INFO] sha for GitHub repo georgeteo/rust-present: 785827d8c00ed065801e46fd115266155edb9e93
[INFO] validating manifest of georgeteo/rust-present on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of georgeteo/rust-present on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing georgeteo/rust-present
[INFO] finished frobbing georgeteo/rust-present
[INFO] frobbed toml for georgeteo/rust-present written to work/ex/clippy-test-run/sources/stable/gh/georgeteo/rust-present/Cargo.toml
[INFO] started frobbing georgeteo/rust-present
[INFO] finished frobbing georgeteo/rust-present
[INFO] frobbed toml for georgeteo/rust-present written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/georgeteo/rust-present/Cargo.toml
[INFO] crate georgeteo/rust-present has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting georgeteo/rust-present against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/georgeteo/rust-present:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b7ec667d4c802e1ab1d50ad259193826686dcd500a4f6b8710b4fc4496b1d970
[INFO] running `"docker" "start" "-a" "b7ec667d4c802e1ab1d50ad259193826686dcd500a4f6b8710b4fc4496b1d970"`
[INFO] [stderr]     Checking present v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/parser/header/error.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |         write!(f, "Line {}: Expected {} - Got {}\n", self.line_num, self.expected, self.input)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser/header/error.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             line_num: line_num,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `line_num`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser/header/error.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser/header/error.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             expected: expected,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/parser/header/error.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |         write!(f, "Line {}: Expected {} - Got {}\n", self.line_num, self.expected, self.input)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/header/error.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             line_num: line_num,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `line_num`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/header/error.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             input: input,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/header/error.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             expected: expected,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser/slide/builder.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             token: token,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `token`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/parser/header/error.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |         write!(f, "Line {}: Expected {} - Got {}\n", self.line_num, self.expected, self.input)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser/header/error.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             line_num: line_num,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `line_num`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser/header/error.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser/header/error.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             expected: expected,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/parser/header/error.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |         write!(f, "Line {}: Expected {} - Got {}\n", self.line_num, self.expected, self.input)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/header/error.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             line_num: line_num,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `line_num`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/header/error.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             input: input,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/header/error.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             expected: expected,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser/slide/builder.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             token: token,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `token`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/parser/header/mod.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | mod header;
[INFO] [stderr]   | ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/parser/header/header/mod.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | mod header;
[INFO] [stderr]   | ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/parser/header/author/mod.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub mod author;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/parser/header/mod.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | mod header;
[INFO] [stderr]   | ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/parser/header/header/mod.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | mod header;
[INFO] [stderr]   | ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/parser/header/author/mod.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub mod author;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `line_num`
[INFO] [stderr]   --> src/parser/slide/token.rs:63:61
[INFO] [stderr]    |
[INFO] [stderr] 63 |     pub fn new(parent: &Token, lookback: &str, input: char, line_num: usize) -> Result<MaybeToken, TokenError> {
[INFO] [stderr]    |                                                             ^^^^^^^^ help: consider using `_line_num` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `OL`
[INFO] [stderr]   --> src/parser/slide/token.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     OL(Tokens),
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `OLEntry`
[INFO] [stderr]   --> src/parser/slide/token.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     OLEntry(Tokens),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser/header/header/header.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         match self {
[INFO] [stderr] 42 | |             &HeaderType::Title(_) => write!(f, "title"),
[INFO] [stderr] 43 | |             &HeaderType::Subtitle(_) => write!(f, "subtitle"),
[INFO] [stderr] 44 | |             &HeaderType::DateTime(_) => write!(f, "datetime"),
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |             &HeaderType::NewLine => write!(f, "new line"),
[INFO] [stderr] 48 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 41 |         match *self {
[INFO] [stderr] 42 |             HeaderType::Title(_) => write!(f, "title"),
[INFO] [stderr] 43 |             HeaderType::Subtitle(_) => write!(f, "subtitle"),
[INFO] [stderr] 44 |             HeaderType::DateTime(_) => write!(f, "datetime"),
[INFO] [stderr] 45 |             HeaderType::Tags(_) => write!(f, "tag1, tag2, tag3"),
[INFO] [stderr] 46 |             HeaderType::Authors(_) => write!(f, "author block"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser/header/header/builder.rs:21:62
[INFO] [stderr]    |
[INFO] [stderr] 21 |             3 => self.header.tags = header::Tags(input.split(",").map(|x| x.to_string()).collect()),
[INFO] [stderr]    |                                                              ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser/header/header/builder.rs:38:30
[INFO] [stderr]    |
[INFO] [stderr] 38 |     pub fn end(&self, input: &String) -> bool {
[INFO] [stderr]    |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser/header/author/builder.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         match self {
[INFO] [stderr] 24 | |             &AuthorFields::Name => write!(f, "author name"),
[INFO] [stderr] 25 | |             &AuthorFields::Job => write!(f, "author job"),
[INFO] [stderr] 26 | |             &AuthorFields::Email => write!(f, "author email"),
[INFO] [stderr] 27 | |             &AuthorFields::Website => write!(f, "author website"),
[INFO] [stderr] 28 | |             &AuthorFields::Blank => write!(f, "blank line"),
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 23 |         match *self {
[INFO] [stderr] 24 |             AuthorFields::Name => write!(f, "author name"),
[INFO] [stderr] 25 |             AuthorFields::Job => write!(f, "author job"),
[INFO] [stderr] 26 |             AuthorFields::Email => write!(f, "author email"),
[INFO] [stderr] 27 |             AuthorFields::Website => write!(f, "author website"),
[INFO] [stderr] 28 |             AuthorFields::Blank => write!(f, "blank line"),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/parser/slide/builder.rs:36:16
[INFO] [stderr]    |
[INFO] [stderr] 36 |           if let None = self.parser.as_ref() {
[INFO] [stderr]    |  _________-      ^^^^
[INFO] [stderr] 37 | |             if end {
[INFO] [stderr] 38 | |                 return Ok(Some(self.token.clone())) ;
[INFO] [stderr] 39 | |             } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |             }
[INFO] [stderr] 56 | |         }
[INFO] [stderr]    | |_________- help: try this: `if self.parser.as_ref().is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/parser/slide/builder.rs:44:32
[INFO] [stderr]    |
[INFO] [stderr] 44 |                         if let None = try!(builder.parse(end, input, line_num)) {
[INFO] [stderr]    |                                ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 2  | if match $ expr {
[INFO] [stderr] 3  | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 4  | :: Err ( err ) => {
[INFO] [stderr] 5  | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 6  | $ crate :: convert :: From :: from ( err ) ) } }.is_none() ) ; ( $ expr : expr , ) => (
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser/slide/token.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 | /         match self {
[INFO] [stderr] 36 | |             & mut Pair(None, _) => { self.0 = Some(Box::new(t)); },
[INFO] [stderr] 37 | |             & mut Pair(_, None) => { self.1 = Some(Box::new(t)); },
[INFO] [stderr] 38 | |             _ => {/* TODO: Error */ },
[INFO] [stderr] 39 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 35 |         match *self {
[INFO] [stderr] 36 |             Pair(None, _) => { self.0 = Some(Box::new(t)); },
[INFO] [stderr] 37 |             Pair(_, None) => { self.1 = Some(Box::new(t)); },
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/parser/slide/token.rs:63:5
[INFO] [stderr]     |
[INFO] [stderr] 63  | /     pub fn new(parent: &Token, lookback: &str, input: char, line_num: usize) -> Result<MaybeToken, TokenError> {
[INFO] [stderr] 64  | |         match (parent, lookback, input) {
[INFO] [stderr] 65  | |             (&Token::Slide(_), "#", '#') | (&Token::Slide(_), "##", '#') | (&Token::Slide(_), "###", '#') =>
[INFO] [stderr] 66  | |                 Ok(MaybeToken::NoToken),
[INFO] [stderr] ...   |
[INFO] [stderr] 103 | |         }
[INFO] [stderr] 104 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser/slide/token.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 | /         match self {
[INFO] [stderr] 112 | |             & mut Token::Link(ref mut p) | & mut Token::Image(ref mut p) => p.push(token),
[INFO] [stderr] 113 | |             & mut Token::Slide(ref mut v) | & mut Token::H1(ref mut v) | & mut Token::H2(ref mut v) | & mut Token::H3(ref mut v)
[INFO] [stderr] 114 | |             | & mut Token::H4(ref mut v) | & mut Token::P(ref mut v) | & mut Token::OL(ref mut v) | & mut Token::OLEntry(ref mut v)
[INFO] [stderr] 115 | |             | & mut Token::UL(ref mut v) | & mut Token::ULEntry(ref mut v)  => v.push(token),
[INFO] [stderr] 116 | |             _ => panic!("Error: Should not be calling Token::push on {:?}", self),
[INFO] [stderr] 117 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 111 |         match *self {
[INFO] [stderr] 112 |             Token::Link(ref mut p) | Token::Image(ref mut p) => p.push(token),
[INFO] [stderr] 113 |             Token::Slide(ref mut v) | Token::H1(ref mut v) | Token::H2(ref mut v) | Token::H3(ref mut v)
[INFO] [stderr] 114 |             | Token::H4(ref mut v) | Token::P(ref mut v) | Token::OL(ref mut v) | Token::OLEntry(ref mut v)
[INFO] [stderr] 115 |             | Token::UL(ref mut v) | Token::ULEntry(ref mut v)  => v.push(token),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `line_num`
[INFO] [stderr]   --> src/parser/slide/token.rs:63:61
[INFO] [stderr]    |
[INFO] [stderr] 63 |     pub fn new(parent: &Token, lookback: &str, input: char, line_num: usize) -> Result<MaybeToken, TokenError> {
[INFO] [stderr]    |                                                             ^^^^^^^^ help: consider using `_line_num` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser/mod.rs:96:12
[INFO] [stderr]    |
[INFO] [stderr] 96 |         if self.errors.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.errors.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `OL`
[INFO] [stderr]   --> src/parser/slide/token.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     OL(Tokens),
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `OLEntry`
[INFO] [stderr]   --> src/parser/slide/token.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     OLEntry(Tokens),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser/header/header/header.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         match self {
[INFO] [stderr] 42 | |             &HeaderType::Title(_) => write!(f, "title"),
[INFO] [stderr] 43 | |             &HeaderType::Subtitle(_) => write!(f, "subtitle"),
[INFO] [stderr] 44 | |             &HeaderType::DateTime(_) => write!(f, "datetime"),
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |             &HeaderType::NewLine => write!(f, "new line"),
[INFO] [stderr] 48 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 41 |         match *self {
[INFO] [stderr] 42 |             HeaderType::Title(_) => write!(f, "title"),
[INFO] [stderr] 43 |             HeaderType::Subtitle(_) => write!(f, "subtitle"),
[INFO] [stderr] 44 |             HeaderType::DateTime(_) => write!(f, "datetime"),
[INFO] [stderr] 45 |             HeaderType::Tags(_) => write!(f, "tag1, tag2, tag3"),
[INFO] [stderr] 46 |             HeaderType::Authors(_) => write!(f, "author block"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser/header/header/builder.rs:21:62
[INFO] [stderr]    |
[INFO] [stderr] 21 |             3 => self.header.tags = header::Tags(input.split(",").map(|x| x.to_string()).collect()),
[INFO] [stderr]    |                                                              ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser/header/header/builder.rs:38:30
[INFO] [stderr]    |
[INFO] [stderr] 38 |     pub fn end(&self, input: &String) -> bool {
[INFO] [stderr]    |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser/header/author/builder.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         match self {
[INFO] [stderr] 24 | |             &AuthorFields::Name => write!(f, "author name"),
[INFO] [stderr] 25 | |             &AuthorFields::Job => write!(f, "author job"),
[INFO] [stderr] 26 | |             &AuthorFields::Email => write!(f, "author email"),
[INFO] [stderr] 27 | |             &AuthorFields::Website => write!(f, "author website"),
[INFO] [stderr] 28 | |             &AuthorFields::Blank => write!(f, "blank line"),
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 23 |         match *self {
[INFO] [stderr] 24 |             AuthorFields::Name => write!(f, "author name"),
[INFO] [stderr] 25 |             AuthorFields::Job => write!(f, "author job"),
[INFO] [stderr] 26 |             AuthorFields::Email => write!(f, "author email"),
[INFO] [stderr] 27 |             AuthorFields::Website => write!(f, "author website"),
[INFO] [stderr] 28 |             AuthorFields::Blank => write!(f, "blank line"),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/parser/slide/builder.rs:36:16
[INFO] [stderr]    |
[INFO] [stderr] 36 |           if let None = self.parser.as_ref() {
[INFO] [stderr]    |  _________-      ^^^^
[INFO] [stderr] 37 | |             if end {
[INFO] [stderr] 38 | |                 return Ok(Some(self.token.clone())) ;
[INFO] [stderr] 39 | |             } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |             }
[INFO] [stderr] 56 | |         }
[INFO] [stderr]    | |_________- help: try this: `if self.parser.as_ref().is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/parser/slide/builder.rs:44:32
[INFO] [stderr]    |
[INFO] [stderr] 44 |                         if let None = try!(builder.parse(end, input, line_num)) {
[INFO] [stderr]    |                                ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 2  | if match $ expr {
[INFO] [stderr] 3  | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 4  | :: Err ( err ) => {
[INFO] [stderr] 5  | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 6  | $ crate :: convert :: From :: from ( err ) ) } }.is_none() ) ; ( $ expr : expr , ) => (
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser/slide/token.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 | /         match self {
[INFO] [stderr] 36 | |             & mut Pair(None, _) => { self.0 = Some(Box::new(t)); },
[INFO] [stderr] 37 | |             & mut Pair(_, None) => { self.1 = Some(Box::new(t)); },
[INFO] [stderr] 38 | |             _ => {/* TODO: Error */ },
[INFO] [stderr] 39 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 35 |         match *self {
[INFO] [stderr] 36 |             Pair(None, _) => { self.0 = Some(Box::new(t)); },
[INFO] [stderr] 37 |             Pair(_, None) => { self.1 = Some(Box::new(t)); },
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/parser/slide/token.rs:63:5
[INFO] [stderr]     |
[INFO] [stderr] 63  | /     pub fn new(parent: &Token, lookback: &str, input: char, line_num: usize) -> Result<MaybeToken, TokenError> {
[INFO] [stderr] 64  | |         match (parent, lookback, input) {
[INFO] [stderr] 65  | |             (&Token::Slide(_), "#", '#') | (&Token::Slide(_), "##", '#') | (&Token::Slide(_), "###", '#') =>
[INFO] [stderr] 66  | |                 Ok(MaybeToken::NoToken),
[INFO] [stderr] ...   |
[INFO] [stderr] 103 | |         }
[INFO] [stderr] 104 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser/slide/token.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 | /         match self {
[INFO] [stderr] 112 | |             & mut Token::Link(ref mut p) | & mut Token::Image(ref mut p) => p.push(token),
[INFO] [stderr] 113 | |             & mut Token::Slide(ref mut v) | & mut Token::H1(ref mut v) | & mut Token::H2(ref mut v) | & mut Token::H3(ref mut v)
[INFO] [stderr] 114 | |             | & mut Token::H4(ref mut v) | & mut Token::P(ref mut v) | & mut Token::OL(ref mut v) | & mut Token::OLEntry(ref mut v)
[INFO] [stderr] 115 | |             | & mut Token::UL(ref mut v) | & mut Token::ULEntry(ref mut v)  => v.push(token),
[INFO] [stderr] 116 | |             _ => panic!("Error: Should not be calling Token::push on {:?}", self),
[INFO] [stderr] 117 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 111 |         match *self {
[INFO] [stderr] 112 |             Token::Link(ref mut p) | Token::Image(ref mut p) => p.push(token),
[INFO] [stderr] 113 |             Token::Slide(ref mut v) | Token::H1(ref mut v) | Token::H2(ref mut v) | Token::H3(ref mut v)
[INFO] [stderr] 114 |             | Token::H4(ref mut v) | Token::P(ref mut v) | Token::OL(ref mut v) | Token::OLEntry(ref mut v)
[INFO] [stderr] 115 |             | Token::UL(ref mut v) | Token::ULEntry(ref mut v)  => v.push(token),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser/mod.rs:96:12
[INFO] [stderr]    |
[INFO] [stderr] 96 |         if self.errors.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.errors.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.95s
[INFO] running `"docker" "inspect" "b7ec667d4c802e1ab1d50ad259193826686dcd500a4f6b8710b4fc4496b1d970"`
[INFO] running `"docker" "rm" "-f" "b7ec667d4c802e1ab1d50ad259193826686dcd500a4f6b8710b4fc4496b1d970"`
[INFO] [stdout] b7ec667d4c802e1ab1d50ad259193826686dcd500a4f6b8710b4fc4496b1d970