[INFO] updating cached repository georgehipp/guessing_game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/georgehipp/guessing_game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/georgehipp/guessing_game" "work/ex/clippy-test-run/sources/stable/gh/georgehipp/guessing_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/georgehipp/guessing_game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/georgehipp/guessing_game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/georgehipp/guessing_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/georgehipp/guessing_game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] da7642d4c31b4e1ba1b42f1197b57f7f877860a6 [INFO] sha for GitHub repo georgehipp/guessing_game: da7642d4c31b4e1ba1b42f1197b57f7f877860a6 [INFO] validating manifest of georgehipp/guessing_game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of georgehipp/guessing_game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing georgehipp/guessing_game [INFO] finished frobbing georgehipp/guessing_game [INFO] frobbed toml for georgehipp/guessing_game written to work/ex/clippy-test-run/sources/stable/gh/georgehipp/guessing_game/Cargo.toml [INFO] started frobbing georgehipp/guessing_game [INFO] finished frobbing georgehipp/guessing_game [INFO] frobbed toml for georgehipp/guessing_game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/georgehipp/guessing_game/Cargo.toml [INFO] crate georgehipp/guessing_game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting georgehipp/guessing_game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/georgehipp/guessing_game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8355073dffac6738d9ac76f29619be1573dad104230054241c0c332460131f7f [INFO] running `"docker" "start" "-a" "8355073dffac6738d9ac76f29619be1573dad104230054241c0c332460131f7f"` [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling backtrace v0.3.6 [INFO] [stderr] Compiling cargo_metadata v0.3.3 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] Checking guessing_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return secret_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `secret_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return secret_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `secret_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.69s [INFO] running `"docker" "inspect" "8355073dffac6738d9ac76f29619be1573dad104230054241c0c332460131f7f"` [INFO] running `"docker" "rm" "-f" "8355073dffac6738d9ac76f29619be1573dad104230054241c0c332460131f7f"` [INFO] [stdout] 8355073dffac6738d9ac76f29619be1573dad104230054241c0c332460131f7f