[INFO] updating cached repository geoolekom/rust-db [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/geoolekom/rust-db [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/geoolekom/rust-db" "work/ex/clippy-test-run/sources/stable/gh/geoolekom/rust-db"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/geoolekom/rust-db'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/geoolekom/rust-db" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geoolekom/rust-db"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geoolekom/rust-db'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b5a18580781dc556bfadb1dd979c0eb6780fa8b7 [INFO] sha for GitHub repo geoolekom/rust-db: b5a18580781dc556bfadb1dd979c0eb6780fa8b7 [INFO] validating manifest of geoolekom/rust-db on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of geoolekom/rust-db on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing geoolekom/rust-db [INFO] finished frobbing geoolekom/rust-db [INFO] frobbed toml for geoolekom/rust-db written to work/ex/clippy-test-run/sources/stable/gh/geoolekom/rust-db/Cargo.toml [INFO] started frobbing geoolekom/rust-db [INFO] finished frobbing geoolekom/rust-db [INFO] frobbed toml for geoolekom/rust-db written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geoolekom/rust-db/Cargo.toml [INFO] crate geoolekom/rust-db has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting geoolekom/rust-db against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/geoolekom/rust-db:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afeecba0c647ed5958378746e8f30c6d431e301629ba172a72264f75bc461dda [INFO] running `"docker" "start" "-a" "afeecba0c647ed5958378746e8f30c6d431e301629ba172a72264f75bc461dda"` [INFO] [stderr] Checking rust-sqlite v0.3.0 [INFO] [stderr] Checking rustdb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:42:4 [INFO] [stderr] | [INFO] [stderr] 42 | connection: connection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:43:4 [INFO] [stderr] | [INFO] [stderr] 43 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:119:4 [INFO] [stderr] | [INFO] [stderr] 119 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:42:4 [INFO] [stderr] | [INFO] [stderr] 42 | connection: connection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:43:4 [INFO] [stderr] | [INFO] [stderr] 43 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:119:4 [INFO] [stderr] | [INFO] [stderr] 119 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/storage.rs:143:3 [INFO] [stderr] | [INFO] [stderr] 143 | models [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/storage.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | let models = match stmt.query(&[], to_model) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 140 | | Ok(models) => models.collect(), [INFO] [stderr] 141 | | Err(err) => panic!("Query execution: {}", err), [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `row` [INFO] [stderr] --> src/storage.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | match stmt.query(&[], |row: &mut ResultRow| Ok(())) { [INFO] [stderr] | ^^^ help: consider using `_row` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sql` [INFO] [stderr] --> src/storage.rs:114:7 [INFO] [stderr] | [INFO] [stderr] 114 | let sql = "insert into ".to_string() + self.table + " () values " + ";"; [INFO] [stderr] | ^^^ help: consider using `_sql` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `model` [INFO] [stderr] --> src/storage.rs:113:30 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn add(&self, model: T) { [INFO] [stderr] | ^^^^^ help: consider using `_model` instead [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/storage.rs:143:3 [INFO] [stderr] | [INFO] [stderr] 143 | models [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/storage.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | let models = match stmt.query(&[], to_model) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 140 | | Ok(models) => models.collect(), [INFO] [stderr] 141 | | Err(err) => panic!("Query execution: {}", err), [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `process_update` [INFO] [stderr] --> src/storage.rs:146:2 [INFO] [stderr] | [INFO] [stderr] 146 | fn process_update() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `row` [INFO] [stderr] --> src/storage.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | match stmt.query(&[], |row: &mut ResultRow| Ok(())) { [INFO] [stderr] | ^^^ help: consider using `_row` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sql` [INFO] [stderr] --> src/storage.rs:114:7 [INFO] [stderr] | [INFO] [stderr] 114 | let sql = "insert into ".to_string() + self.table + " () values " + ";"; [INFO] [stderr] | ^^^ help: consider using `_sql` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `model` [INFO] [stderr] --> src/storage.rs:113:30 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn add(&self, model: T) { [INFO] [stderr] | ^^^^^ help: consider using `_model` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `process_update` [INFO] [stderr] --> src/storage.rs:146:2 [INFO] [stderr] | [INFO] [stderr] 146 | fn process_update() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `field_types` [INFO] [stderr] --> src/main.rs:19:6 [INFO] [stderr] | [INFO] [stderr] 19 | let field_types = User::field_types(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_field_types` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `field_types` [INFO] [stderr] --> src/main.rs:19:6 [INFO] [stderr] | [INFO] [stderr] 19 | let field_types = User::field_types(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_field_types` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.24s [INFO] running `"docker" "inspect" "afeecba0c647ed5958378746e8f30c6d431e301629ba172a72264f75bc461dda"` [INFO] running `"docker" "rm" "-f" "afeecba0c647ed5958378746e8f30c6d431e301629ba172a72264f75bc461dda"` [INFO] [stdout] afeecba0c647ed5958378746e8f30c6d431e301629ba172a72264f75bc461dda