[INFO] updating cached repository geoffreycopin/boggle_server
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/geoffreycopin/boggle_server
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/geoffreycopin/boggle_server" "work/ex/clippy-test-run/sources/stable/gh/geoffreycopin/boggle_server"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/geoffreycopin/boggle_server'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/geoffreycopin/boggle_server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geoffreycopin/boggle_server"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geoffreycopin/boggle_server'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 04c9007a58ec03103613c142d0f546708cee6680
[INFO] sha for GitHub repo geoffreycopin/boggle_server: 04c9007a58ec03103613c142d0f546708cee6680
[INFO] validating manifest of geoffreycopin/boggle_server on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of geoffreycopin/boggle_server on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing geoffreycopin/boggle_server
[INFO] finished frobbing geoffreycopin/boggle_server
[INFO] frobbed toml for geoffreycopin/boggle_server written to work/ex/clippy-test-run/sources/stable/gh/geoffreycopin/boggle_server/Cargo.toml
[INFO] started frobbing geoffreycopin/boggle_server
[INFO] finished frobbing geoffreycopin/boggle_server
[INFO] frobbed toml for geoffreycopin/boggle_server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geoffreycopin/boggle_server/Cargo.toml
[INFO] crate geoffreycopin/boggle_server has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting geoffreycopin/boggle_server against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/geoffreycopin/boggle_server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6475964fdfa964b4272b616033491d68cec4e4337cd5348a99523d8f9e718dfa
[INFO] running `"docker" "start" "-a" "6475964fdfa964b4272b616033491d68cec4e4337cd5348a99523d8f9e718dfa"`
[INFO] [stderr]     Checking unidecode v0.3.0
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]     Checking boggle_server v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/board/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod board;
[INFO] [stderr]   | ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/server/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod server;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/board/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod board;
[INFO] [stderr]   | ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/server/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod server;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/board/board.rs:134:51
[INFO] [stderr]     |
[INFO] [stderr] 134 |         self.player_words.entry(user.to_string()).or_insert(vec![])
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/game.rs:27:27
[INFO] [stderr]    |
[INFO] [stderr] 27 |             turn_running: Mutex::new(false),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/game.rs:45:27
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let mut running = self.turn_running.lock().unwrap();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/game.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         stream.write(welcome_str.as_bytes()).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/game.rs:89:27
[INFO] [stderr]    |
[INFO] [stderr] 89 |         let mut running = self.turn_running.lock().unwrap();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/game.rs:96:10
[INFO] [stderr]    |
[INFO] [stderr] 96 |         *self.turn_running.lock().unwrap() = false;
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/players.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 |         stream.write(format!("PRECEPTION/{}/{}/\n", msg, send).as_bytes()).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/log.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 | /         match self {
[INFO] [stderr] 49 | |             &LogMsg::Login(ref name) => write!(f, "{} vient de se connecter.", name),
[INFO] [stderr] 50 | |             &LogMsg::Logout(ref name) => write!(f, "{} vient de se déconnecter.", name),
[INFO] [stderr] 51 | |             &LogMsg::Accepted(ref name, ref word) => write!(f, "Le mot {} soumis par {} a été accepté.", word, name),
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |             &LogMsg::SessionEnd => write!(f, "Fin de la session."),
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 48 |         match *self {
[INFO] [stderr] 49 |             LogMsg::Login(ref name) => write!(f, "{} vient de se connecter.", name),
[INFO] [stderr] 50 |             LogMsg::Logout(ref name) => write!(f, "{} vient de se déconnecter.", name),
[INFO] [stderr] 51 |             LogMsg::Accepted(ref name, ref word) => write!(f, "Le mot {} soumis par {} a été accepté.", word, name),
[INFO] [stderr] 52 |             LogMsg::Error(ref e) => write!(f, "Erreur: {}", e),
[INFO] [stderr] 53 |             LogMsg::MessageSent(ref s, ref r, ref m) =>
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/server/server.rs:30:25
[INFO] [stderr]    |
[INFO] [stderr] 30 |             nb_players: Mutex::new(0),
[INFO] [stderr]    |                         ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/server/server.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         self.nb_players.lock().unwrap().clone()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.nb_players.lock().unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/server/server.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         self.nb_players.lock().unwrap().clone()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/server/server.rs:117:61
[INFO] [stderr]     |
[INFO] [stderr] 117 |             .map(|_|  { self.log(LogMsg::login(username)); *self.nb_players.lock().unwrap() += 1 })
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/server/server.rs:124:14
[INFO] [stderr]     |
[INFO] [stderr] 124 |             *self.nb_players.lock().unwrap() -= 1;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/server/server.rs:137:21
[INFO] [stderr]     |
[INFO] [stderr] 137 | /                     writer.write(format!("MVALIDE/{}/\n", word).as_bytes())
[INFO] [stderr] 138 | |                         .expect("Cannot write response");
[INFO] [stderr]     | |________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/server/server.rs:145:21
[INFO] [stderr]     |
[INFO] [stderr] 145 | /                     writer.write(format!("MINVALIDE/{}/\n", msg).as_bytes())
[INFO] [stderr] 146 | |                         .expect("Cannot write response");
[INFO] [stderr]     | |________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/server/mod.rs:72:43
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let components: Vec<&str> = req.split("/").collect();
[INFO] [stderr]    |                                           ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/server/mod.rs:75:19
[INFO] [stderr]    |
[INFO] [stderr] 75 |       let request = match components.get(0).ok_or(err.clone())? {
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 76 | |         &"CONNEXION" => parse_connexion(&components),
[INFO] [stderr] 77 | |         &"SORT" => parse_sort(&components),
[INFO] [stderr] 78 | |         &"TROUVE" => parse_trouve(&components),
[INFO] [stderr] ...  |
[INFO] [stderr] 81 | |         _ => Err(())
[INFO] [stderr] 82 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 75 |     let request = match *(components.get(0).ok_or(err.clone())?) {
[INFO] [stderr] 76 |         "CONNEXION" => parse_connexion(&components),
[INFO] [stderr] 77 |         "SORT" => parse_sort(&components),
[INFO] [stderr] 78 |         "TROUVE" => parse_trouve(&components),
[INFO] [stderr] 79 |         "ENVOI" => parse_envoi(&components),
[INFO] [stderr] 80 |         "PENVOI" => parse_penvoi(&components),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/server/mod.rs:75:43
[INFO] [stderr]    |
[INFO] [stderr] 75 |     let request = match components.get(0).ok_or(err.clone())? {
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err.clone())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/dict/local_dict.rs:26:34
[INFO] [stderr]    |
[INFO] [stderr] 26 |         let f = File::open(file).expect(&format!("Cannot open file: {}", file));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot open file: {}", file))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/dict/local_dict.rs:29:35
[INFO] [stderr]    |
[INFO] [stderr] 29 |             .map(|l| unidecode(&l.expect(&format!("Error while reading dictionary: {}", file))))
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error while reading dictionary: {}", file))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:75:14
[INFO] [stderr]    |
[INFO] [stderr] 75 |         .map(|d| Duration::from_secs(d))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Duration::from_secs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:79:14
[INFO] [stderr]    |
[INFO] [stderr] 79 |         .map(|d| Duration::from_secs(d))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Duration::from_secs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/board/board.rs:134:51
[INFO] [stderr]     |
[INFO] [stderr] 134 |         self.player_words.entry(user.to_string()).or_insert(vec![])
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `boggle_server`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/board/board.rs:247:20
[INFO] [stderr]     |
[INFO] [stderr] 247 |         assert_eq!(board.player_words.get("user1").unwrap(), &expected);
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&board.player_words["user1"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/board/board.rs:295:20
[INFO] [stderr]     |
[INFO] [stderr] 295 |         assert_eq!(board.scores.get("user1").unwrap(), &(0 as u32));
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&board.scores["user1"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/board/board.rs:297:20
[INFO] [stderr]     |
[INFO] [stderr] 297 |         assert_eq!(board.scores.get("user1").unwrap(), &(5 as u32));
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&board.scores["user1"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/game.rs:27:27
[INFO] [stderr]    |
[INFO] [stderr] 27 |             turn_running: Mutex::new(false),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/game.rs:45:27
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let mut running = self.turn_running.lock().unwrap();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/game.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         stream.write(welcome_str.as_bytes()).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/game.rs:89:27
[INFO] [stderr]    |
[INFO] [stderr] 89 |         let mut running = self.turn_running.lock().unwrap();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/game.rs:96:10
[INFO] [stderr]    |
[INFO] [stderr] 96 |         *self.turn_running.lock().unwrap() = false;
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/game.rs:227:10
[INFO] [stderr]     |
[INFO] [stderr] 227 |         *game.turn_running.lock().unwrap() = true;
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/players.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 |         stream.write(format!("PRECEPTION/{}/{}/\n", msg, send).as_bytes()).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/players.rs:121:22
[INFO] [stderr]     |
[INFO] [stderr] 121 |         let actual = users.keys().map(|s| s.clone()).collect::<HashSet<String>>();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `users.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/players.rs:154:28
[INFO] [stderr]     |
[INFO] [stderr] 154 |         let user2_stream = players.players.get("user2").unwrap();
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&players.players["user2"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/players.rs:179:47
[INFO] [stderr]     |
[INFO] [stderr] 179 |         let streams = add_users(&mut players, &vec!["user1", "user2", "user3"]);
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["user1", "user2", "user3"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/log.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 | /         match self {
[INFO] [stderr] 49 | |             &LogMsg::Login(ref name) => write!(f, "{} vient de se connecter.", name),
[INFO] [stderr] 50 | |             &LogMsg::Logout(ref name) => write!(f, "{} vient de se déconnecter.", name),
[INFO] [stderr] 51 | |             &LogMsg::Accepted(ref name, ref word) => write!(f, "Le mot {} soumis par {} a été accepté.", word, name),
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |             &LogMsg::SessionEnd => write!(f, "Fin de la session."),
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 48 |         match *self {
[INFO] [stderr] 49 |             LogMsg::Login(ref name) => write!(f, "{} vient de se connecter.", name),
[INFO] [stderr] 50 |             LogMsg::Logout(ref name) => write!(f, "{} vient de se déconnecter.", name),
[INFO] [stderr] 51 |             LogMsg::Accepted(ref name, ref word) => write!(f, "Le mot {} soumis par {} a été accepté.", word, name),
[INFO] [stderr] 52 |             LogMsg::Error(ref e) => write!(f, "Erreur: {}", e),
[INFO] [stderr] 53 |             LogMsg::MessageSent(ref s, ref r, ref m) =>
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/server/server.rs:30:25
[INFO] [stderr]    |
[INFO] [stderr] 30 |             nb_players: Mutex::new(0),
[INFO] [stderr]    |                         ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/server/server.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         self.nb_players.lock().unwrap().clone()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.nb_players.lock().unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/server/server.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         self.nb_players.lock().unwrap().clone()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/server/server.rs:117:61
[INFO] [stderr]     |
[INFO] [stderr] 117 |             .map(|_|  { self.log(LogMsg::login(username)); *self.nb_players.lock().unwrap() += 1 })
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/server/server.rs:124:14
[INFO] [stderr]     |
[INFO] [stderr] 124 |             *self.nb_players.lock().unwrap() -= 1;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/server/server.rs:137:21
[INFO] [stderr]     |
[INFO] [stderr] 137 | /                     writer.write(format!("MVALIDE/{}/\n", word).as_bytes())
[INFO] [stderr] 138 | |                         .expect("Cannot write response");
[INFO] [stderr]     | |________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/server/server.rs:145:21
[INFO] [stderr]     |
[INFO] [stderr] 145 | /                     writer.write(format!("MINVALIDE/{}/\n", msg).as_bytes())
[INFO] [stderr] 146 | |                         .expect("Cannot write response");
[INFO] [stderr]     | |________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/server/mod.rs:72:43
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let components: Vec<&str> = req.split("/").collect();
[INFO] [stderr]    |                                           ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/server/mod.rs:75:19
[INFO] [stderr]    |
[INFO] [stderr] 75 |       let request = match components.get(0).ok_or(err.clone())? {
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 76 | |         &"CONNEXION" => parse_connexion(&components),
[INFO] [stderr] 77 | |         &"SORT" => parse_sort(&components),
[INFO] [stderr] 78 | |         &"TROUVE" => parse_trouve(&components),
[INFO] [stderr] ...  |
[INFO] [stderr] 81 | |         _ => Err(())
[INFO] [stderr] 82 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 75 |     let request = match *(components.get(0).ok_or(err.clone())?) {
[INFO] [stderr] 76 |         "CONNEXION" => parse_connexion(&components),
[INFO] [stderr] 77 |         "SORT" => parse_sort(&components),
[INFO] [stderr] 78 |         "TROUVE" => parse_trouve(&components),
[INFO] [stderr] 79 |         "ENVOI" => parse_envoi(&components),
[INFO] [stderr] 80 |         "PENVOI" => parse_penvoi(&components),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/server/mod.rs:75:43
[INFO] [stderr]    |
[INFO] [stderr] 75 |     let request = match components.get(0).ok_or(err.clone())? {
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err.clone())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/dict/local_dict.rs:26:34
[INFO] [stderr]    |
[INFO] [stderr] 26 |         let f = File::open(file).expect(&format!("Cannot open file: {}", file));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot open file: {}", file))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/dict/local_dict.rs:29:35
[INFO] [stderr]    |
[INFO] [stderr] 29 |             .map(|l| unidecode(&l.expect(&format!("Error while reading dictionary: {}", file))))
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error while reading dictionary: {}", file))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:75:14
[INFO] [stderr]    |
[INFO] [stderr] 75 |         .map(|d| Duration::from_secs(d))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Duration::from_secs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:79:14
[INFO] [stderr]    |
[INFO] [stderr] 79 |         .map(|d| Duration::from_secs(d))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Duration::from_secs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `boggle_server`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "6475964fdfa964b4272b616033491d68cec4e4337cd5348a99523d8f9e718dfa"`
[INFO] running `"docker" "rm" "-f" "6475964fdfa964b4272b616033491d68cec4e4337cd5348a99523d8f9e718dfa"`
[INFO] [stdout] 6475964fdfa964b4272b616033491d68cec4e4337cd5348a99523d8f9e718dfa