[INFO] updating cached repository geniousli/point24 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/geniousli/point24 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/geniousli/point24" "work/ex/clippy-test-run/sources/stable/gh/geniousli/point24"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/geniousli/point24'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/geniousli/point24" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geniousli/point24"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geniousli/point24'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bdd44978d11cf3cf4906c1e5d7c60edba70a9b6a [INFO] sha for GitHub repo geniousli/point24: bdd44978d11cf3cf4906c1e5d7c60edba70a9b6a [INFO] validating manifest of geniousli/point24 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of geniousli/point24 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing geniousli/point24 [INFO] finished frobbing geniousli/point24 [INFO] frobbed toml for geniousli/point24 written to work/ex/clippy-test-run/sources/stable/gh/geniousli/point24/Cargo.toml [INFO] started frobbing geniousli/point24 [INFO] finished frobbing geniousli/point24 [INFO] frobbed toml for geniousli/point24 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geniousli/point24/Cargo.toml [INFO] crate geniousli/point24 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting geniousli/point24 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/geniousli/point24:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a911b230bc16cad3781b13878346d3410fe966002044a0ca94f7c2295d8bbd15 [INFO] running `"docker" "start" "-a" "a911b230bc16cad3781b13878346d3410fe966002044a0ca94f7c2295d8bbd15"` [INFO] [stderr] Checking point24 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/lru.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | cap: cap, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/lru.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/lru.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem/point.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | vec: vec, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/lru.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | cap: cap, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/lru.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/lru.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem/point.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | vec: vec, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/algorithm/heap.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 36 | | if left_value > right_value { [INFO] [stderr] 37 | | swap(&mut ary, left, index); [INFO] [stderr] 38 | | rebuild_heap(&mut ary, left, size); [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | } else if left_value > right_value { [INFO] [stderr] 36 | swap(&mut ary, left, index); [INFO] [stderr] 37 | rebuild_heap(&mut ary, left, size); [INFO] [stderr] 38 | } else if right_value > mid_value { [INFO] [stderr] 39 | swap(&mut ary, right, index); [INFO] [stderr] 40 | rebuild_heap(&mut ary, right, size); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::FromStr` [INFO] [stderr] --> src/algorithm/lru.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::str::FromStr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `thread`, `time` [INFO] [stderr] --> src/algorithm/lru.rs:8:11 [INFO] [stderr] | [INFO] [stderr] 8 | use std::{thread, time}; [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::Iterator` [INFO] [stderr] --> src/algorithm/lru.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::iter::Iterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/algorithm/lru.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | Some(data) => {} [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/problem/mod.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let mut iter = SelfIter { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/algorithm/heap.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 36 | | if left_value > right_value { [INFO] [stderr] 37 | | swap(&mut ary, left, index); [INFO] [stderr] 38 | | rebuild_heap(&mut ary, left, size); [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | } else if left_value > right_value { [INFO] [stderr] 36 | swap(&mut ary, left, index); [INFO] [stderr] 37 | rebuild_heap(&mut ary, left, size); [INFO] [stderr] 38 | } else if right_value > mid_value { [INFO] [stderr] 39 | swap(&mut ary, right, index); [INFO] [stderr] 40 | rebuild_heap(&mut ary, right, size); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::FromStr` [INFO] [stderr] --> src/algorithm/lru.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::str::FromStr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `thread`, `time` [INFO] [stderr] --> src/algorithm/lru.rs:8:11 [INFO] [stderr] | [INFO] [stderr] 8 | use std::{thread, time}; [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `ary` manually [INFO] [stderr] --> src/algorithm/heap.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / let a_value = ary[a]; [INFO] [stderr] 61 | | ary[a] = ary[b]; [INFO] [stderr] 62 | | ary[b] = a_value; [INFO] [stderr] | |____________________^ help: try: `ary.swap(a, b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/algorithm/lru.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | drop(tail_rc); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &std::rc::Rc>> [INFO] [stderr] --> src/algorithm/lru.rs:73:30 [INFO] [stderr] | [INFO] [stderr] 73 | drop(tail_rc); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/problem/point.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | .map(|(_, val)| val.clone()) [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `point24`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `std::iter::Iterator` [INFO] [stderr] --> src/algorithm/lru.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::iter::Iterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/algorithm/lru.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | Some(data) => {} [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/problem/mod.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let mut iter = SelfIter { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `ary` manually [INFO] [stderr] --> src/algorithm/heap.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / let a_value = ary[a]; [INFO] [stderr] 61 | | ary[a] = ary[b]; [INFO] [stderr] 62 | | ary[b] = a_value; [INFO] [stderr] | |____________________^ help: try: `ary.swap(a, b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/algorithm/lru.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | drop(tail_rc); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &std::rc::Rc>> [INFO] [stderr] --> src/algorithm/lru.rs:73:30 [INFO] [stderr] | [INFO] [stderr] 73 | drop(tail_rc); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/problem/point.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | .map(|(_, val)| val.clone()) [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `point24`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a911b230bc16cad3781b13878346d3410fe966002044a0ca94f7c2295d8bbd15"` [INFO] running `"docker" "rm" "-f" "a911b230bc16cad3781b13878346d3410fe966002044a0ca94f7c2295d8bbd15"` [INFO] [stdout] a911b230bc16cad3781b13878346d3410fe966002044a0ca94f7c2295d8bbd15