[INFO] updating cached repository geniousli/bing_saver_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/geniousli/bing_saver_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/geniousli/bing_saver_rs" "work/ex/clippy-test-run/sources/stable/gh/geniousli/bing_saver_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/geniousli/bing_saver_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/geniousli/bing_saver_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geniousli/bing_saver_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geniousli/bing_saver_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] db6de554826fcccd979061a2157baca17d6c438d [INFO] sha for GitHub repo geniousli/bing_saver_rs: db6de554826fcccd979061a2157baca17d6c438d [INFO] validating manifest of geniousli/bing_saver_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of geniousli/bing_saver_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing geniousli/bing_saver_rs [INFO] finished frobbing geniousli/bing_saver_rs [INFO] frobbed toml for geniousli/bing_saver_rs written to work/ex/clippy-test-run/sources/stable/gh/geniousli/bing_saver_rs/Cargo.toml [INFO] started frobbing geniousli/bing_saver_rs [INFO] finished frobbing geniousli/bing_saver_rs [INFO] frobbed toml for geniousli/bing_saver_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geniousli/bing_saver_rs/Cargo.toml [INFO] crate geniousli/bing_saver_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting geniousli/bing_saver_rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/geniousli/bing_saver_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b55c5e93536b2485c780565b3bf513aacd2bdcc3c4615af059de1a450f752fd [INFO] running `"docker" "start" "-a" "4b55c5e93536b2485c780565b3bf513aacd2bdcc3c4615af059de1a450f752fd"` [INFO] [stderr] Checking victoria-dom v0.1.2 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking bing_saver_rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> src/main.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | use std::time::{Duration, SystemTime}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::rt::spawn` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use hyper::rt::spawn; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::Chunk` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use hyper::Chunk; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/main.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | use serde_json::{Error, Value}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `victoria_dom::DOM` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use victoria_dom::DOM; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Error` [INFO] [stderr] --> src/main.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | use std::fmt::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> src/main.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | use std::time::{Duration, SystemTime}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::rt::spawn` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use hyper::rt::spawn; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::Chunk` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use hyper::Chunk; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/main.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | use serde_json::{Error, Value}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `victoria_dom::DOM` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use victoria_dom::DOM; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Error` [INFO] [stderr] --> src/main.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | use std::fmt::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/main.rs:181:37 [INFO] [stderr] | [INFO] [stderr] 181 | let f = join_all(ary).and_then(|data| Ok(())); [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pic_url` [INFO] [stderr] --> src/main.rs:110:37 [INFO] [stderr] | [INFO] [stderr] 110 | let pic_url = format!("{}{}", HOSTURL, url); [INFO] [stderr] | ^^^^^^^ help: consider using `_pic_url` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:114:39 [INFO] [stderr] | [INFO] [stderr] 114 | .map_err(|err| println!("errors -")); [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/main.rs:181:37 [INFO] [stderr] | [INFO] [stderr] 181 | let f = join_all(ary).and_then(|data| Ok(())); [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pic_url` [INFO] [stderr] --> src/main.rs:110:37 [INFO] [stderr] | [INFO] [stderr] 110 | let pic_url = format!("{}{}", HOSTURL, url); [INFO] [stderr] | ^^^^^^^ help: consider using `_pic_url` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:114:39 [INFO] [stderr] | [INFO] [stderr] 114 | .map_err(|err| println!("errors -")); [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `BingDownloadPic` [INFO] [stderr] --> src/main.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | struct BingDownloadPic { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `download_img` [INFO] [stderr] --> src/main.rs:185:1 [INFO] [stderr] | [INFO] [stderr] 185 | fn download_img(url: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/main.rs:79:15 [INFO] [stderr] | [INFO] [stderr] 79 | pic_urls: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:158:43 [INFO] [stderr] | [INFO] [stderr] 158 | let url_split = url.split("/").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | file.write_all(&body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:211:39 [INFO] [stderr] | [INFO] [stderr] 211 | let url_split = url.split("/").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:218:21 [INFO] [stderr] | [INFO] [stderr] 218 | file.write_all(&body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `BingDownloadPic` [INFO] [stderr] --> src/main.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | struct BingDownloadPic { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `download_img` [INFO] [stderr] --> src/main.rs:185:1 [INFO] [stderr] | [INFO] [stderr] 185 | fn download_img(url: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/main.rs:79:15 [INFO] [stderr] | [INFO] [stderr] 79 | pic_urls: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:158:43 [INFO] [stderr] | [INFO] [stderr] 158 | let url_split = url.split("/").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | file.write_all(&body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:211:39 [INFO] [stderr] | [INFO] [stderr] 211 | let url_split = url.split("/").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:218:21 [INFO] [stderr] | [INFO] [stderr] 218 | file.write_all(&body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.72s [INFO] running `"docker" "inspect" "4b55c5e93536b2485c780565b3bf513aacd2bdcc3c4615af059de1a450f752fd"` [INFO] running `"docker" "rm" "-f" "4b55c5e93536b2485c780565b3bf513aacd2bdcc3c4615af059de1a450f752fd"` [INFO] [stdout] 4b55c5e93536b2485c780565b3bf513aacd2bdcc3c4615af059de1a450f752fd