[INFO] updating cached repository generalproxy/rustoxy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/generalproxy/rustoxy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/generalproxy/rustoxy" "work/ex/clippy-test-run/sources/stable/gh/generalproxy/rustoxy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/generalproxy/rustoxy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/generalproxy/rustoxy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/generalproxy/rustoxy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/generalproxy/rustoxy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bb39b38f18352797ae54efc63ed519eef3b3e1d5 [INFO] sha for GitHub repo generalproxy/rustoxy: bb39b38f18352797ae54efc63ed519eef3b3e1d5 [INFO] validating manifest of generalproxy/rustoxy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of generalproxy/rustoxy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing generalproxy/rustoxy [INFO] finished frobbing generalproxy/rustoxy [INFO] frobbed toml for generalproxy/rustoxy written to work/ex/clippy-test-run/sources/stable/gh/generalproxy/rustoxy/Cargo.toml [INFO] started frobbing generalproxy/rustoxy [INFO] finished frobbing generalproxy/rustoxy [INFO] frobbed toml for generalproxy/rustoxy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/generalproxy/rustoxy/Cargo.toml [INFO] crate generalproxy/rustoxy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting generalproxy/rustoxy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/generalproxy/rustoxy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a9d5588f5bd7a5cb0cc8a0de3f38a696d0dc447c6941732614ad63c786496a1c [INFO] running `"docker" "start" "-a" "a9d5588f5bd7a5cb0cc8a0de3f38a696d0dc447c6941732614ad63c786496a1c"` [INFO] [stderr] Checking atty v0.2.9 [INFO] [stderr] Checking env_logger v0.5.9 [INFO] [stderr] Checking rustoxy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/client.rs:218:21 [INFO] [stderr] | [INFO] [stderr] 218 | let e = ((buf[8] as u16) << 8) | (buf[9] as u16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/client.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let f = ((buf[10] as u16) << 8) | (buf[11] as u16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/client.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | let g = ((buf[12] as u16) << 8) | (buf[13] as u16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/client.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | let h = ((buf[14] as u16) << 8) | (buf[15] as u16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/client.rs:218:21 [INFO] [stderr] | [INFO] [stderr] 218 | let e = ((buf[8] as u16) << 8) | (buf[9] as u16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/client.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let f = ((buf[10] as u16) << 8) | (buf[11] as u16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/client.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | let g = ((buf[12] as u16) << 8) | (buf[13] as u16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/client.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | let h = ((buf[14] as u16) << 8) | (buf[15] as u16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/client.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/client.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | let result = pair.and_then(|(c1, c2)| [INFO] [stderr] | ______________________^ [INFO] [stderr] 149 | | transfer(new_tcpendpoint(c1), new_tcpendpoint(c2))); [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/client.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/client.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | let result = pair.and_then(|(c1, c2)| [INFO] [stderr] | ______________________^ [INFO] [stderr] 149 | | transfer(new_tcpendpoint(c1), new_tcpendpoint(c2))); [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:204:29 [INFO] [stderr] | [INFO] [stderr] 204 | let port = ((buf[4] as u16) << 8) | (buf[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:204:53 [INFO] [stderr] | [INFO] [stderr] 204 | let port = ((buf[4] as u16) << 8) | (buf[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:214:26 [INFO] [stderr] | [INFO] [stderr] 214 | let a = ((buf[0] as u16) << 8) | (buf[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:214:50 [INFO] [stderr] | [INFO] [stderr] 214 | let a = ((buf[0] as u16) << 8) | (buf[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:215:26 [INFO] [stderr] | [INFO] [stderr] 215 | let b = ((buf[2] as u16) << 8) | (buf[3] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:215:50 [INFO] [stderr] | [INFO] [stderr] 215 | let b = ((buf[2] as u16) << 8) | (buf[3] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:216:26 [INFO] [stderr] | [INFO] [stderr] 216 | let c = ((buf[4] as u16) << 8) | (buf[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:216:50 [INFO] [stderr] | [INFO] [stderr] 216 | let c = ((buf[4] as u16) << 8) | (buf[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:217:26 [INFO] [stderr] | [INFO] [stderr] 217 | let d = ((buf[6] as u16) << 8) | (buf[7] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:217:50 [INFO] [stderr] | [INFO] [stderr] 217 | let d = ((buf[6] as u16) << 8) | (buf[7] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:218:26 [INFO] [stderr] | [INFO] [stderr] 218 | let e = ((buf[8] as u16) << 8) | (buf[9] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:218:50 [INFO] [stderr] | [INFO] [stderr] 218 | let e = ((buf[8] as u16) << 8) | (buf[9] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:219:26 [INFO] [stderr] | [INFO] [stderr] 219 | let f = ((buf[10] as u16) << 8) | (buf[11] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:219:51 [INFO] [stderr] | [INFO] [stderr] 219 | let f = ((buf[10] as u16) << 8) | (buf[11] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[11])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:220:26 [INFO] [stderr] | [INFO] [stderr] 220 | let g = ((buf[12] as u16) << 8) | (buf[13] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[12])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:220:51 [INFO] [stderr] | [INFO] [stderr] 220 | let g = ((buf[12] as u16) << 8) | (buf[13] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[13])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:221:26 [INFO] [stderr] | [INFO] [stderr] 221 | let h = ((buf[14] as u16) << 8) | (buf[15] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[14])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:221:51 [INFO] [stderr] | [INFO] [stderr] 221 | let h = ((buf[14] as u16) << 8) | (buf[15] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[15])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:223:29 [INFO] [stderr] | [INFO] [stderr] 223 | let port = ((buf[16] as u16) << 8) | (buf[17] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:223:54 [INFO] [stderr] | [INFO] [stderr] 223 | let port = ((buf[16] as u16) << 8) | (buf[17] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[17])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | let port = ((addr_buf[pos] as u16) << 8) | (addr_buf[pos + 1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(addr_buf[pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:47:48 [INFO] [stderr] | [INFO] [stderr] 47 | let port = ((addr_buf[pos] as u16) << 8) | (addr_buf[pos + 1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(addr_buf[pos + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/endpoint.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | if buf.len()==0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | drop(env_logger::init()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type () [INFO] [stderr] --> src/main.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | drop(env_logger::init()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | drop(env_logger::init()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 67 | drop(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:71:35 [INFO] [stderr] | [INFO] [stderr] 71 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8083".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8083".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustoxy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:204:29 [INFO] [stderr] | [INFO] [stderr] 204 | let port = ((buf[4] as u16) << 8) | (buf[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:204:53 [INFO] [stderr] | [INFO] [stderr] 204 | let port = ((buf[4] as u16) << 8) | (buf[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:214:26 [INFO] [stderr] | [INFO] [stderr] 214 | let a = ((buf[0] as u16) << 8) | (buf[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:214:50 [INFO] [stderr] | [INFO] [stderr] 214 | let a = ((buf[0] as u16) << 8) | (buf[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:215:26 [INFO] [stderr] | [INFO] [stderr] 215 | let b = ((buf[2] as u16) << 8) | (buf[3] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:215:50 [INFO] [stderr] | [INFO] [stderr] 215 | let b = ((buf[2] as u16) << 8) | (buf[3] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:216:26 [INFO] [stderr] | [INFO] [stderr] 216 | let c = ((buf[4] as u16) << 8) | (buf[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:216:50 [INFO] [stderr] | [INFO] [stderr] 216 | let c = ((buf[4] as u16) << 8) | (buf[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:217:26 [INFO] [stderr] | [INFO] [stderr] 217 | let d = ((buf[6] as u16) << 8) | (buf[7] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:217:50 [INFO] [stderr] | [INFO] [stderr] 217 | let d = ((buf[6] as u16) << 8) | (buf[7] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:218:26 [INFO] [stderr] | [INFO] [stderr] 218 | let e = ((buf[8] as u16) << 8) | (buf[9] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:218:50 [INFO] [stderr] | [INFO] [stderr] 218 | let e = ((buf[8] as u16) << 8) | (buf[9] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:219:26 [INFO] [stderr] | [INFO] [stderr] 219 | let f = ((buf[10] as u16) << 8) | (buf[11] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:219:51 [INFO] [stderr] | [INFO] [stderr] 219 | let f = ((buf[10] as u16) << 8) | (buf[11] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[11])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:220:26 [INFO] [stderr] | [INFO] [stderr] 220 | let g = ((buf[12] as u16) << 8) | (buf[13] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[12])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:220:51 [INFO] [stderr] | [INFO] [stderr] 220 | let g = ((buf[12] as u16) << 8) | (buf[13] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[13])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:221:26 [INFO] [stderr] | [INFO] [stderr] 221 | let h = ((buf[14] as u16) << 8) | (buf[15] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[14])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:221:51 [INFO] [stderr] | [INFO] [stderr] 221 | let h = ((buf[14] as u16) << 8) | (buf[15] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[15])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:223:29 [INFO] [stderr] | [INFO] [stderr] 223 | let port = ((buf[16] as u16) << 8) | (buf[17] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:223:54 [INFO] [stderr] | [INFO] [stderr] 223 | let port = ((buf[16] as u16) << 8) | (buf[17] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[17])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | let port = ((addr_buf[pos] as u16) << 8) | (addr_buf[pos + 1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(addr_buf[pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:47:48 [INFO] [stderr] | [INFO] [stderr] 47 | let port = ((addr_buf[pos] as u16) << 8) | (addr_buf[pos + 1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(addr_buf[pos + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/endpoint.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | if buf.len()==0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | drop(env_logger::init()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type () [INFO] [stderr] --> src/main.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | drop(env_logger::init()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | drop(env_logger::init()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 67 | drop(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:71:35 [INFO] [stderr] | [INFO] [stderr] 71 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8083".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8083".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustoxy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a9d5588f5bd7a5cb0cc8a0de3f38a696d0dc447c6941732614ad63c786496a1c"` [INFO] running `"docker" "rm" "-f" "a9d5588f5bd7a5cb0cc8a0de3f38a696d0dc447c6941732614ad63c786496a1c"` [INFO] [stdout] a9d5588f5bd7a5cb0cc8a0de3f38a696d0dc447c6941732614ad63c786496a1c