[INFO] updating cached repository geirmundsimonsen/rust-osc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/geirmundsimonsen/rust-osc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/geirmundsimonsen/rust-osc" "work/ex/clippy-test-run/sources/stable/gh/geirmundsimonsen/rust-osc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/geirmundsimonsen/rust-osc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/geirmundsimonsen/rust-osc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geirmundsimonsen/rust-osc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geirmundsimonsen/rust-osc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c6f9b536f458ba8c66f8e5fffbeb35461e18463 [INFO] sha for GitHub repo geirmundsimonsen/rust-osc: 8c6f9b536f458ba8c66f8e5fffbeb35461e18463 [INFO] validating manifest of geirmundsimonsen/rust-osc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of geirmundsimonsen/rust-osc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing geirmundsimonsen/rust-osc [INFO] finished frobbing geirmundsimonsen/rust-osc [INFO] frobbed toml for geirmundsimonsen/rust-osc written to work/ex/clippy-test-run/sources/stable/gh/geirmundsimonsen/rust-osc/Cargo.toml [INFO] started frobbing geirmundsimonsen/rust-osc [INFO] finished frobbing geirmundsimonsen/rust-osc [INFO] frobbed toml for geirmundsimonsen/rust-osc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geirmundsimonsen/rust-osc/Cargo.toml [INFO] crate geirmundsimonsen/rust-osc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting geirmundsimonsen/rust-osc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/geirmundsimonsen/rust-osc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdb486a8b95fff2ac25ae78b7005d679201a46f32e00730b5db0705e5c1d4a34 [INFO] running `"docker" "start" "-a" "fdb486a8b95fff2ac25ae78b7005d679201a46f32e00730b5db0705e5c1d4a34"` [INFO] [stderr] Checking osc2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:67:4 [INFO] [stderr] | [INFO] [stderr] 67 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:68:4 [INFO] [stderr] | [INFO] [stderr] 68 | typelist: typelist, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `typelist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:69:4 [INFO] [stderr] | [INFO] [stderr] 69 | typelist_start: typelist_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `typelist_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:152:24 [INFO] [stderr] | [INFO] [stderr] 152 | if count % 4 == 0 { println!("") } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:67:4 [INFO] [stderr] | [INFO] [stderr] 67 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:68:4 [INFO] [stderr] | [INFO] [stderr] 68 | typelist: typelist, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `typelist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:69:4 [INFO] [stderr] | [INFO] [stderr] 69 | typelist_start: typelist_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `typelist_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:152:24 [INFO] [stderr] | [INFO] [stderr] 152 | if count % 4 == 0 { println!("") } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused variable: `argNo` [INFO] [stderr] --> src/lib.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn change(argNo: u32) { [INFO] [stderr] | ^^^^^ help: consider using `_argNo` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `argNo` [INFO] [stderr] --> src/lib.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn remove(argNo: u32) { [INFO] [stderr] | ^^^^^ help: consider using `_argNo` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/lib.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn address(address: &str) { [INFO] [stderr] | ^^^^^^^ help: consider using `_address` instead [INFO] [stderr] [INFO] [stderr] warning: variable `argNo` should have a snake case name such as `arg_no` [INFO] [stderr] --> src/lib.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn change(argNo: u32) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `argNo` should have a snake case name such as `arg_no` [INFO] [stderr] --> src/lib.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn remove(argNo: u32) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method `removeAll` should have a snake case name such as `remove_all` [INFO] [stderr] --> src/lib.rs:116:2 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn removeAll() { [INFO] [stderr] | _____^ [INFO] [stderr] 117 | | [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in self.bytes.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:151:15 [INFO] [stderr] | [INFO] [stderr] 151 | for byte in self.bytes.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused variable: `argNo` [INFO] [stderr] --> src/lib.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn change(argNo: u32) { [INFO] [stderr] | ^^^^^ help: consider using `_argNo` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `argNo` [INFO] [stderr] --> src/lib.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn remove(argNo: u32) { [INFO] [stderr] | ^^^^^ help: consider using `_argNo` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/lib.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn address(address: &str) { [INFO] [stderr] | ^^^^^^^ help: consider using `_address` instead [INFO] [stderr] [INFO] [stderr] warning: variable `argNo` should have a snake case name such as `arg_no` [INFO] [stderr] --> src/lib.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn change(argNo: u32) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `argNo` should have a snake case name such as `arg_no` [INFO] [stderr] --> src/lib.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn remove(argNo: u32) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method `removeAll` should have a snake case name such as `remove_all` [INFO] [stderr] --> src/lib.rs:116:2 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn removeAll() { [INFO] [stderr] | _____^ [INFO] [stderr] 117 | | [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in self.bytes.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:151:15 [INFO] [stderr] | [INFO] [stderr] 151 | for byte in self.bytes.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | socket.send_to(msg.get_bytes(), "127.0.0.1:57120"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | socket.send_to(msg.get_bytes(), "127.0.0.1:57120"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.28s [INFO] running `"docker" "inspect" "fdb486a8b95fff2ac25ae78b7005d679201a46f32e00730b5db0705e5c1d4a34"` [INFO] running `"docker" "rm" "-f" "fdb486a8b95fff2ac25ae78b7005d679201a46f32e00730b5db0705e5c1d4a34"` [INFO] [stdout] fdb486a8b95fff2ac25ae78b7005d679201a46f32e00730b5db0705e5c1d4a34