[INFO] updating cached repository gefjon/zeldesque [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gefjon/zeldesque [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gefjon/zeldesque" "work/ex/clippy-test-run/sources/stable/gh/gefjon/zeldesque"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gefjon/zeldesque'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gefjon/zeldesque" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gefjon/zeldesque"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gefjon/zeldesque'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a004ae78401a514926200a35778c4d884658508e [INFO] sha for GitHub repo gefjon/zeldesque: a004ae78401a514926200a35778c4d884658508e [INFO] validating manifest of gefjon/zeldesque on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gefjon/zeldesque on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gefjon/zeldesque [INFO] finished frobbing gefjon/zeldesque [INFO] frobbed toml for gefjon/zeldesque written to work/ex/clippy-test-run/sources/stable/gh/gefjon/zeldesque/Cargo.toml [INFO] started frobbing gefjon/zeldesque [INFO] finished frobbing gefjon/zeldesque [INFO] frobbed toml for gefjon/zeldesque written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gefjon/zeldesque/Cargo.toml [INFO] crate gefjon/zeldesque has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gefjon/zeldesque against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gefjon/zeldesque:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 800e1f8ebfabe2c9352d752e80f8fd70c21da8c24875310ef75f22b7b886bdfc [INFO] running `"docker" "start" "-a" "800e1f8ebfabe2c9352d752e80f8fd70c21da8c24875310ef75f22b7b886bdfc"` [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.46.0 [INFO] [stderr] Checking pistoncore-window v0.28.0 [INFO] [stderr] Checking pistoncore-event_loop v0.33.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.39.0 [INFO] [stderr] Checking piston v0.33.0 [INFO] [stderr] Checking zeldesque v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `characters::Player` [INFO] [stderr] --> src/world.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use characters::Player; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `graphics::math::Matrix2d` [INFO] [stderr] --> src/other_entities.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use graphics::math::Matrix2d; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `opengl_graphics::GlGraphics` [INFO] [stderr] --> src/other_entities.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use opengl_graphics::GlGraphics; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `characters::Player` [INFO] [stderr] --> src/world.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use characters::Player; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `graphics::math::Matrix2d` [INFO] [stderr] --> src/other_entities.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use graphics::math::Matrix2d; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `opengl_graphics::GlGraphics` [INFO] [stderr] --> src/other_entities.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use opengl_graphics::GlGraphics; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/state/menu.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | _ => panic!("Bad menu entry!"), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/state/pause.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | _ => panic!("Bad menu entry!"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/world.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | _ => panic!("Bad state!"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/state/menu.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | _ => panic!("invalid menu option"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/state/pause.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | _ => panic!("Bad menu entry!"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/state/menu.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | _ => panic!("Bad menu entry!"), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/state/pause.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | _ => panic!("Bad menu entry!"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/world.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | _ => panic!("Bad state!"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/state/menu.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | _ => panic!("invalid menu option"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/state/pause.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | _ => panic!("Bad menu entry!"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `window_size` [INFO] [stderr] --> src/world.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | window_size: Vec2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_pos` [INFO] [stderr] --> src/coordinates.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn get_pos(&self) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_dimensions` [INFO] [stderr] --> src/coordinates.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn get_dimensions(&self) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `check_collision` [INFO] [stderr] --> src/coordinates.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn check_collision(a: Self, b: Self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RED` [INFO] [stderr] --> src/color.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const RED: RawColor = [1.0, 0.0, 0.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GREEN` [INFO] [stderr] --> src/color.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub const GREEN: RawColor = [0.0, 1.0, 0.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `LIGHT_GREY` [INFO] [stderr] --> src/color.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub const LIGHT_GREY: RawColor = [0.9, 0.9, 0.9]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FileStorage` [INFO] [stderr] --> src/asset_manager/texture_manager/texture_info.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | FileStorage(&'static Path), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_path` [INFO] [stderr] --> src/asset_manager/texture_manager/texture_info.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn from_path(path: &'static Path, width: u32, height: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Wall` [INFO] [stderr] --> src/other_entities.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | struct Wall { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/other_entities.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(sprite: Rc, pos: Vec2) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/world.rs:48:42 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn update_state(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | / match input { [INFO] [stderr] 123 | | Button(args) => { [INFO] [stderr] 124 | | self.keyboard.handle_keypress(&args); [INFO] [stderr] 125 | | self.button_events.push(args); [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | _ => (), [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | if let Button(args) = input { [INFO] [stderr] 123 | self.keyboard.handle_keypress(&args); [INFO] [stderr] 124 | self.button_events.push(args); [INFO] [stderr] 125 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `window_size` [INFO] [stderr] --> src/world.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | window_size: Vec2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_pos` [INFO] [stderr] --> src/coordinates.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn get_pos(&self) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_dimensions` [INFO] [stderr] --> src/coordinates.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn get_dimensions(&self) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/state/menu.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | / match event.state { [INFO] [stderr] 127 | | Press => if let Some(s) = self.key_pressed(key) { [INFO] [stderr] 128 | | return Some(s); [INFO] [stderr] 129 | | }, [INFO] [stderr] 130 | | _ => (), [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: method is never used: `check_collision` [INFO] [stderr] --> src/coordinates.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn check_collision(a: Self, b: Self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RED` [INFO] [stderr] --> src/color.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const RED: RawColor = [1.0, 0.0, 0.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GREEN` [INFO] [stderr] --> src/color.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub const GREEN: RawColor = [0.0, 1.0, 0.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] warning: constant item is never used: `LIGHT_GREY` [INFO] [stderr] --> src/color.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub const LIGHT_GREY: RawColor = [0.9, 0.9, 0.9]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 126 | if let Press = event.state { if let Some(s) = self.key_pressed(key) { [INFO] [stderr] 127 | return Some(s); [INFO] [stderr] 128 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FileStorage` [INFO] [stderr] --> src/asset_manager/texture_manager/texture_info.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | FileStorage(&'static Path), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_path` [INFO] [stderr] --> src/asset_manager/texture_manager/texture_info.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn from_path(path: &'static Path, width: u32, height: u32) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Wall` [INFO] [stderr] --> src/other_entities.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | struct Wall { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/other_entities.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(sprite: Rc, pos: Vec2) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/world.rs:48:42 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn update_state(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/state/pause.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | / match event.state { [INFO] [stderr] 135 | | Press => if let Some(s) = self.key_pressed(key) { [INFO] [stderr] 136 | | return Some(s); [INFO] [stderr] 137 | | }, [INFO] [stderr] 138 | | _ => (), [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 134 | if let Press = event.state { if let Some(s) = self.key_pressed(key) { [INFO] [stderr] 135 | return Some(s); [INFO] [stderr] 136 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state/mod.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | args: &UpdateArgs, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | / match input { [INFO] [stderr] 123 | | Button(args) => { [INFO] [stderr] 124 | | self.keyboard.handle_keypress(&args); [INFO] [stderr] 125 | | self.button_events.push(args); [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | _ => (), [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | if let Button(args) = input { [INFO] [stderr] 123 | self.keyboard.handle_keypress(&args); [INFO] [stderr] 124 | self.button_events.push(args); [INFO] [stderr] 125 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/characters.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | let my_trans = transform [INFO] [stderr] | ________________________^ [INFO] [stderr] 21 | | .clone() [INFO] [stderr] | |____________________^ help: try removing the `clone` call: `transform` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/characters.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | width: width as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/characters.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | height: height as _, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/other_entities.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | width: width as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/other_entities.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | height: height as _, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/state/menu.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | / match event.state { [INFO] [stderr] 127 | | Press => if let Some(s) = self.key_pressed(key) { [INFO] [stderr] 128 | | return Some(s); [INFO] [stderr] 129 | | }, [INFO] [stderr] 130 | | _ => (), [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 126 | if let Press = event.state { if let Some(s) = self.key_pressed(key) { [INFO] [stderr] 127 | return Some(s); [INFO] [stderr] 128 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/state/pause.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | / match event.state { [INFO] [stderr] 135 | | Press => if let Some(s) = self.key_pressed(key) { [INFO] [stderr] 136 | | return Some(s); [INFO] [stderr] 137 | | }, [INFO] [stderr] 138 | | _ => (), [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 134 | if let Press = event.state { if let Some(s) = self.key_pressed(key) { [INFO] [stderr] 135 | return Some(s); [INFO] [stderr] 136 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state/mod.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | args: &UpdateArgs, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/characters.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | let my_trans = transform [INFO] [stderr] | ________________________^ [INFO] [stderr] 21 | | .clone() [INFO] [stderr] | |____________________^ help: try removing the `clone` call: `transform` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/characters.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | width: width as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/characters.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | height: height as _, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/other_entities.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | width: width as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/other_entities.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | height: height as _, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.28s [INFO] running `"docker" "inspect" "800e1f8ebfabe2c9352d752e80f8fd70c21da8c24875310ef75f22b7b886bdfc"` [INFO] running `"docker" "rm" "-f" "800e1f8ebfabe2c9352d752e80f8fd70c21da8c24875310ef75f22b7b886bdfc"` [INFO] [stdout] 800e1f8ebfabe2c9352d752e80f8fd70c21da8c24875310ef75f22b7b886bdfc