[INFO] updating cached repository geekingfrog/advent-of-code-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/geekingfrog/advent-of-code-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/geekingfrog/advent-of-code-rust" "work/ex/clippy-test-run/sources/stable/gh/geekingfrog/advent-of-code-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/geekingfrog/advent-of-code-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/geekingfrog/advent-of-code-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geekingfrog/advent-of-code-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geekingfrog/advent-of-code-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1dc93df4e78e7a44d30c5770af6586bd6a90f583 [INFO] sha for GitHub repo geekingfrog/advent-of-code-rust: 1dc93df4e78e7a44d30c5770af6586bd6a90f583 [INFO] validating manifest of geekingfrog/advent-of-code-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of geekingfrog/advent-of-code-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing geekingfrog/advent-of-code-rust [INFO] finished frobbing geekingfrog/advent-of-code-rust [INFO] frobbed toml for geekingfrog/advent-of-code-rust written to work/ex/clippy-test-run/sources/stable/gh/geekingfrog/advent-of-code-rust/Cargo.toml [INFO] started frobbing geekingfrog/advent-of-code-rust [INFO] finished frobbing geekingfrog/advent-of-code-rust [INFO] frobbed toml for geekingfrog/advent-of-code-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/geekingfrog/advent-of-code-rust/Cargo.toml [INFO] crate geekingfrog/advent-of-code-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting geekingfrog/advent-of-code-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/geekingfrog/advent-of-code-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf81b18557766b4446adb69f1463b829a65f56517db3641f6781eecca3636489 [INFO] running `"docker" "start" "-a" "bf81b18557766b4446adb69f1463b829a65f56517db3641f6781eecca3636489"` [INFO] [stderr] Checking aoc-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/y2018/day02.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / m.values() [INFO] [stderr] 55 | | .find(|v| *v == &x) [INFO] [stderr] 56 | | .is_some() [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|v| *v == &x).is_some()` with `any(|v| *v == &x)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/y2018/day02.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | fn common_letters(x: &String, y: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/y2018/day02.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | fn common_letters(x: &String, y: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/y2018/day02.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / m.values() [INFO] [stderr] 55 | | .find(|v| *v == &x) [INFO] [stderr] 56 | | .is_some() [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|v| *v == &x).is_some()` with `any(|v| *v == &x)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/y2018/day02.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | fn common_letters(x: &String, y: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/y2018/day02.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | fn common_letters(x: &String, y: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `"docker" "inspect" "bf81b18557766b4446adb69f1463b829a65f56517db3641f6781eecca3636489"` [INFO] running `"docker" "rm" "-f" "bf81b18557766b4446adb69f1463b829a65f56517db3641f6781eecca3636489"` [INFO] [stdout] bf81b18557766b4446adb69f1463b829a65f56517db3641f6781eecca3636489