[INFO] updating cached repository gdunton/rust-gb [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gdunton/rust-gb [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gdunton/rust-gb" "work/ex/clippy-test-run/sources/stable/gh/gdunton/rust-gb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gdunton/rust-gb'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gdunton/rust-gb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gdunton/rust-gb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gdunton/rust-gb'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] acd7a4db53140e5ab0c3bcae9e542fec1702c7db [INFO] sha for GitHub repo gdunton/rust-gb: acd7a4db53140e5ab0c3bcae9e542fec1702c7db [INFO] validating manifest of gdunton/rust-gb on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gdunton/rust-gb on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gdunton/rust-gb [INFO] finished frobbing gdunton/rust-gb [INFO] frobbed toml for gdunton/rust-gb written to work/ex/clippy-test-run/sources/stable/gh/gdunton/rust-gb/Cargo.toml [INFO] started frobbing gdunton/rust-gb [INFO] finished frobbing gdunton/rust-gb [INFO] frobbed toml for gdunton/rust-gb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gdunton/rust-gb/Cargo.toml [INFO] crate gdunton/rust-gb has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gdunton/rust-gb against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gdunton/rust-gb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 621559fd41cbf5f9eabe5a4686e50ce04c837e27bcdc3c0c37e617c65f5e4c4d [INFO] running `"docker" "start" "-a" "621559fd41cbf5f9eabe5a4686e50ce04c837e27bcdc3c0c37e617c65f5e4c4d"` [INFO] [stderr] Compiling wayland-scanner v0.21.4 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking wayland-sys v0.21.4 [INFO] [stderr] Checking wayland-commons v0.21.4 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking andrew v0.1.4 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Compiling wayland-client v0.21.4 [INFO] [stderr] Compiling wayland-protocols v0.21.4 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking smithay-client-toolkit v0.4.2 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.57.0 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking rust-gb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/gameboy/opcode_library.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | JumpArgument(JumpCondition), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gameboy/mod.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | flag_data [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gameboy/mod.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | let flag_data = flags [INFO] [stderr] | _________________________^ [INFO] [stderr] 94 | | .iter() [INFO] [stderr] 95 | | .map(|f| (format!("{:?}", f), f)) [INFO] [stderr] 96 | | .map(|(label, flag)| { [INFO] [stderr] ... | [INFO] [stderr] 105 | | .map(|(label, text)| format!("{}: {}", label, text)) [INFO] [stderr] 106 | | .collect::>(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/gameboy/opcode_library.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | JumpArgument(JumpCondition), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gameboy/mod.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | flag_data [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gameboy/mod.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | let flag_data = flags [INFO] [stderr] | _________________________^ [INFO] [stderr] 94 | | .iter() [INFO] [stderr] 95 | | .map(|f| (format!("{:?}", f), f)) [INFO] [stderr] 96 | | .map(|(label, flag)| { [INFO] [stderr] ... | [INFO] [stderr] 105 | | .map(|(label, text)| format!("{}: {}", label, text)) [INFO] [stderr] 106 | | .collect::>(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_registers` [INFO] [stderr] --> src/gameboy/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn get_registers(&self) -> Vec<&String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gameboy/opcode_library.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | / match self.args[0] { [INFO] [stderr] 114 | | Argument::RegisterIndirectDec(register) => { [INFO] [stderr] 115 | | let new_val = cpu.read_16_bits(register) - 1; [INFO] [stderr] 116 | | cpu.write_16_bits(register, new_val); [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | _ => {} // Do nothing [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | if let Argument::RegisterIndirectDec(register) = self.args[0] { [INFO] [stderr] 114 | let new_val = cpu.read_16_bits(register) - 1; [INFO] [stderr] 115 | cpu.write_16_bits(register, new_val); [INFO] [stderr] 116 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/gameboy/opcode_library.rs:163:51 [INFO] [stderr] | [INFO] [stderr] 163 | JumpCondition::NotZero => read_flag::(cpu, Flags::Z) == false, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!read_flag::(cpu, Flags::Z)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/gameboy/mod.rs:23:46 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn get_register_val(&self, register: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/gameboy/mod.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | .unwrap_or("Invalid register".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Invalid register".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/gameboy/mod.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / self.registers [INFO] [stderr] 25 | | .get(register) [INFO] [stderr] 26 | | .map(|x| x.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 24 | self.registers [INFO] [stderr] 25 | .get(register).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gameboy/mod.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | / match read_flag::(&self.cpu, *flag) { [INFO] [stderr] 100 | | true => "1".to_string(), [INFO] [stderr] 101 | | false => "0".to_string(), [INFO] [stderr] 102 | | }, [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if read_flag::(&self.cpu, *flag) { "1".to_string() } else { "0".to_string() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:73:23 [INFO] [stderr] | [INFO] [stderr] 73 | match trimmed.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try this: `trimmed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_registers` [INFO] [stderr] --> src/gameboy/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn get_registers(&self) -> Vec<&String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gameboy/opcode_library.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | / match self.args[0] { [INFO] [stderr] 114 | | Argument::RegisterIndirectDec(register) => { [INFO] [stderr] 115 | | let new_val = cpu.read_16_bits(register) - 1; [INFO] [stderr] 116 | | cpu.write_16_bits(register, new_val); [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | _ => {} // Do nothing [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | if let Argument::RegisterIndirectDec(register) = self.args[0] { [INFO] [stderr] 114 | let new_val = cpu.read_16_bits(register) - 1; [INFO] [stderr] 115 | cpu.write_16_bits(register, new_val); [INFO] [stderr] 116 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/gameboy/opcode_library.rs:163:51 [INFO] [stderr] | [INFO] [stderr] 163 | JumpCondition::NotZero => read_flag::(cpu, Flags::Z) == false, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!read_flag::(cpu, Flags::Z)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/gameboy/mod.rs:23:46 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn get_register_val(&self, register: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/gameboy/mod.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | .unwrap_or("Invalid register".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Invalid register".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/gameboy/mod.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / self.registers [INFO] [stderr] 25 | | .get(register) [INFO] [stderr] 26 | | .map(|x| x.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 24 | self.registers [INFO] [stderr] 25 | .get(register).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gameboy/mod.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | / match read_flag::(&self.cpu, *flag) { [INFO] [stderr] 100 | | true => "1".to_string(), [INFO] [stderr] 101 | | false => "0".to_string(), [INFO] [stderr] 102 | | }, [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if read_flag::(&self.cpu, *flag) { "1".to_string() } else { "0".to_string() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:73:23 [INFO] [stderr] | [INFO] [stderr] 73 | match trimmed.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try this: `trimmed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `"docker" "inspect" "621559fd41cbf5f9eabe5a4686e50ce04c837e27bcdc3c0c37e617c65f5e4c4d"` [INFO] running `"docker" "rm" "-f" "621559fd41cbf5f9eabe5a4686e50ce04c837e27bcdc3c0c37e617c65f5e4c4d"` [INFO] [stdout] 621559fd41cbf5f9eabe5a4686e50ce04c837e27bcdc3c0c37e617c65f5e4c4d