[INFO] updating cached repository gcp/rustywin
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/gcp/rustywin
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/gcp/rustywin" "work/ex/clippy-test-run/sources/stable/gh/gcp/rustywin"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gcp/rustywin'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/gcp/rustywin" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gcp/rustywin"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gcp/rustywin'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c05856f61343ac2f75592b0c0f954a3e048497e9
[INFO] sha for GitHub repo gcp/rustywin: c05856f61343ac2f75592b0c0f954a3e048497e9
[INFO] validating manifest of gcp/rustywin on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gcp/rustywin on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gcp/rustywin
[INFO] finished frobbing gcp/rustywin
[INFO] frobbed toml for gcp/rustywin written to work/ex/clippy-test-run/sources/stable/gh/gcp/rustywin/Cargo.toml
[INFO] started frobbing gcp/rustywin
[INFO] finished frobbing gcp/rustywin
[INFO] frobbed toml for gcp/rustywin written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gcp/rustywin/Cargo.toml
[INFO] crate gcp/rustywin has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gcp/rustywin against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gcp/rustywin:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 87d729a31eeccc926112b2725574b734cc435390e47ef5807a403bc9379aecb9
[INFO] running `"docker" "start" "-a" "87d729a31eeccc926112b2725574b734cc435390e47ef5807a403bc9379aecb9"`
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking nom v4.1.0
[INFO] [stderr]     Checking rustywin v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::fmt::Debug`
[INFO] [stderr]  --> src/analyze.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::fmt::Debug;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `IResult`, `Needed`, `le_i16`
[INFO] [stderr]  --> src/analyze.rs:7:11
[INFO] [stderr]   |
[INFO] [stderr] 7 | use nom::{le_i16, le_u16, le_u24, le_u32, le_u8, IResult, Needed};
[INFO] [stderr]   |           ^^^^^^                                 ^^^^^^^  ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/analyze.rs:309:5
[INFO] [stderr]     |
[INFO] [stderr] 309 |     result
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/analyze.rs:256:18
[INFO] [stderr]     |
[INFO] [stderr] 256 |       let result = match opcode {
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 257 | |         Some(Opcode::InternAtom) => {
[INFO] [stderr] 258 | |             let intern = intern_atom(data);
[INFO] [stderr] 259 | |             if intern.is_ok() {
[INFO] [stderr] ...   |
[INFO] [stderr] 306 | |         }
[INFO] [stderr] 307 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fmt::Debug`
[INFO] [stderr]  --> src/analyze.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::fmt::Debug;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `IResult`, `Needed`, `le_i16`
[INFO] [stderr]  --> src/analyze.rs:7:11
[INFO] [stderr]   |
[INFO] [stderr] 7 | use nom::{le_i16, le_u16, le_u24, le_u32, le_u8, IResult, Needed};
[INFO] [stderr]   |           ^^^^^^                                 ^^^^^^^  ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/analyze.rs:309:5
[INFO] [stderr]     |
[INFO] [stderr] 309 |     result
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/analyze.rs:256:18
[INFO] [stderr]     |
[INFO] [stderr] 256 |       let result = match opcode {
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 257 | |         Some(Opcode::InternAtom) => {
[INFO] [stderr] 258 | |             let intern = intern_atom(data);
[INFO] [stderr] 259 | |             if intern.is_ok() {
[INFO] [stderr] ...   |
[INFO] [stderr] 306 | |         }
[INFO] [stderr] 307 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/analyze.rs:409:26
[INFO] [stderr]     |
[INFO] [stderr] 409 |     const D_INTERNATOM: &'static [u8] = include_bytes!("../dumps/blocked.dmp");
[INFO] [stderr]     |                         -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `reject_buff`
[INFO] [stderr]    --> src/socketloop.rs:287:21
[INFO] [stderr]     |
[INFO] [stderr] 287 |                 let reject_buff = filtered_buffer_pair.1;
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider using `_reject_buff` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Denied`
[INFO] [stderr]   --> src/analyze.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     Denied,
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `screen_num`
[INFO] [stderr]   --> src/display.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn screen_num(&self) -> usize {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `reject_buff`
[INFO] [stderr]    --> src/socketloop.rs:287:21
[INFO] [stderr]     |
[INFO] [stderr] 287 |                 let reject_buff = filtered_buffer_pair.1;
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider using `_reject_buff` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/analyze.rs:156:33
[INFO] [stderr]     |
[INFO] [stderr] 156 |                     length: 4 * length_4b as u32,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: try: `u32::from(length_4b)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/analyze.rs:319:11
[INFO] [stderr]     |
[INFO] [stderr] 319 |     while buffer.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/analyze.rs:373:11
[INFO] [stderr]     |
[INFO] [stderr] 373 |     while buffer.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/socketloop.rs:46:26
[INFO] [stderr]    |
[INFO] [stderr] 46 |         child_stderr_fd: &Option<RawFd>,
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<RawFd>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Denied`
[INFO] [stderr]   --> src/analyze.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     Denied,
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `screen_num`
[INFO] [stderr]   --> src/display.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn screen_num(&self) -> usize {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/analyze.rs:156:33
[INFO] [stderr]     |
[INFO] [stderr] 156 |                     length: 4 * length_4b as u32,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: try: `u32::from(length_4b)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/analyze.rs:319:11
[INFO] [stderr]     |
[INFO] [stderr] 319 |     while buffer.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/analyze.rs:373:11
[INFO] [stderr]     |
[INFO] [stderr] 373 |     while buffer.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/socketloop.rs:46:26
[INFO] [stderr]    |
[INFO] [stderr] 46 |         child_stderr_fd: &Option<RawFd>,
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<RawFd>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.54s
[INFO] running `"docker" "inspect" "87d729a31eeccc926112b2725574b734cc435390e47ef5807a403bc9379aecb9"`
[INFO] running `"docker" "rm" "-f" "87d729a31eeccc926112b2725574b734cc435390e47ef5807a403bc9379aecb9"`
[INFO] [stdout] 87d729a31eeccc926112b2725574b734cc435390e47ef5807a403bc9379aecb9