[INFO] updating cached repository gcp/rratings [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gcp/rratings [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gcp/rratings" "work/ex/clippy-test-run/sources/stable/gh/gcp/rratings"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gcp/rratings'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gcp/rratings" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gcp/rratings"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gcp/rratings'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4f207bb90348a2c0e04fd0c7db7046465a0bd834 [INFO] sha for GitHub repo gcp/rratings: 4f207bb90348a2c0e04fd0c7db7046465a0bd834 [INFO] validating manifest of gcp/rratings on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gcp/rratings on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gcp/rratings [INFO] finished frobbing gcp/rratings [INFO] frobbed toml for gcp/rratings written to work/ex/clippy-test-run/sources/stable/gh/gcp/rratings/Cargo.toml [INFO] started frobbing gcp/rratings [INFO] finished frobbing gcp/rratings [INFO] frobbed toml for gcp/rratings written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gcp/rratings/Cargo.toml [INFO] crate gcp/rratings has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gcp/rratings against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gcp/rratings:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdf410b9770bdec5392631c82787858462d65ee8e8127b1be4bc7bb4ec5af493 [INFO] running `"docker" "start" "-a" "fdf410b9770bdec5392631c82787858462d65ee8e8127b1be4bc7bb4ec5af493"` [INFO] [stderr] Checking roots v0.0.4 [INFO] [stderr] Compiling shakmaty v0.11.2 [INFO] [stderr] Compiling arrayvec v0.4.7 [INFO] [stderr] Compiling log v0.4.5 [INFO] [stderr] Compiling atty v0.2.11 [INFO] [stderr] Compiling which v1.0.5 [INFO] [stderr] Compiling clang-sys v0.26.1 [INFO] [stderr] Compiling humantime v1.1.1 [INFO] [stderr] Compiling base64 v0.5.2 [INFO] [stderr] Compiling clap v2.32.0 [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Checking btoi v0.4.0 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Compiling blob v0.2.0 [INFO] [stderr] Compiling bindgen v0.42.3 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Compiling aho-corasick v0.6.8 [INFO] [stderr] Compiling nom v4.1.1 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling regex v1.0.5 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Compiling rayon v1.0.2 [INFO] [stderr] Compiling cexpr v0.3.3 [INFO] [stderr] Compiling env_logger v0.5.13 [INFO] [stderr] Compiling cc v1.0.25 [INFO] [stderr] Checking pgn-reader v0.10.0 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling zstd-sys v1.4.6+zstd.1.3.7 [INFO] [stderr] Checking zstd-safe v1.4.6+zstd.1.3.7 [INFO] [stderr] Checking zstd v0.4.21+zstd.1.3.7 [INFO] [stderr] Checking rratings v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/glicko2.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let f = |x: f32| { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/glicko2.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | let mut k = 1.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/glicko2.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | let b = if delta.powf(2.0) > orig_phi.powf(2.0) + v { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ligcko2.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | let f = |x: f32| { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ligcko2.rs:128:21 [INFO] [stderr] | [INFO] [stderr] 128 | let mut k = 1.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ligcko2.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | let b = if delta.powf(2.0) > orig_phi.powf(2.0) + v { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/glicko2.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let f = |x: f32| { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/glicko2.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | let mut k = 1.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/glicko2.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | let b = if delta.powf(2.0) > orig_phi.powf(2.0) + v { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ligcko2.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | let f = |x: f32| { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ligcko2.rs:128:21 [INFO] [stderr] | [INFO] [stderr] 128 | let mut k = 1.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ligcko2.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | let b = if delta.powf(2.0) > orig_phi.powf(2.0) + v { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/glicko.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/glicko.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | use chrono::{DateTime, TimeZone, Utc}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Color`, `Outcome` [INFO] [stderr] --> src/glicko.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | use pgn_reader::{Color, Outcome}; [INFO] [stderr] | ^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/glicko.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | const Q: f32 = 0.0057565; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.005_756_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/glicko2.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/glicko2.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | use chrono::{DateTime, TimeZone, Utc}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Color`, `Outcome` [INFO] [stderr] --> src/glicko2.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | use pgn_reader::{Color, Outcome}; [INFO] [stderr] | ^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/ligcko2.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/ligcko2.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | use chrono::{DateTime, TimeZone, Utc}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Color`, `Outcome` [INFO] [stderr] --> src/ligcko2.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | use pgn_reader::{Color, Outcome}; [INFO] [stderr] | ^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `AtomicUsize`, `Ordering` [INFO] [stderr] --> src/playerdb.rs:4:25 [INFO] [stderr] | [INFO] [stderr] 4 | use std::sync::atomic::{AtomicUsize, Ordering}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/playerdb.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | use chrono::{DateTime, TimeZone, Utc}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Mutex` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::sync::Mutex; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `StatsDB` [INFO] [stderr] --> src/main.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | use playerdb::{RatingDB, StatsDB}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/glicko.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/glicko.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | use chrono::{DateTime, TimeZone, Utc}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Color`, `Outcome` [INFO] [stderr] --> src/glicko.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | use pgn_reader::{Color, Outcome}; [INFO] [stderr] | ^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/glicko.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | const Q: f32 = 0.0057565; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.005_756_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/glicko2.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/glicko2.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | use chrono::{DateTime, TimeZone, Utc}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Color`, `Outcome` [INFO] [stderr] --> src/glicko2.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | use pgn_reader::{Color, Outcome}; [INFO] [stderr] | ^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/ligcko2.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/ligcko2.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | use chrono::{DateTime, TimeZone, Utc}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Color`, `Outcome` [INFO] [stderr] --> src/ligcko2.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | use pgn_reader::{Color, Outcome}; [INFO] [stderr] | ^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `AtomicUsize`, `Ordering` [INFO] [stderr] --> src/playerdb.rs:4:25 [INFO] [stderr] | [INFO] [stderr] 4 | use std::sync::atomic::{AtomicUsize, Ordering}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/playerdb.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | use chrono::{DateTime, TimeZone, Utc}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Mutex` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::sync::Mutex; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `StatsDB` [INFO] [stderr] --> src/main.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | use playerdb::{RatingDB, StatsDB}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `days_him` [INFO] [stderr] --> src/ligcko2.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let days_him = Ligcko2Rating::calc_days(&opponent.mtime, result_time); [INFO] [stderr] | ^^^^^^^^ help: consider using `_days_him` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `days_him` [INFO] [stderr] --> src/ligcko2.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let days_him = Ligcko2Rating::calc_days(&opponent.mtime, result_time); [INFO] [stderr] | ^^^^^^^^ help: consider using `_days_him` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `calc_days` [INFO] [stderr] --> src/glicko2.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | fn calc_days(old: &DateTime, now: &DateTime) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/glicko.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | fn calc_new_rd(&self, days: f32) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/playerdb.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | result: &Outcome, [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Outcome` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/playerdb.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | stats.glicko_mse_accum += (score - expected_score).powf(2.0) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((score - expected_score).powf(2.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/playerdb.rs:95:40 [INFO] [stderr] | [INFO] [stderr] 95 | stats.glicko2_mse_accum += (score - expected_score).powf(2.0) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((score - expected_score).powf(2.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/playerdb.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | stats.ligcko2_mse_accum += (score - expected_score).powf(2.0) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((score - expected_score).powf(2.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:115:53 [INFO] [stderr] | [INFO] [stderr] 115 | } else if strvalue.contains("standard") { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 116 | | // WTF is this [INFO] [stderr] 117 | | self.speed = TimeControl::Classical; [INFO] [stderr] 118 | | } else if strvalue.contains("ultrabullet") { [INFO] [stderr] | |_____________^ [INFO] [stderr] warning: method is never used: `calc_days` [INFO] [stderr] --> src/glicko2.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | fn calc_days(old: &DateTime, now: &DateTime) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:113:54 [INFO] [stderr] | [INFO] [stderr] 113 | } else if strvalue.contains("classical") { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 114 | | self.speed = TimeControl::Classical; [INFO] [stderr] 115 | | } else if strvalue.contains("standard") { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:170:12 [INFO] [stderr] | [INFO] [stderr] 170 | fn new(bar: &'a ProgressBar, read: R) -> ProgressBarRead<'a, R> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/glicko.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | fn calc_new_rd(&self, days: f32) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/playerdb.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | result: &Outcome, [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Outcome` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/playerdb.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | stats.glicko_mse_accum += (score - expected_score).powf(2.0) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((score - expected_score).powf(2.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/playerdb.rs:95:40 [INFO] [stderr] | [INFO] [stderr] 95 | stats.glicko2_mse_accum += (score - expected_score).powf(2.0) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((score - expected_score).powf(2.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/playerdb.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | stats.ligcko2_mse_accum += (score - expected_score).powf(2.0) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((score - expected_score).powf(2.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `rratings`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:115:53 [INFO] [stderr] | [INFO] [stderr] 115 | } else if strvalue.contains("standard") { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 116 | | // WTF is this [INFO] [stderr] 117 | | self.speed = TimeControl::Classical; [INFO] [stderr] 118 | | } else if strvalue.contains("ultrabullet") { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:113:54 [INFO] [stderr] | [INFO] [stderr] 113 | } else if strvalue.contains("classical") { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 114 | | self.speed = TimeControl::Classical; [INFO] [stderr] 115 | | } else if strvalue.contains("standard") { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:170:12 [INFO] [stderr] | [INFO] [stderr] 170 | fn new(bar: &'a ProgressBar, read: R) -> ProgressBarRead<'a, R> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rratings`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fdf410b9770bdec5392631c82787858462d65ee8e8127b1be4bc7bb4ec5af493"` [INFO] running `"docker" "rm" "-f" "fdf410b9770bdec5392631c82787858462d65ee8e8127b1be4bc7bb4ec5af493"` [INFO] [stdout] fdf410b9770bdec5392631c82787858462d65ee8e8127b1be4bc7bb4ec5af493