[INFO] updating cached repository gavynriebau/arp-scanner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gavynriebau/arp-scanner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gavynriebau/arp-scanner" "work/ex/clippy-test-run/sources/stable/gh/gavynriebau/arp-scanner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gavynriebau/arp-scanner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gavynriebau/arp-scanner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gavynriebau/arp-scanner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gavynriebau/arp-scanner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 713c9a1307ce24a497c69bb56cad8bf8e52acbb7 [INFO] sha for GitHub repo gavynriebau/arp-scanner: 713c9a1307ce24a497c69bb56cad8bf8e52acbb7 [INFO] validating manifest of gavynriebau/arp-scanner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gavynriebau/arp-scanner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gavynriebau/arp-scanner [INFO] finished frobbing gavynriebau/arp-scanner [INFO] frobbed toml for gavynriebau/arp-scanner written to work/ex/clippy-test-run/sources/stable/gh/gavynriebau/arp-scanner/Cargo.toml [INFO] started frobbing gavynriebau/arp-scanner [INFO] finished frobbing gavynriebau/arp-scanner [INFO] frobbed toml for gavynriebau/arp-scanner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gavynriebau/arp-scanner/Cargo.toml [INFO] crate gavynriebau/arp-scanner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gavynriebau/arp-scanner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gavynriebau/arp-scanner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 48f880a5fb1b41830a7f2502b0e700d3de65d97af908c2fbaaf5e4e0a1839d78 [INFO] running `"docker" "start" "-a" "48f880a5fb1b41830a7f2502b0e700d3de65d97af908c2fbaaf5e4e0a1839d78"` [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Compiling memchr v2.0.1 [INFO] [stderr] Checking pnet_sys v0.21.0 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Compiling thread_local v0.3.5 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking pnet_datalink v0.21.0 [INFO] [stderr] Compiling aho-corasick v0.6.4 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Checking prettytable-rs v0.7.0 [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.21.0 [INFO] [stderr] Compiling pnet_packet v0.21.0 [INFO] [stderr] Checking pnet_transport v0.21.0 [INFO] [stderr] Checking pnet v0.21.0 [INFO] [stderr] Checking arp-scanner v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:156:4 [INFO] [stderr] | [INFO] [stderr] 156 | return &iface.name == matches.value_of("interface").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&iface.name == matches.value_of("interface").unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:161:4 [INFO] [stderr] | [INFO] [stderr] 161 | return iface.index == index; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `iface.index == index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:156:4 [INFO] [stderr] | [INFO] [stderr] 156 | return &iface.name == matches.value_of("interface").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&iface.name == matches.value_of("interface").unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:161:4 [INFO] [stderr] | [INFO] [stderr] 161 | return iface.index == index; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `iface.index == index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:156:11 [INFO] [stderr] | [INFO] [stderr] 156 | return &iface.name == matches.value_of("interface").unwrap(); [INFO] [stderr] | -----------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `iface.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:166:21 [INFO] [stderr] | [INFO] [stderr] 166 | let interface = interfaces.into_iter() [INFO] [stderr] | _____________________^ [INFO] [stderr] 167 | | .filter(interface_match) [INFO] [stderr] 168 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(interface_match).next()` with `find(interface_match)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:190:19 [INFO] [stderr] | [INFO] [stderr] 190 | let (tx, rx): (Sender<(Ipv4Addr, MacAddr)>, Receiver<(Ipv4Addr, MacAddr)>) = mpsc::channel(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / loop { [INFO] [stderr] 219 | | match rx.try_recv() { [INFO] [stderr] 220 | | Ok((ipv4_addr, mac_addr)) => { [INFO] [stderr] 221 | | table.add_row(row![ipv4_addr, mac_addr]); [INFO] [stderr] ... | [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok((ipv4_addr, mac_addr)) = rx.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | if table.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!table.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | let _ = out_file.write_all(b"No hosts found...").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:156:11 [INFO] [stderr] | [INFO] [stderr] 156 | return &iface.name == matches.value_of("interface").unwrap(); [INFO] [stderr] | -----------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `iface.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:166:21 [INFO] [stderr] | [INFO] [stderr] 166 | let interface = interfaces.into_iter() [INFO] [stderr] | _____________________^ [INFO] [stderr] 167 | | .filter(interface_match) [INFO] [stderr] 168 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(interface_match).next()` with `find(interface_match)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:190:19 [INFO] [stderr] | [INFO] [stderr] 190 | let (tx, rx): (Sender<(Ipv4Addr, MacAddr)>, Receiver<(Ipv4Addr, MacAddr)>) = mpsc::channel(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / loop { [INFO] [stderr] 219 | | match rx.try_recv() { [INFO] [stderr] 220 | | Ok((ipv4_addr, mac_addr)) => { [INFO] [stderr] 221 | | table.add_row(row![ipv4_addr, mac_addr]); [INFO] [stderr] ... | [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok((ipv4_addr, mac_addr)) = rx.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | if table.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!table.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | let _ = out_file.write_all(b"No hosts found...").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `"docker" "inspect" "48f880a5fb1b41830a7f2502b0e700d3de65d97af908c2fbaaf5e4e0a1839d78"` [INFO] running `"docker" "rm" "-f" "48f880a5fb1b41830a7f2502b0e700d3de65d97af908c2fbaaf5e4e0a1839d78"` [INFO] [stdout] 48f880a5fb1b41830a7f2502b0e700d3de65d97af908c2fbaaf5e4e0a1839d78