[INFO] updating cached repository garyttierney/capstone-hsdis [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/garyttierney/capstone-hsdis [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/garyttierney/capstone-hsdis" "work/ex/clippy-test-run/sources/stable/gh/garyttierney/capstone-hsdis"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/garyttierney/capstone-hsdis'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/garyttierney/capstone-hsdis" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyttierney/capstone-hsdis"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyttierney/capstone-hsdis'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8da200ebd223d3ae8a3ef090fd26f608d0add419 [INFO] sha for GitHub repo garyttierney/capstone-hsdis: 8da200ebd223d3ae8a3ef090fd26f608d0add419 [INFO] validating manifest of garyttierney/capstone-hsdis on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of garyttierney/capstone-hsdis on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing garyttierney/capstone-hsdis [INFO] finished frobbing garyttierney/capstone-hsdis [INFO] frobbed toml for garyttierney/capstone-hsdis written to work/ex/clippy-test-run/sources/stable/gh/garyttierney/capstone-hsdis/Cargo.toml [INFO] started frobbing garyttierney/capstone-hsdis [INFO] finished frobbing garyttierney/capstone-hsdis [INFO] frobbed toml for garyttierney/capstone-hsdis written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyttierney/capstone-hsdis/Cargo.toml [INFO] crate garyttierney/capstone-hsdis has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting garyttierney/capstone-hsdis against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/garyttierney/capstone-hsdis:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f59803c43fe8ee168736f02192e9fcc6c04f8d08c10b1cf6ad8c460d0773e647 [INFO] running `"docker" "start" "-a" "f59803c43fe8ee168736f02192e9fcc6c04f8d08c10b1cf6ad8c460d0773e647"` [INFO] [stderr] Compiling capstone-sys v0.8.0 [INFO] [stderr] Checking capstone v0.4.0 [INFO] [stderr] Checking capstone-hsdis v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/arch.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn arch(&self) -> Arch { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/arch.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn mode(&self) -> Mode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/reporter.rs:144:12 [INFO] [stderr] | [INFO] [stderr] 144 | Ok((self.print_callback)( [INFO] [stderr] | ____________^ [INFO] [stderr] 145 | | self.print_callback_data, [INFO] [stderr] 146 | | data_cstr.as_ptr(), [INFO] [stderr] 147 | | )) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 144 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:23:47 [INFO] [stderr] | [INFO] [stderr] 23 | let data = unsafe { slice::from_raw_parts(start, data_len) }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `capstone-hsdis`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/arch.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn arch(&self) -> Arch { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/arch.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn mode(&self) -> Mode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/reporter.rs:144:12 [INFO] [stderr] | [INFO] [stderr] 144 | Ok((self.print_callback)( [INFO] [stderr] | ____________^ [INFO] [stderr] 145 | | self.print_callback_data, [INFO] [stderr] 146 | | data_cstr.as_ptr(), [INFO] [stderr] 147 | | )) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 144 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:23:47 [INFO] [stderr] | [INFO] [stderr] 23 | let data = unsafe { slice::from_raw_parts(start, data_len) }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `capstone-hsdis`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f59803c43fe8ee168736f02192e9fcc6c04f8d08c10b1cf6ad8c460d0773e647"` [INFO] running `"docker" "rm" "-f" "f59803c43fe8ee168736f02192e9fcc6c04f8d08c10b1cf6ad8c460d0773e647"` [INFO] [stdout] f59803c43fe8ee168736f02192e9fcc6c04f8d08c10b1cf6ad8c460d0773e647