[INFO] updating cached repository garyemerson/metrics_update [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/garyemerson/metrics_update [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/garyemerson/metrics_update" "work/ex/clippy-test-run/sources/stable/gh/garyemerson/metrics_update"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/garyemerson/metrics_update'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/garyemerson/metrics_update" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/metrics_update"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/metrics_update'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 64e7496b098c8454969c44374412d35255070b18 [INFO] sha for GitHub repo garyemerson/metrics_update: 64e7496b098c8454969c44374412d35255070b18 [INFO] validating manifest of garyemerson/metrics_update on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of garyemerson/metrics_update on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing garyemerson/metrics_update [INFO] finished frobbing garyemerson/metrics_update [INFO] frobbed toml for garyemerson/metrics_update written to work/ex/clippy-test-run/sources/stable/gh/garyemerson/metrics_update/Cargo.toml [INFO] started frobbing garyemerson/metrics_update [INFO] finished frobbing garyemerson/metrics_update [INFO] frobbed toml for garyemerson/metrics_update written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/metrics_update/Cargo.toml [INFO] crate garyemerson/metrics_update has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting garyemerson/metrics_update against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/garyemerson/metrics_update:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df8d1a88a96efc74e661f64a9806e5ec3712dbd3cb314a731806d98f65ef7c62 [INFO] running `"docker" "start" "-a" "df8d1a88a96efc74e661f64a9806e5ec3712dbd3cb314a731806d98f65ef7c62"` [INFO] [stderr] Checking md5 v0.3.5 [INFO] [stderr] Checking nodrop v0.1.10 [INFO] [stderr] Checking iovec v0.1.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking digest v0.6.2 [INFO] [stderr] Checking block-buffer v0.2.0 [INFO] [stderr] Checking crypto-mac v0.4.0 [INFO] [stderr] Checking hmac v0.4.2 [INFO] [stderr] Checking sha2 v0.6.0 [INFO] [stderr] Checking postgres-protocol v0.3.1 [INFO] [stderr] Checking postgres-shared v0.4.0 [INFO] [stderr] Checking postgres v0.15.1 [INFO] [stderr] Checking metrics_update v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: struct is never constructed: `Metric` [INFO] [stderr] --> src/main.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | struct Metric { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | .expect(&format!("Error setting up connection with connection string '{}'", conn_str)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error setting up connection with connection string '{}'", conn_str))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:33:10 [INFO] [stderr] | [INFO] [stderr] 33 | .expect(&format!("Error opening file {} and skipping first line", file_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error opening file {} and skipping first line", file_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | .expect(&format!("Error removing dups from temp table {}", temp_table)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error removing dups from temp table {}", temp_table))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:43:10 [INFO] [stderr] | [INFO] [stderr] 43 | .expect(&format!("Error merging temp table {} into table {}", temp_table, table)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error merging temp table {} into table {}", temp_table))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Metric` [INFO] [stderr] --> src/main.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | struct Metric { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | .expect(&format!("Error setting up connection with connection string '{}'", conn_str)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error setting up connection with connection string '{}'", conn_str))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:33:10 [INFO] [stderr] | [INFO] [stderr] 33 | .expect(&format!("Error opening file {} and skipping first line", file_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error opening file {} and skipping first line", file_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | .expect(&format!("Error removing dups from temp table {}", temp_table)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error removing dups from temp table {}", temp_table))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:43:10 [INFO] [stderr] | [INFO] [stderr] 43 | .expect(&format!("Error merging temp table {} into table {}", temp_table, table)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error merging temp table {} into table {}", temp_table))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.04s [INFO] running `"docker" "inspect" "df8d1a88a96efc74e661f64a9806e5ec3712dbd3cb314a731806d98f65ef7c62"` [INFO] running `"docker" "rm" "-f" "df8d1a88a96efc74e661f64a9806e5ec3712dbd3cb314a731806d98f65ef7c62"` [INFO] [stdout] df8d1a88a96efc74e661f64a9806e5ec3712dbd3cb314a731806d98f65ef7c62