[INFO] updating cached repository garethhubball/gtk_twitchdeck_server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/garethhubball/gtk_twitchdeck_server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/garethhubball/gtk_twitchdeck_server" "work/ex/clippy-test-run/sources/stable/gh/garethhubball/gtk_twitchdeck_server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/garethhubball/gtk_twitchdeck_server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/garethhubball/gtk_twitchdeck_server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garethhubball/gtk_twitchdeck_server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garethhubball/gtk_twitchdeck_server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c9d00106535a4460a93d7b13988eb4302c6a72d [INFO] sha for GitHub repo garethhubball/gtk_twitchdeck_server: 5c9d00106535a4460a93d7b13988eb4302c6a72d [INFO] validating manifest of garethhubball/gtk_twitchdeck_server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of garethhubball/gtk_twitchdeck_server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing garethhubball/gtk_twitchdeck_server [INFO] finished frobbing garethhubball/gtk_twitchdeck_server [INFO] frobbed toml for garethhubball/gtk_twitchdeck_server written to work/ex/clippy-test-run/sources/stable/gh/garethhubball/gtk_twitchdeck_server/Cargo.toml [INFO] started frobbing garethhubball/gtk_twitchdeck_server [INFO] finished frobbing garethhubball/gtk_twitchdeck_server [INFO] frobbed toml for garethhubball/gtk_twitchdeck_server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garethhubball/gtk_twitchdeck_server/Cargo.toml [INFO] crate garethhubball/gtk_twitchdeck_server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting garethhubball/gtk_twitchdeck_server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/garethhubball/gtk_twitchdeck_server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 287eda0595abfd179f53ef8cdd9e5bd745c152e565d1dc6c4ad9cdbe4a55b7bc [INFO] running `"docker" "start" "-a" "287eda0595abfd179f53ef8cdd9e5bd745c152e565d1dc6c4ad9cdbe4a55b7bc"` [INFO] [stderr] Compiling gio v0.5.1 [INFO] [stderr] Compiling gdk-pixbuf v0.5.0 [INFO] [stderr] Compiling gdk v0.9.0 [INFO] [stderr] Compiling ears v0.5.1 [INFO] [stderr] Compiling gtk v0.5.0 [INFO] [stderr] Compiling glib-sys v0.7.0 [INFO] [stderr] Compiling gobject-sys v0.7.0 [INFO] [stderr] Compiling gio-sys v0.7.0 [INFO] [stderr] Compiling pango-sys v0.7.0 [INFO] [stderr] Compiling cairo-sys-rs v0.7.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Compiling gdk-sys v0.7.0 [INFO] [stderr] Compiling atk-sys v0.7.0 [INFO] [stderr] Compiling gtk-sys v0.7.0 [INFO] [stderr] Checking flate2 v1.0.5 [INFO] [stderr] Compiling cairo-rs v0.5.0 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking glib v0.6.0 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking trust-dns-resolver v0.10.0 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] Checking actix v0.7.7 [INFO] [stderr] Checking actix-net v0.2.4 [INFO] [stderr] Checking actix-web v0.7.14 [INFO] [stderr] Checking gtktest v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/webserver.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Json(Sounds { names: names })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/webserver.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Json(Sounds { names: names })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/webserver.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | let sound_to_play = &config_state [INFO] [stderr] | ______________________________^ [INFO] [stderr] 42 | | .sounds [INFO] [stderr] 43 | | .iter() [INFO] [stderr] 44 | | .filter(|item| item.label == body.sound) [INFO] [stderr] 45 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|item| item.label == body.sound).next()` with `find(|item| item.label == body.sound)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/webserver.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | let sound_to_play = &config_state [INFO] [stderr] | ______________________________^ [INFO] [stderr] 42 | | .sounds [INFO] [stderr] 43 | | .iter() [INFO] [stderr] 44 | | .filter(|item| item.label == body.sound) [INFO] [stderr] 45 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|item| item.label == body.sound).next()` with `find(|item| item.label == body.sound)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 43s [INFO] running `"docker" "inspect" "287eda0595abfd179f53ef8cdd9e5bd745c152e565d1dc6c4ad9cdbe4a55b7bc"` [INFO] running `"docker" "rm" "-f" "287eda0595abfd179f53ef8cdd9e5bd745c152e565d1dc6c4ad9cdbe4a55b7bc"` [INFO] [stdout] 287eda0595abfd179f53ef8cdd9e5bd745c152e565d1dc6c4ad9cdbe4a55b7bc