[INFO] updating cached repository garbas/nix-installer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/garbas/nix-installer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/garbas/nix-installer" "work/ex/clippy-test-run/sources/stable/gh/garbas/nix-installer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/garbas/nix-installer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/garbas/nix-installer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garbas/nix-installer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garbas/nix-installer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] be377a9fddc2ebcd212d6600824609e8f2371a39 [INFO] sha for GitHub repo garbas/nix-installer: be377a9fddc2ebcd212d6600824609e8f2371a39 [INFO] validating manifest of garbas/nix-installer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of garbas/nix-installer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing garbas/nix-installer [INFO] finished frobbing garbas/nix-installer [INFO] frobbed toml for garbas/nix-installer written to work/ex/clippy-test-run/sources/stable/gh/garbas/nix-installer/Cargo.toml [INFO] started frobbing garbas/nix-installer [INFO] finished frobbing garbas/nix-installer [INFO] frobbed toml for garbas/nix-installer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garbas/nix-installer/Cargo.toml [INFO] crate garbas/nix-installer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting garbas/nix-installer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/garbas/nix-installer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19a2af3f07dbd978213e83fddbd646ba2e2ad88d083645bf1696dbe84b17b30b [INFO] running `"docker" "start" "-a" "19a2af3f07dbd978213e83fddbd646ba2e2ad88d083645bf1696dbe84b17b30b"` [INFO] [stderr] Compiling bzip2-sys v0.1.5 [INFO] [stderr] Checking filetime v0.1.10 [INFO] [stderr] Checking xattr v0.1.10 [INFO] [stderr] Checking elf v0.0.10 [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] Checking tar v0.4.10 [INFO] [stderr] Checking bzip2 v0.3.1 [INFO] [stderr] Checking nix-installer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/bin/nix-installer.rs:73:70 [INFO] [stderr] | [INFO] [stderr] 73 | let temp_dir = TempDir::new("nix-installer").unwrap_or_else(|e| panic!("Could not create temporary directory")); [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/nix-installer.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | tarball: matches.value_of("tarball").map(|v| PathBuf::from(v) ), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/nix-installer.rs:47:46 [INFO] [stderr] | [INFO] [stderr] 47 | prefix: matches.value_of("prefix").map(|v| PathBuf::from(v) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bin/nix-installer.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | ar.unpack(temp_dir.path()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/bin/nix-installer.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / match &options.tarball { [INFO] [stderr] 82 | | &Some(ref path) => { [INFO] [stderr] 83 | | let mut tarball_file = File::open(path).unwrap(); [INFO] [stderr] 84 | | let mut content = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | match options.tarball { [INFO] [stderr] 82 | Some(ref path) => { [INFO] [stderr] 83 | let mut tarball_file = File::open(path).unwrap(); [INFO] [stderr] 84 | let mut content = Vec::new(); [INFO] [stderr] 85 | tarball_file.read_to_end(&mut content).unwrap(); [INFO] [stderr] 86 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/nix-installer.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let ref bzip2_data = elf_file.get_section(".nixdata").unwrap_or_else(|| panic!("Corrupt file; does not contain .tar.bz2 section")).data; [INFO] [stderr] | ----^^^^^^^^^^^^^^---------------------------------------------------------------------------------------------------------------------- help: try: `let bzip2_data = &elf_file.get_section(".nixdata").unwrap_or_else(|| panic!("Corrupt file; does not contain .tar.bz2 section")).data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/bin/nix-installer.rs:73:70 [INFO] [stderr] | [INFO] [stderr] 73 | let temp_dir = TempDir::new("nix-installer").unwrap_or_else(|e| panic!("Could not create temporary directory")); [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/nix-installer.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | tarball: matches.value_of("tarball").map(|v| PathBuf::from(v) ), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/nix-installer.rs:47:46 [INFO] [stderr] | [INFO] [stderr] 47 | prefix: matches.value_of("prefix").map(|v| PathBuf::from(v) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bin/nix-installer.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | ar.unpack(temp_dir.path()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/bin/nix-installer.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / match &options.tarball { [INFO] [stderr] 82 | | &Some(ref path) => { [INFO] [stderr] 83 | | let mut tarball_file = File::open(path).unwrap(); [INFO] [stderr] 84 | | let mut content = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | match options.tarball { [INFO] [stderr] 82 | Some(ref path) => { [INFO] [stderr] 83 | let mut tarball_file = File::open(path).unwrap(); [INFO] [stderr] 84 | let mut content = Vec::new(); [INFO] [stderr] 85 | tarball_file.read_to_end(&mut content).unwrap(); [INFO] [stderr] 86 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/nix-installer.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let ref bzip2_data = elf_file.get_section(".nixdata").unwrap_or_else(|| panic!("Corrupt file; does not contain .tar.bz2 section")).data; [INFO] [stderr] | ----^^^^^^^^^^^^^^---------------------------------------------------------------------------------------------------------------------- help: try: `let bzip2_data = &elf_file.get_section(".nixdata").unwrap_or_else(|| panic!("Corrupt file; does not contain .tar.bz2 section")).data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.45s [INFO] running `"docker" "inspect" "19a2af3f07dbd978213e83fddbd646ba2e2ad88d083645bf1696dbe84b17b30b"` [INFO] running `"docker" "rm" "-f" "19a2af3f07dbd978213e83fddbd646ba2e2ad88d083645bf1696dbe84b17b30b"` [INFO] [stdout] 19a2af3f07dbd978213e83fddbd646ba2e2ad88d083645bf1696dbe84b17b30b