[INFO] updating cached repository garbagemza/font-pg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/garbagemza/font-pg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/garbagemza/font-pg" "work/ex/clippy-test-run/sources/stable/gh/garbagemza/font-pg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/garbagemza/font-pg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/garbagemza/font-pg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garbagemza/font-pg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garbagemza/font-pg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a433712704a6ec625cbafa500d8d71131aee3087 [INFO] sha for GitHub repo garbagemza/font-pg: a433712704a6ec625cbafa500d8d71131aee3087 [INFO] validating manifest of garbagemza/font-pg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of garbagemza/font-pg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing garbagemza/font-pg [INFO] finished frobbing garbagemza/font-pg [INFO] frobbed toml for garbagemza/font-pg written to work/ex/clippy-test-run/sources/stable/gh/garbagemza/font-pg/Cargo.toml [INFO] started frobbing garbagemza/font-pg [INFO] finished frobbing garbagemza/font-pg [INFO] frobbed toml for garbagemza/font-pg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garbagemza/font-pg/Cargo.toml [INFO] crate garbagemza/font-pg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting garbagemza/font-pg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/garbagemza/font-pg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4def4fdd2bd63b440dc8061e8a3dd82e66edf3b446f433ddeee1eb6a35eb5144 [INFO] running `"docker" "start" "-a" "4def4fdd2bd63b440dc8061e8a3dd82e66edf3b446f433ddeee1eb6a35eb5144"` [INFO] [stderr] Compiling freetype-sys v0.6.0 [INFO] [stderr] Checking bmp v0.4.0 [INFO] [stderr] Checking freetype-rs v0.18.0 [INFO] [stderr] Checking font-pg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in x .. x_max.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | for i in x .. x_max { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | let ref mut args = std::env::args(); [INFO] [stderr] | ----^^^^^^^^^^^^-------------------- help: try: `let args = &mut std::env::args();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | let ref font = args.nth(1).unwrap(); [INFO] [stderr] | ----^^^^^^^^------------------------ help: try: `let font = &args.nth(1).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `figure` [INFO] [stderr] --> src/main.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for j in 0 .. HEIGHT { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for (j, ) in figure.iter().enumerate().take(HEIGHT) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in x .. x_max.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | for i in x .. x_max { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | let ref mut args = std::env::args(); [INFO] [stderr] | ----^^^^^^^^^^^^-------------------- help: try: `let args = &mut std::env::args();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | let ref font = args.nth(1).unwrap(); [INFO] [stderr] | ----^^^^^^^^------------------------ help: try: `let font = &args.nth(1).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `figure` [INFO] [stderr] --> src/main.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for j in 0 .. HEIGHT { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for (j, ) in figure.iter().enumerate().take(HEIGHT) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.96s [INFO] running `"docker" "inspect" "4def4fdd2bd63b440dc8061e8a3dd82e66edf3b446f433ddeee1eb6a35eb5144"` [INFO] running `"docker" "rm" "-f" "4def4fdd2bd63b440dc8061e8a3dd82e66edf3b446f433ddeee1eb6a35eb5144"` [INFO] [stdout] 4def4fdd2bd63b440dc8061e8a3dd82e66edf3b446f433ddeee1eb6a35eb5144