[INFO] updating cached repository ganity/rust-json-db
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ganity/rust-json-db
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ganity/rust-json-db" "work/ex/clippy-test-run/sources/stable/gh/ganity/rust-json-db"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ganity/rust-json-db'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ganity/rust-json-db" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ganity/rust-json-db"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ganity/rust-json-db'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e5c9bd6ca3421a706eb2d857bf8df8e07bced268
[INFO] sha for GitHub repo ganity/rust-json-db: e5c9bd6ca3421a706eb2d857bf8df8e07bced268
[INFO] validating manifest of ganity/rust-json-db on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ganity/rust-json-db on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ganity/rust-json-db
[INFO] finished frobbing ganity/rust-json-db
[INFO] frobbed toml for ganity/rust-json-db written to work/ex/clippy-test-run/sources/stable/gh/ganity/rust-json-db/Cargo.toml
[INFO] started frobbing ganity/rust-json-db
[INFO] finished frobbing ganity/rust-json-db
[INFO] frobbed toml for ganity/rust-json-db written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ganity/rust-json-db/Cargo.toml
[INFO] crate ganity/rust-json-db has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ganity/rust-json-db against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ganity/rust-json-db:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3939a825089cee216554cf4d20339cbbfa4ac368a3ecb8c7403a822cbacb5335
[INFO] running `"docker" "start" "-a" "3939a825089cee216554cf4d20339cbbfa4ac368a3ecb8c7403a822cbacb5335"`
[INFO] [stderr]     Checking json v0.11.6
[INFO] [stderr]     Checking rust-json-demo v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             tablex
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:86:26
[INFO] [stderr]    |
[INFO] [stderr] 86 |             let tablex = findloop(&table, &rs_types);
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:88:13
[INFO] [stderr]    |
[INFO] [stderr] 88 |             tablex
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:86:26
[INFO] [stderr]    |
[INFO] [stderr] 86 |             let tablex = findloop(&table, &rs_types);
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `idx` is only used to index `value`.
[INFO] [stderr]   --> src/main.rs:68:24
[INFO] [stderr]    |
[INFO] [stderr] 68 |             for idx in 0..value.len() {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 68 |             for <item> in &value {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:82:49
[INFO] [stderr]    |
[INFO] [stderr] 82 |     let rs_types: Vec<&str> = return_type.split(".").collect();
[INFO] [stderr]    |                                                 ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `idx` is only used to index `value`.
[INFO] [stderr]   --> src/main.rs:92:24
[INFO] [stderr]    |
[INFO] [stderr] 92 |             for idx in 0..value.len() {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 92 |             for <item> in &value {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:104:48
[INFO] [stderr]     |
[INFO] [stderr] 104 | fn findloop(value: &json::JsonValue, rs_types: &Vec<&str>) -> json::JsonValue {
[INFO] [stderr]     |                                                ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:115:24
[INFO] [stderr]     |
[INFO] [stderr] 115 |                     if value1.len() >0 {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value1.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `value1`.
[INFO] [stderr]    --> src/main.rs:119:42
[INFO] [stderr]     |
[INFO] [stderr] 119 |                                 for i in 0..value1.len() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 119 |                                 for <item> in &value1 {
[INFO] [stderr]     |                                     ^^^^^^    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `rs_types`.
[INFO] [stderr]    --> src/main.rs:121:46
[INFO] [stderr]     |
[INFO] [stderr] 121 |                                     for j in idx..rs_types.len() {
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 121 |                                     for <item> in rs_types.iter().skip(idx) {
[INFO] [stderr]     |                                         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:123:41
[INFO] [stderr]     |
[INFO] [stderr] 123 |                                         let _ = rs_types2.push(rs_types[j]);
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `value1`.
[INFO] [stderr]    --> src/main.rs:151:22
[INFO] [stderr]     |
[INFO] [stderr] 151 |             for i in 0..value1.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 151 |             for <item> in &value1 {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `idx` is only used to index `value`.
[INFO] [stderr]   --> src/main.rs:68:24
[INFO] [stderr]    |
[INFO] [stderr] 68 |             for idx in 0..value.len() {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 68 |             for <item> in &value {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:82:49
[INFO] [stderr]    |
[INFO] [stderr] 82 |     let rs_types: Vec<&str> = return_type.split(".").collect();
[INFO] [stderr]    |                                                 ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `idx` is only used to index `value`.
[INFO] [stderr]   --> src/main.rs:92:24
[INFO] [stderr]    |
[INFO] [stderr] 92 |             for idx in 0..value.len() {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 92 |             for <item> in &value {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:104:48
[INFO] [stderr]     |
[INFO] [stderr] 104 | fn findloop(value: &json::JsonValue, rs_types: &Vec<&str>) -> json::JsonValue {
[INFO] [stderr]     |                                                ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:115:24
[INFO] [stderr]     |
[INFO] [stderr] 115 |                     if value1.len() >0 {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value1.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `value1`.
[INFO] [stderr]    --> src/main.rs:119:42
[INFO] [stderr]     |
[INFO] [stderr] 119 |                                 for i in 0..value1.len() {
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 119 |                                 for <item> in &value1 {
[INFO] [stderr]     |                                     ^^^^^^    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `rs_types`.
[INFO] [stderr]    --> src/main.rs:121:46
[INFO] [stderr]     |
[INFO] [stderr] 121 |                                     for j in idx..rs_types.len() {
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 121 |                                     for <item> in rs_types.iter().skip(idx) {
[INFO] [stderr]     |                                         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:123:41
[INFO] [stderr]     |
[INFO] [stderr] 123 |                                         let _ = rs_types2.push(rs_types[j]);
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `value1`.
[INFO] [stderr]    --> src/main.rs:151:22
[INFO] [stderr]     |
[INFO] [stderr] 151 |             for i in 0..value1.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 151 |             for <item> in &value1 {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.21s
[INFO] running `"docker" "inspect" "3939a825089cee216554cf4d20339cbbfa4ac368a3ecb8c7403a822cbacb5335"`
[INFO] running `"docker" "rm" "-f" "3939a825089cee216554cf4d20339cbbfa4ac368a3ecb8c7403a822cbacb5335"`
[INFO] [stdout] 3939a825089cee216554cf4d20339cbbfa4ac368a3ecb8c7403a822cbacb5335