[INFO] updating cached repository gadomski/riprocess [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gadomski/riprocess [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gadomski/riprocess" "work/ex/clippy-test-run/sources/stable/gh/gadomski/riprocess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gadomski/riprocess'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gadomski/riprocess" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gadomski/riprocess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gadomski/riprocess'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f65896522c8766fbb911e8adc66383d3be1ca4f7 [INFO] sha for GitHub repo gadomski/riprocess: f65896522c8766fbb911e8adc66383d3be1ca4f7 [INFO] validating manifest of gadomski/riprocess on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gadomski/riprocess on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gadomski/riprocess [INFO] finished frobbing gadomski/riprocess [INFO] frobbed toml for gadomski/riprocess written to work/ex/clippy-test-run/sources/stable/gh/gadomski/riprocess/Cargo.toml [INFO] started frobbing gadomski/riprocess [INFO] finished frobbing gadomski/riprocess [INFO] frobbed toml for gadomski/riprocess written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gadomski/riprocess/Cargo.toml [INFO] crate gadomski/riprocess has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gadomski/riprocess against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gadomski/riprocess:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d33ffa601574e2b89c1694757b775fd49b94c25b4bb00ec8156e3214d7ad49fe [INFO] running `"docker" "start" "-a" "d33ffa601574e2b89c1694757b775fd49b94c25b4bb00ec8156e3214d7ad49fe"` [INFO] [stderr] Checking riprocess v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:103:38 [INFO] [stderr] | [INFO] [stderr] 103 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | let config = Config { start_times: start_times }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_times` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:103:38 [INFO] [stderr] | [INFO] [stderr] 103 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | let config = Config { start_times: start_times }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_times` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/config.rs:124:40 [INFO] [stderr] | [INFO] [stderr] 124 | let expected_timestamps = vec![332979.899441, 332981.419326, 333040.399224, 333042.018970]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `332_979.899_441` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/config.rs:124:55 [INFO] [stderr] | [INFO] [stderr] 124 | let expected_timestamps = vec![332979.899441, 332981.419326, 333040.399224, 333042.018970]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `332_981.419_326` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/config.rs:124:70 [INFO] [stderr] | [INFO] [stderr] 124 | let expected_timestamps = vec![332979.899441, 332981.419326, 333040.399224, 333042.018970]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `333_040.399_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/config.rs:124:85 [INFO] [stderr] | [INFO] [stderr] 124 | let expected_timestamps = vec![332979.899441, 332981.419326, 333040.399224, 333042.018970]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `333_042.018_970` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | let timestamps = vec![vec![73779.899441, 73781.419326], vec![73840.399224, 73842.018970]]; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `73_779.899_441` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:81:50 [INFO] [stderr] | [INFO] [stderr] 81 | let timestamps = vec![vec![73779.899441, 73781.419326], vec![73840.399224, 73842.018970]]; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `73_781.419_326` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:81:70 [INFO] [stderr] | [INFO] [stderr] 81 | let timestamps = vec![vec![73779.899441, 73781.419326], vec![73840.399224, 73842.018970]]; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `73_840.399_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:81:84 [INFO] [stderr] | [INFO] [stderr] 81 | let timestamps = vec![vec![73779.899441, 73781.419326], vec![73840.399224, 73842.018970]]; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `73_842.018_970` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | let start_times = vec![332978.669, 333039.279]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `332_978.669` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:82:44 [INFO] [stderr] | [INFO] [stderr] 82 | let start_times = vec![332978.669, 333039.279]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `333_039.279` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | let expected = vec![332979.899441, 332981.419326, 333040.399224, 333042.018970]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `332_979.899_441` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:86:44 [INFO] [stderr] | [INFO] [stderr] 86 | let expected = vec![332979.899441, 332981.419326, 333040.399224, 333042.018970]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `332_981.419_326` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:86:59 [INFO] [stderr] | [INFO] [stderr] 86 | let expected = vec![332979.899441, 332981.419326, 333040.399224, 333042.018970]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `333_040.399_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/record.rs:86:74 [INFO] [stderr] | [INFO] [stderr] 86 | let expected = vec![332979.899441, 332981.419326, 333040.399224, 333042.018970]; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `333_042.018_970` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/timestamp.rs:197:30 [INFO] [stderr] | [INFO] [stderr] 197 | assert_eq!(vec![vec![73779.899441, 73781.419326, 73782.899381], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `73_779.899_441` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/timestamp.rs:197:44 [INFO] [stderr] | [INFO] [stderr] 197 | assert_eq!(vec![vec![73779.899441, 73781.419326, 73782.899381], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `73_781.419_326` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/timestamp.rs:197:58 [INFO] [stderr] | [INFO] [stderr] 197 | assert_eq!(vec![vec![73779.899441, 73781.419326, 73782.899381], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `73_782.899_381` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/timestamp.rs:198:30 [INFO] [stderr] | [INFO] [stderr] 198 | vec![73779.899441, 73781.419326]], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `73_779.899_441` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/timestamp.rs:198:44 [INFO] [stderr] | [INFO] [stderr] 198 | vec![73779.899441, 73781.419326]], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `73_781.419_326` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/record.rs:45:49 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn adjust_timestamps(&self, timestamps: &Vec>) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/record.rs:45:49 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn adjust_timestamps(&self, timestamps: &Vec>) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.38s [INFO] running `"docker" "inspect" "d33ffa601574e2b89c1694757b775fd49b94c25b4bb00ec8156e3214d7ad49fe"` [INFO] running `"docker" "rm" "-f" "d33ffa601574e2b89c1694757b775fd49b94c25b4bb00ec8156e3214d7ad49fe"` [INFO] [stdout] d33ffa601574e2b89c1694757b775fd49b94c25b4bb00ec8156e3214d7ad49fe