[INFO] updating cached repository gaberudy/hash_test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gaberudy/hash_test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gaberudy/hash_test" "work/ex/clippy-test-run/sources/stable/gh/gaberudy/hash_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gaberudy/hash_test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gaberudy/hash_test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gaberudy/hash_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gaberudy/hash_test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9e55feb701cdc80d0b0d9f7f75c108140c564a86 [INFO] sha for GitHub repo gaberudy/hash_test: 9e55feb701cdc80d0b0d9f7f75c108140c564a86 [INFO] validating manifest of gaberudy/hash_test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gaberudy/hash_test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gaberudy/hash_test [INFO] finished frobbing gaberudy/hash_test [INFO] frobbed toml for gaberudy/hash_test written to work/ex/clippy-test-run/sources/stable/gh/gaberudy/hash_test/Cargo.toml [INFO] started frobbing gaberudy/hash_test [INFO] finished frobbing gaberudy/hash_test [INFO] frobbed toml for gaberudy/hash_test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gaberudy/hash_test/Cargo.toml [INFO] crate gaberudy/hash_test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gaberudy/hash_test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/gaberudy/hash_test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d6b9c3ba01b3c59618dbb3d1ed37c8368bc666a57224a420fae2085218db6ecb [INFO] running `"docker" "start" "-a" "d6b9c3ba01b3c59618dbb3d1ed37c8368bc666a57224a420fae2085218db6ecb"` [INFO] [stderr] Compiling hash_test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking docopt v1.0.1 [INFO] [stderr] warning: native/test.c: In function 'test_int': [INFO] [stderr] warning: native/test.c:15:2: warning: implicit declaration of function 'mem_start' [-Wimplicit-function-declaration] [INFO] [stderr] warning: mem_start(); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: native/test.c:25:2: warning: implicit declaration of function 'mem_stop' [-Wimplicit-function-declaration] [INFO] [stderr] warning: mem_stop(); [INFO] [stderr] warning: ^~~~~~~~ [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gendata.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return CString::new(format!("{:x}", self)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CString::new(format!("{:x}", self)).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gendata.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return *self; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gendata.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gendata.rs:40:75 [INFO] [stderr] | [INFO] [stderr] 40 | let value: u32 = ((size as f64 * d / 4.) as u32).wrapping_mul(271828183u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `271_828_183u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gendata.rs:50:32 [INFO] [stderr] | [INFO] [stderr] 50 | let v: Vec = generate(100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gendata.rs:59:35 [INFO] [stderr] | [INFO] [stderr] 59 | let v: Vec = generate(100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_rust.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return h.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `h.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_rust.rs:44:86 [INFO] [stderr] | [INFO] [stderr] 44 | now.elapsed().as_secs() as f64 + (now.elapsed().subsec_micros() as f64 / 1000000.); [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 50 | | if use_strings { [INFO] [stderr] 51 | | let v: Vec = gendata::generate(n); [INFO] [stderr] 52 | | test_rust::insert_or_remove(&v, je_stats); [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 49 | } else if use_strings { [INFO] [stderr] 50 | let v: Vec = gendata::generate(n); [INFO] [stderr] 51 | test_rust::insert_or_remove(&v, je_stats); [INFO] [stderr] 52 | } else { [INFO] [stderr] 53 | let v: Vec = gendata::generate(n); [INFO] [stderr] 54 | test_rust::insert_or_remove(&v, je_stats); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gendata.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return CString::new(format!("{:x}", self)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CString::new(format!("{:x}", self)).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gendata.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return *self; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gendata.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gendata.rs:40:75 [INFO] [stderr] | [INFO] [stderr] 40 | let value: u32 = ((size as f64 * d / 4.) as u32).wrapping_mul(271828183u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `271_828_183u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_rust.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return h.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `h.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_rust.rs:44:86 [INFO] [stderr] | [INFO] [stderr] 44 | now.elapsed().as_secs() as f64 + (now.elapsed().subsec_micros() as f64 / 1000000.); [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 50 | | if use_strings { [INFO] [stderr] 51 | | let v: Vec = gendata::generate(n); [INFO] [stderr] 52 | | test_rust::insert_or_remove(&v, je_stats); [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 49 | } else if use_strings { [INFO] [stderr] 50 | let v: Vec = gendata::generate(n); [INFO] [stderr] 51 | test_rust::insert_or_remove(&v, je_stats); [INFO] [stderr] 52 | } else { [INFO] [stderr] 53 | let v: Vec = gendata::generate(n); [INFO] [stderr] 54 | test_rust::insert_or_remove(&v, je_stats); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `je_stats` [INFO] [stderr] --> src/test_klib.rs:18:46 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn insert_or_remove_int(data: &Vec, je_stats: bool) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_je_stats` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `je_stats` [INFO] [stderr] --> src/test_klib.rs:24:50 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn insert_or_remove_str(data: &Vec, je_stats: bool) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_je_stats` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `je_stats` [INFO] [stderr] --> src/test_klib.rs:18:46 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn insert_or_remove_int(data: &Vec, je_stats: bool) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_je_stats` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `je_stats` [INFO] [stderr] --> src/test_klib.rs:24:50 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn insert_or_remove_str(data: &Vec, je_stats: bool) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_je_stats` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/test_klib.rs:18:35 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn insert_or_remove_int(data: &Vec, je_stats: bool) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/test_klib.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn insert_or_remove_str(data: &Vec, je_stats: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[CString]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/test_rust.rs:12:45 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn insert_or_remove(data: &Vec, je_stats: bool) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_rust.rs:44:47 [INFO] [stderr] | [INFO] [stderr] 44 | now.elapsed().as_secs() as f64 + (now.elapsed().subsec_micros() as f64 / 1000000.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.elapsed().subsec_micros())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/test_klib.rs:18:35 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn insert_or_remove_int(data: &Vec, je_stats: bool) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/test_klib.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn insert_or_remove_str(data: &Vec, je_stats: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[CString]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/test_rust.rs:12:45 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn insert_or_remove(data: &Vec, je_stats: bool) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_rust.rs:44:47 [INFO] [stderr] | [INFO] [stderr] 44 | now.elapsed().as_secs() as f64 + (now.elapsed().subsec_micros() as f64 / 1000000.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.elapsed().subsec_micros())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.41s [INFO] running `"docker" "inspect" "d6b9c3ba01b3c59618dbb3d1ed37c8368bc666a57224a420fae2085218db6ecb"` [INFO] running `"docker" "rm" "-f" "d6b9c3ba01b3c59618dbb3d1ed37c8368bc666a57224a420fae2085218db6ecb"` [INFO] [stdout] d6b9c3ba01b3c59618dbb3d1ed37c8368bc666a57224a420fae2085218db6ecb