[INFO] updating cached repository g-plane/ns [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/g-plane/ns [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/g-plane/ns" "work/ex/clippy-test-run/sources/stable/gh/g-plane/ns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/g-plane/ns'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/g-plane/ns" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/g-plane/ns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/g-plane/ns'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7c1ad9e9d7d43414374cedea95d71f521b2125ea [INFO] sha for GitHub repo g-plane/ns: 7c1ad9e9d7d43414374cedea95d71f521b2125ea [INFO] validating manifest of g-plane/ns on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of g-plane/ns on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing g-plane/ns [INFO] finished frobbing g-plane/ns [INFO] frobbed toml for g-plane/ns written to work/ex/clippy-test-run/sources/stable/gh/g-plane/ns/Cargo.toml [INFO] started frobbing g-plane/ns [INFO] finished frobbing g-plane/ns [INFO] frobbed toml for g-plane/ns written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/g-plane/ns/Cargo.toml [INFO] crate g-plane/ns has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting g-plane/ns against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/g-plane/ns:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 96de8ffd85d4c507a0b8cddff1a491eb26c2b4641d01b63b9e78b36b054166fe [INFO] running `"docker" "start" "-a" "96de8ffd85d4c507a0b8cddff1a491eb26c2b4641d01b63b9e78b36b054166fe"` [INFO] [stderr] Checking xattr v0.1.11 [INFO] [stderr] Compiling filetime v0.1.15 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking num-bigint v0.1.43 [INFO] [stderr] Checking tokio-threadpool v0.1.1 [INFO] [stderr] Compiling lzma-sys v0.1.9 [INFO] [stderr] Checking tar v0.4.14 [INFO] [stderr] Checking tokio v0.1.4 [INFO] [stderr] Checking xz2 v0.1.4 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking tokio-core v0.1.16 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking hamcrest v0.1.5 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.24 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking ns v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/node.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | let home_dir = env::home_dir().unwrap_or_else(|| { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:31:34 [INFO] [stderr] | [INFO] [stderr] 31 | let home_dir = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | None => match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/node.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | let home_dir = env::home_dir().unwrap_or_else(|| { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:31:34 [INFO] [stderr] | [INFO] [stderr] 31 | let home_dir = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | None => match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/cli.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | let install_only = match matches.values_of("install-only") { [INFO] [stderr] | ________________________^ [INFO] [stderr] 12 | | Some(_) => true, [INFO] [stderr] 13 | | None => false, [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_____^ help: try this: `matches.values_of("install-only").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cli.rs:34:42 [INFO] [stderr] | [INFO] [stderr] 34 | let ver = if ver.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | return if value.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config.rs:81:51 [INFO] [stderr] | [INFO] [stderr] 81 | Some(ref mut url) => if url.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/node.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / rc_file [INFO] [stderr] 233 | | .write(new_rc_content.join("\n").as_bytes()) [INFO] [stderr] 234 | | .unwrap_or_else(|error| { [INFO] [stderr] 235 | | fatal_error!( [INFO] [stderr] ... | [INFO] [stderr] 238 | | ) [INFO] [stderr] 239 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/node.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | / rc_file [INFO] [stderr] 241 | | .write( [INFO] [stderr] 242 | | format!( [INFO] [stderr] 243 | | "\nexport PATH=\"{}:$PATH\"\n", [INFO] [stderr] ... | [INFO] [stderr] 251 | | ) [INFO] [stderr] 252 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ns`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/cli.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | let install_only = match matches.values_of("install-only") { [INFO] [stderr] | ________________________^ [INFO] [stderr] 12 | | Some(_) => true, [INFO] [stderr] 13 | | None => false, [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_____^ help: try this: `matches.values_of("install-only").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cli.rs:34:42 [INFO] [stderr] | [INFO] [stderr] 34 | let ver = if ver.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | return if value.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config.rs:81:51 [INFO] [stderr] | [INFO] [stderr] 81 | Some(ref mut url) => if url.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/node.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / rc_file [INFO] [stderr] 233 | | .write(new_rc_content.join("\n").as_bytes()) [INFO] [stderr] 234 | | .unwrap_or_else(|error| { [INFO] [stderr] 235 | | fatal_error!( [INFO] [stderr] ... | [INFO] [stderr] 238 | | ) [INFO] [stderr] 239 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/node.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | / rc_file [INFO] [stderr] 241 | | .write( [INFO] [stderr] 242 | | format!( [INFO] [stderr] 243 | | "\nexport PATH=\"{}:$PATH\"\n", [INFO] [stderr] ... | [INFO] [stderr] 251 | | ) [INFO] [stderr] 252 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ns`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "96de8ffd85d4c507a0b8cddff1a491eb26c2b4641d01b63b9e78b36b054166fe"` [INFO] running `"docker" "rm" "-f" "96de8ffd85d4c507a0b8cddff1a491eb26c2b4641d01b63b9e78b36b054166fe"` [INFO] [stdout] 96de8ffd85d4c507a0b8cddff1a491eb26c2b4641d01b63b9e78b36b054166fe