[INFO] updating cached repository futurepaul/buidl-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/futurepaul/buidl-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/futurepaul/buidl-rs" "work/ex/clippy-test-run/sources/stable/gh/futurepaul/buidl-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/futurepaul/buidl-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/futurepaul/buidl-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/futurepaul/buidl-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/futurepaul/buidl-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9ebf5146e212bf355c45786e610fedb9cf9b04ad [INFO] sha for GitHub repo futurepaul/buidl-rs: 9ebf5146e212bf355c45786e610fedb9cf9b04ad [INFO] validating manifest of futurepaul/buidl-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of futurepaul/buidl-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing futurepaul/buidl-rs [INFO] finished frobbing futurepaul/buidl-rs [INFO] frobbed toml for futurepaul/buidl-rs written to work/ex/clippy-test-run/sources/stable/gh/futurepaul/buidl-rs/Cargo.toml [INFO] started frobbing futurepaul/buidl-rs [INFO] finished frobbing futurepaul/buidl-rs [INFO] frobbed toml for futurepaul/buidl-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/futurepaul/buidl-rs/Cargo.toml [INFO] crate futurepaul/buidl-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting futurepaul/buidl-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/futurepaul/buidl-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b9646e866d428290766ad199360ae8ac2b28b10ee7b9ad9323e00fcf206e2ef6 [INFO] running `"docker" "start" "-a" "b9646e866d428290766ad199360ae8ac2b28b10ee7b9ad9323e00fcf206e2ef6"` [INFO] [stderr] Checking byteorder v1.2.6 [INFO] [stderr] Compiling proc-macro-hack v0.4.1 [INFO] [stderr] Compiling secp256k1 v0.11.2 [INFO] [stderr] Compiling hex-literal-impl v0.1.1 [INFO] [stderr] Checking block-buffer v0.7.0 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking hex-literal v0.1.1 [INFO] [stderr] Checking buidl-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bank.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bank.rs:40:7 [INFO] [stderr] | [INFO] [stderr] 40 | tx_ins: tx_ins, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tx_ins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bank.rs:41:7 [INFO] [stderr] | [INFO] [stderr] 41 | tx_outs: tx_outs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tx_outs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | secp: secp, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `secp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | tx_ins: tx_ins, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tx_ins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | tx_outs: tx_outs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tx_outs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bank.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bank.rs:40:7 [INFO] [stderr] | [INFO] [stderr] 40 | tx_ins: tx_ins, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tx_ins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bank.rs:41:7 [INFO] [stderr] | [INFO] [stderr] 41 | tx_outs: tx_outs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tx_outs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | secp: secp, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `secp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | tx_ins: tx_ins, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tx_ins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | tx_outs: tx_outs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tx_outs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bank.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | let tx_out = self.utxo.get(&tx_in.clone().outpoint()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.utxo[&tx_in.clone().outpoint()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bank.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | let tx_out = self.utxo.get(&tx_in.clone().outpoint()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.utxo[&tx_in.clone().outpoint()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/util.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | array_ref!(thing, 0, 32).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 17 | *{ [INFO] [stderr] 18 | { [INFO] [stderr] 19 | # [ inline ] unsafe fn as_array < T > ( slice : & [ T ] ) -> & [ T ; $ len ] { [INFO] [stderr] 20 | & * ( slice . as_ptr ( ) as * const [ _ ; $ len ] ) } let offset = $ offset ; [INFO] [stderr] 21 | let slice = & $ arr [ offset .. offset + $ len ] ; # [ allow ( unused_unsafe ) [INFO] [stderr] 22 | ] unsafe { as_array ( slice ) } } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/util.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | array_ref!(thing, 0, 32).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 17 | *{ [INFO] [stderr] 18 | { [INFO] [stderr] 19 | # [ inline ] unsafe fn as_array < T > ( slice : & [ T ] ) -> & [ T ; $ len ] { [INFO] [stderr] 20 | & * ( slice . as_ptr ( ) as * const [ _ ; $ len ] ) } let offset = $ offset ; [INFO] [stderr] 21 | let slice = & $ arr [ offset .. offset + $ len ] ; # [ allow ( unused_unsafe ) [INFO] [stderr] 22 | ] unsafe { as_array ( slice ) } } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.95s [INFO] running `"docker" "inspect" "b9646e866d428290766ad199360ae8ac2b28b10ee7b9ad9323e00fcf206e2ef6"` [INFO] running `"docker" "rm" "-f" "b9646e866d428290766ad199360ae8ac2b28b10ee7b9ad9323e00fcf206e2ef6"` [INFO] [stdout] b9646e866d428290766ad199360ae8ac2b28b10ee7b9ad9323e00fcf206e2ef6