[INFO] updating cached repository futpib/papeaks [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/futpib/papeaks [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/futpib/papeaks" "work/ex/clippy-test-run/sources/stable/gh/futpib/papeaks"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/futpib/papeaks'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/futpib/papeaks" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/futpib/papeaks"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/futpib/papeaks'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4fa9d2ba00de7ff264a3a841540b07675c7cda0a [INFO] sha for GitHub repo futpib/papeaks: 4fa9d2ba00de7ff264a3a841540b07675c7cda0a [INFO] validating manifest of futpib/papeaks on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of futpib/papeaks on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing futpib/papeaks [INFO] finished frobbing futpib/papeaks [INFO] frobbed toml for futpib/papeaks written to work/ex/clippy-test-run/sources/stable/gh/futpib/papeaks/Cargo.toml [INFO] started frobbing futpib/papeaks [INFO] finished frobbing futpib/papeaks [INFO] frobbed toml for futpib/papeaks written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/futpib/papeaks/Cargo.toml [INFO] crate futpib/papeaks has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting futpib/papeaks against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/futpib/papeaks:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6cd1d4ac63864b45e9a48510cdfddf6e3f1c835ec0e68eba58123a85f4b3d5fc [INFO] running `"docker" "start" "-a" "6cd1d4ac63864b45e9a48510cdfddf6e3f1c835ec0e68eba58123a85f4b3d5fc"` [INFO] [stderr] Compiling libpulse-sys v1.4.0 [INFO] [stderr] Checking libpulse-binding v2.4.0 [INFO] [stderr] Checking papeaks v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return stream; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return stream; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / match res { [INFO] [stderr] 82 | | ListResult::Item(sink_input) => { [INFO] [stderr] 83 | | sink_inputs.lock().unwrap().insert(sink_input.index); [INFO] [stderr] 84 | | sink_input_to_sink.lock().unwrap().insert(sink_input.index, sink_input.sink); [INFO] [stderr] ... | [INFO] [stderr] 88 | | _ => {}, [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | if let ListResult::Item(sink_input) = res { [INFO] [stderr] 82 | sink_inputs.lock().unwrap().insert(sink_input.index); [INFO] [stderr] 83 | sink_input_to_sink.lock().unwrap().insert(sink_input.index, sink_input.sink); [INFO] [stderr] 84 | sink_info_queue.lock().unwrap().insert(sink_input.sink); [INFO] [stderr] 85 | eprintln!("SinkInputInfo {} {}", sink_input.index, sink_input.sink); [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / match res { [INFO] [stderr] 94 | | ListResult::Item(sink) => { [INFO] [stderr] 95 | | sink_to_monitor.lock().unwrap().insert(sink.index, sink.monitor_source); [INFO] [stderr] 96 | | eprintln!("SinkInfo {} {}", sink.index, sink.monitor_source); [INFO] [stderr] 97 | | }, [INFO] [stderr] 98 | | _ => {}, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | if let ListResult::Item(sink) = res { [INFO] [stderr] 94 | sink_to_monitor.lock().unwrap().insert(sink.index, sink.monitor_source); [INFO] [stderr] 95 | eprintln!("SinkInfo {} {}", sink.index, sink.monitor_source); [INFO] [stderr] 96 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | fn peak(&mut self, &Facility, &u32, &[u8; 4]); [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Facility` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:104:35 [INFO] [stderr] | [INFO] [stderr] 104 | fn peak(&mut self, &Facility, &u32, &[u8; 4]); [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:104:41 [INFO] [stderr] | [INFO] [stderr] 104 | fn peak(&mut self, &Facility, &u32, &[u8; 4]); [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | out.write(peak).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] --> src/main.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / match res { [INFO] [stderr] 82 | | ListResult::Item(sink_input) => { [INFO] [stderr] 83 | | sink_inputs.lock().unwrap().insert(sink_input.index); [INFO] [stderr] 84 | | sink_input_to_sink.lock().unwrap().insert(sink_input.index, sink_input.sink); [INFO] [stderr] ... | [INFO] [stderr] 88 | | _ => {}, [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | if let ListResult::Item(sink_input) = res { [INFO] [stderr] 82 | sink_inputs.lock().unwrap().insert(sink_input.index); [INFO] [stderr] 83 | sink_input_to_sink.lock().unwrap().insert(sink_input.index, sink_input.sink); [INFO] [stderr] 84 | sink_info_queue.lock().unwrap().insert(sink_input.sink); [INFO] [stderr] 85 | eprintln!("SinkInputInfo {} {}", sink_input.index, sink_input.sink); [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / match res { [INFO] [stderr] 94 | | ListResult::Item(sink) => { [INFO] [stderr] 95 | | sink_to_monitor.lock().unwrap().insert(sink.index, sink.monitor_source); [INFO] [stderr] 96 | | eprintln!("SinkInfo {} {}", sink.index, sink.monitor_source); [INFO] [stderr] 97 | | }, [INFO] [stderr] 98 | | _ => {}, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | if let ListResult::Item(sink) = res { [INFO] [stderr] 94 | sink_to_monitor.lock().unwrap().insert(sink.index, sink.monitor_source); [INFO] [stderr] 95 | eprintln!("SinkInfo {} {}", sink.index, sink.monitor_source); [INFO] [stderr] 96 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | fn peak(&mut self, &Facility, &u32, &[u8; 4]); [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Facility` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:104:35 [INFO] [stderr] | [INFO] [stderr] 104 | fn peak(&mut self, &Facility, &u32, &[u8; 4]); [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:104:41 [INFO] [stderr] | [INFO] [stderr] 104 | fn peak(&mut self, &Facility, &u32, &[u8; 4]); [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | out.write(peak).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/main.rs:126:29 [INFO] [stderr] | [INFO] [stderr] 126 | let peak = unsafe { std::mem::transmute::<&[u8; 4], &f32>(peak_) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(peak_ as *const [u8; 4] as *const f32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/main.rs:137:76 [INFO] [stderr] | [INFO] [stderr] 137 | fn output(data: &[u8], facility: &Facility, object_index: &u32, outputter: &mut Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn Outputter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:137:34 [INFO] [stderr] | [INFO] [stderr] 137 | fn output(data: &[u8], facility: &Facility, object_index: &u32, outputter: &mut Box) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Facility` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:137:59 [INFO] [stderr] | [INFO] [stderr] 137 | fn output(data: &[u8], facility: &Facility, object_index: &u32, outputter: &mut Box) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/main.rs:126:29 [INFO] [stderr] | [INFO] [stderr] 126 | let peak = unsafe { std::mem::transmute::<&[u8; 4], &f32>(peak_) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(peak_ as *const [u8; 4] as *const f32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/main.rs:137:76 [INFO] [stderr] | [INFO] [stderr] 137 | fn output(data: &[u8], facility: &Facility, object_index: &u32, outputter: &mut Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn Outputter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:137:34 [INFO] [stderr] | [INFO] [stderr] 137 | fn output(data: &[u8], facility: &Facility, object_index: &u32, outputter: &mut Box) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Facility` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:137:59 [INFO] [stderr] | [INFO] [stderr] 137 | fn output(data: &[u8], facility: &Facility, object_index: &u32, outputter: &mut Box) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | / match res { [INFO] [stderr] 206 | | ListResult::Item(source) => { [INFO] [stderr] 207 | | sources.lock().unwrap().insert(source.index); [INFO] [stderr] 208 | | }, [INFO] [stderr] 209 | | _ => {}, [INFO] [stderr] 210 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 205 | if let ListResult::Item(source) = res { [INFO] [stderr] 206 | sources.lock().unwrap().insert(source.index); [INFO] [stderr] 207 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | / match res { [INFO] [stderr] 206 | | ListResult::Item(source) => { [INFO] [stderr] 207 | | sources.lock().unwrap().insert(source.index); [INFO] [stderr] 208 | | }, [INFO] [stderr] 209 | | _ => {}, [INFO] [stderr] 210 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 205 | if let ListResult::Item(source) = res { [INFO] [stderr] 206 | sources.lock().unwrap().insert(source.index); [INFO] [stderr] 207 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `papeaks`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `papeaks`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6cd1d4ac63864b45e9a48510cdfddf6e3f1c835ec0e68eba58123a85f4b3d5fc"` [INFO] running `"docker" "rm" "-f" "6cd1d4ac63864b45e9a48510cdfddf6e3f1c835ec0e68eba58123a85f4b3d5fc"` [INFO] [stdout] 6cd1d4ac63864b45e9a48510cdfddf6e3f1c835ec0e68eba58123a85f4b3d5fc