[INFO] updating cached repository fujitayy/virtualbox_vm_has_sata_controller [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fujitayy/virtualbox_vm_has_sata_controller [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fujitayy/virtualbox_vm_has_sata_controller" "work/ex/clippy-test-run/sources/stable/gh/fujitayy/virtualbox_vm_has_sata_controller"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fujitayy/virtualbox_vm_has_sata_controller'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fujitayy/virtualbox_vm_has_sata_controller" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fujitayy/virtualbox_vm_has_sata_controller"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fujitayy/virtualbox_vm_has_sata_controller'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 09dd57739a253520a541fb7200653369d80c42af [INFO] sha for GitHub repo fujitayy/virtualbox_vm_has_sata_controller: 09dd57739a253520a541fb7200653369d80c42af [INFO] validating manifest of fujitayy/virtualbox_vm_has_sata_controller on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fujitayy/virtualbox_vm_has_sata_controller on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fujitayy/virtualbox_vm_has_sata_controller [INFO] finished frobbing fujitayy/virtualbox_vm_has_sata_controller [INFO] frobbed toml for fujitayy/virtualbox_vm_has_sata_controller written to work/ex/clippy-test-run/sources/stable/gh/fujitayy/virtualbox_vm_has_sata_controller/Cargo.toml [INFO] started frobbing fujitayy/virtualbox_vm_has_sata_controller [INFO] finished frobbing fujitayy/virtualbox_vm_has_sata_controller [INFO] frobbed toml for fujitayy/virtualbox_vm_has_sata_controller written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fujitayy/virtualbox_vm_has_sata_controller/Cargo.toml [INFO] crate fujitayy/virtualbox_vm_has_sata_controller has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fujitayy/virtualbox_vm_has_sata_controller against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fujitayy/virtualbox_vm_has_sata_controller:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b702c7c8ed4f1c4942b63eb0ef9cc7178aebc7f19189792a5b7ab642655b1c6a [INFO] running `"docker" "start" "-a" "b702c7c8ed4f1c4942b63eb0ef9cc7178aebc7f19189792a5b7ab642655b1c6a"` [INFO] [stderr] Checking virtualbox_vm_has_sata_controller v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | name: args.next().unwrap_or("SATA Controller".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "SATA Controller".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | name: args.next().unwrap_or("default".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "default".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / fn get_uuid<'a>(machine_name: &'a MachineName) -> Result { [INFO] [stderr] 33 | | let mut id_path = PathBuf::from(r".vagrant\machines"); [INFO] [stderr] 34 | | id_path.push(&machine_name.name); [INFO] [stderr] 35 | | id_path.push("virtualbox"); [INFO] [stderr] ... | [INFO] [stderr] 47 | | Ok(UUID { uuid }) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | name: args.next().unwrap_or("SATA Controller".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "SATA Controller".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | name: args.next().unwrap_or("default".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "default".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / fn get_uuid<'a>(machine_name: &'a MachineName) -> Result { [INFO] [stderr] 33 | | let mut id_path = PathBuf::from(r".vagrant\machines"); [INFO] [stderr] 34 | | id_path.push(&machine_name.name); [INFO] [stderr] 35 | | id_path.push("virtualbox"); [INFO] [stderr] ... | [INFO] [stderr] 47 | | Ok(UUID { uuid }) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.44s [INFO] running `"docker" "inspect" "b702c7c8ed4f1c4942b63eb0ef9cc7178aebc7f19189792a5b7ab642655b1c6a"` [INFO] running `"docker" "rm" "-f" "b702c7c8ed4f1c4942b63eb0ef9cc7178aebc7f19189792a5b7ab642655b1c6a"` [INFO] [stdout] b702c7c8ed4f1c4942b63eb0ef9cc7178aebc7f19189792a5b7ab642655b1c6a