[INFO] updating cached repository fudini/neurust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fudini/neurust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fudini/neurust" "work/ex/clippy-test-run/sources/stable/gh/fudini/neurust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fudini/neurust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fudini/neurust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fudini/neurust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fudini/neurust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5dfe883bb281a98eb0e28df1018ab944ed183ac0 [INFO] sha for GitHub repo fudini/neurust: 5dfe883bb281a98eb0e28df1018ab944ed183ac0 [INFO] validating manifest of fudini/neurust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fudini/neurust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fudini/neurust [INFO] finished frobbing fudini/neurust [INFO] frobbed toml for fudini/neurust written to work/ex/clippy-test-run/sources/stable/gh/fudini/neurust/Cargo.toml [INFO] started frobbing fudini/neurust [INFO] finished frobbing fudini/neurust [INFO] frobbed toml for fudini/neurust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fudini/neurust/Cargo.toml [INFO] crate fudini/neurust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fudini/neurust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fudini/neurust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c83c662240001e524f91e8e039b9326e2c99f69e602dbb81445710b174fbfa2 [INFO] running `"docker" "start" "-a" "1c83c662240001e524f91e8e039b9326e2c99f69e602dbb81445710b174fbfa2"` [INFO] [stderr] Checking time v0.1.36 [INFO] [stderr] Checking neurust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | bias: bias, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bias` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | new_weights: new_weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | learning_rate: learning_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `learning_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | activation_fn: activation_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activation_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | error_fn: error_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `error_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | learning_rate: learning_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `learning_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | activation_fn: activation_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activation_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | error_fn: error_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `error_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | layers: layers [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | bias: bias, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bias` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | new_weights: new_weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | learning_rate: learning_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `learning_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | activation_fn: activation_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activation_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | error_fn: error_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `error_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | learning_rate: learning_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `learning_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | activation_fn: activation_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activation_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | error_fn: error_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `error_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | layers: layers [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:328:37 [INFO] [stderr] | [INFO] [stderr] 328 | assert!(network_outputs == vec!(0.4763176074370886, 0.5411613536686533, 0.47558085220979524)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.476_317_607_437_088_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:328:57 [INFO] [stderr] | [INFO] [stderr] 328 | assert!(network_outputs == vec!(0.4763176074370886, 0.5411613536686533, 0.47558085220979524)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.541_161_353_668_653_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:328:77 [INFO] [stderr] | [INFO] [stderr] 328 | assert!(network_outputs == vec!(0.4763176074370886, 0.5411613536686533, 0.47558085220979524)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.475_580_852_209_795_24` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:334:37 [INFO] [stderr] | [INFO] [stderr] 334 | assert!(network_outputs == vec!(0.45083786140605075, 0.5639480600777952, 0.45002933641579157)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.450_837_861_406_050_75` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:334:58 [INFO] [stderr] | [INFO] [stderr] 334 | assert!(network_outputs == vec!(0.45083786140605075, 0.5639480600777952, 0.45002933641579157)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.563_948_060_077_795_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:334:78 [INFO] [stderr] | [INFO] [stderr] 334 | assert!(network_outputs == vec!(0.45083786140605075, 0.5639480600777952, 0.45002933641579157)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.450_029_336_415_791_57` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:340:37 [INFO] [stderr] | [INFO] [stderr] 340 | assert!(network_outputs == vec!(0.43299515834212265, 0.5799061048726579, 0.43214702784312253)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.432_995_158_342_122_65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:340:58 [INFO] [stderr] | [INFO] [stderr] 340 | assert!(network_outputs == vec!(0.43299515834212265, 0.5799061048726579, 0.43214702784312253)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.579_906_104_872_657_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:340:78 [INFO] [stderr] | [INFO] [stderr] 340 | assert!(network_outputs == vec!(0.43299515834212265, 0.5799061048726579, 0.43214702784312253)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.432_147_027_843_122_53` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/neural.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | let weights: Vec = (0..inputs_num) [INFO] [stderr] | _________________________________^ [INFO] [stderr] 47 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..inputs_num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn feed_forward(&mut self, inputs: &Vec, activation_fn: ActivationFn) [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:147:43 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn feed_forward(&self, inputs: &Vec) -> &Vec> [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:225:33 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn train(&self, inputs: &Vec, outputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:225:53 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn train(&self, inputs: &Vec, outputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is used to index `inputs` [INFO] [stderr] --> src/neural.rs:265:41 [INFO] [stderr] | [INFO] [stderr] 265 | for weight_index in 0..current_neuron.weights.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 265 | for (weight_index, ) in inputs.iter().enumerate().take(current_neuron.weights.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `previous_neuron_index` is used to index `previous_layer` [INFO] [stderr] --> src/neural.rs:283:46 [INFO] [stderr] | [INFO] [stderr] 283 | for previous_neuron_index in 0..previous_layer.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 283 | for (previous_neuron_index, ) in previous_layer.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | bias: bias, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bias` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | new_weights: new_weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | learning_rate: learning_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `learning_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | activation_fn: activation_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activation_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | error_fn: error_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `error_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | learning_rate: learning_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `learning_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | activation_fn: activation_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activation_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | error_fn: error_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `error_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | layers: layers [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mnist.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mnist.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/neural.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | let weights: Vec = (0..inputs_num) [INFO] [stderr] | _________________________________^ [INFO] [stderr] 47 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..inputs_num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn feed_forward(&mut self, inputs: &Vec, activation_fn: ActivationFn) [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:147:43 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn feed_forward(&self, inputs: &Vec) -> &Vec> [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:225:33 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn train(&self, inputs: &Vec, outputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:225:53 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn train(&self, inputs: &Vec, outputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is used to index `inputs` [INFO] [stderr] --> src/neural.rs:265:41 [INFO] [stderr] | [INFO] [stderr] 265 | for weight_index in 0..current_neuron.weights.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 265 | for (weight_index, ) in inputs.iter().enumerate().take(current_neuron.weights.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `previous_neuron_index` is used to index `previous_layer` [INFO] [stderr] --> src/neural.rs:283:46 [INFO] [stderr] | [INFO] [stderr] 283 | for previous_neuron_index in 0..previous_layer.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 283 | for (previous_neuron_index, ) in previous_layer.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | bias: bias, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bias` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | new_weights: new_weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | learning_rate: learning_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `learning_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | activation_fn: activation_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activation_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | error_fn: error_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `error_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | learning_rate: learning_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `learning_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | activation_fn: activation_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activation_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | error_fn: error_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `error_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neural.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | layers: layers [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mnist.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mnist.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused import: `Neuron` [INFO] [stderr] --> src/main.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | use neural::{ NeuralNetwork, Neuron }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:328:37 [INFO] [stderr] | [INFO] [stderr] 328 | assert!(network_outputs == vec!(0.4763176074370886, 0.5411613536686533, 0.47558085220979524)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.476_317_607_437_088_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:328:57 [INFO] [stderr] | [INFO] [stderr] 328 | assert!(network_outputs == vec!(0.4763176074370886, 0.5411613536686533, 0.47558085220979524)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.541_161_353_668_653_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:328:77 [INFO] [stderr] | [INFO] [stderr] 328 | assert!(network_outputs == vec!(0.4763176074370886, 0.5411613536686533, 0.47558085220979524)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.475_580_852_209_795_24` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:334:37 [INFO] [stderr] | [INFO] [stderr] 334 | assert!(network_outputs == vec!(0.45083786140605075, 0.5639480600777952, 0.45002933641579157)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.450_837_861_406_050_75` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:334:58 [INFO] [stderr] | [INFO] [stderr] 334 | assert!(network_outputs == vec!(0.45083786140605075, 0.5639480600777952, 0.45002933641579157)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.563_948_060_077_795_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:334:78 [INFO] [stderr] | [INFO] [stderr] 334 | assert!(network_outputs == vec!(0.45083786140605075, 0.5639480600777952, 0.45002933641579157)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.450_029_336_415_791_57` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:340:37 [INFO] [stderr] | [INFO] [stderr] 340 | assert!(network_outputs == vec!(0.43299515834212265, 0.5799061048726579, 0.43214702784312253)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.432_995_158_342_122_65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:340:58 [INFO] [stderr] | [INFO] [stderr] 340 | assert!(network_outputs == vec!(0.43299515834212265, 0.5799061048726579, 0.43214702784312253)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.579_906_104_872_657_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/neural.rs:340:78 [INFO] [stderr] | [INFO] [stderr] 340 | assert!(network_outputs == vec!(0.43299515834212265, 0.5799061048726579, 0.43214702784312253)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.432_147_027_843_122_53` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Neuron` [INFO] [stderr] --> src/main.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | use neural::{ NeuralNetwork, Neuron }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `error` is never read [INFO] [stderr] --> src/main.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut error = 0.0; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Data` [INFO] [stderr] --> src/neural.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | pub struct Data { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `with_layers` [INFO] [stderr] --> src/neural.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / pub fn with_layers( [INFO] [stderr] 129 | | layers: Vec>>, [INFO] [stderr] 130 | | learning_rate: f64, [INFO] [stderr] 131 | | activation_fn: ActivationFn, [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `import` [INFO] [stderr] --> src/neural.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn import(data: Data) -> NeuralNetwork { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `export` [INFO] [stderr] --> src/neural.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | pub fn export(&self) -> Data { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `render_digit` [INFO] [stderr] --> src/mnist.rs:136:1 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn render_digit(pixels: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `tanh_activation` [INFO] [stderr] --> src/functions.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | fn tanh_activation(x: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `tanh_derivative` [INFO] [stderr] --> src/functions.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn tanh_derivative(o: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `TANH` [INFO] [stderr] --> src/functions.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub static TANH: ActivationFn = (tanh_activation, tanh_derivative); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run_xor` [INFO] [stderr] --> src/main.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | fn run_xor () { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/neural.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | let weights: Vec = (0..inputs_num) [INFO] [stderr] | _________________________________^ [INFO] [stderr] 47 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..inputs_num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn feed_forward(&mut self, inputs: &Vec, activation_fn: ActivationFn) [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:147:43 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn feed_forward(&self, inputs: &Vec) -> &Vec> [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:225:33 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn train(&self, inputs: &Vec, outputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:225:53 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn train(&self, inputs: &Vec, outputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is used to index `inputs` [INFO] [stderr] --> src/neural.rs:265:41 [INFO] [stderr] | [INFO] [stderr] 265 | for weight_index in 0..current_neuron.weights.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 265 | for (weight_index, ) in inputs.iter().enumerate().take(current_neuron.weights.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `previous_neuron_index` is used to index `previous_layer` [INFO] [stderr] --> src/neural.rs:283:46 [INFO] [stderr] | [INFO] [stderr] 283 | for previous_neuron_index in 0..previous_layer.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 283 | for (previous_neuron_index, ) in previous_layer.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mnist.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | file.read_exact(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | let pixel = (buf[index] as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[index])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | + buf[index + 1] as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[index + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | + buf[index + size] as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[index + size])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | + buf[index + size + 1] as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[index + size + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | buf.iter().map(|v| (*v as f64) / 256.0).collect::>() [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mnist.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | images_reader.seek(SeekFrom::Start(16 + (i * image_size) as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:89:49 [INFO] [stderr] | [INFO] [stderr] 89 | images_reader.seek(SeekFrom::Start(16 + (i * image_size) as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(i * image_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mnist.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | labels_reader.seek(SeekFrom::Start(8 + i as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:93:48 [INFO] [stderr] | [INFO] [stderr] 93 | labels_reader.seek(SeekFrom::Start(8 + i as u64)); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `outputs` [INFO] [stderr] --> src/mnist.rs:123:14 [INFO] [stderr] | [INFO] [stderr] 123 | for i in 0..outputs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 123 | for (i, ) in outputs.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mnist.rs:132:34 [INFO] [stderr] | [INFO] [stderr] 132 | pub fn outputs_to_digit(outputs: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mnist.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn render_digit(pixels: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | error = error / images_set as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error /= images_set as f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: value assigned to `error` is never read [INFO] [stderr] --> src/main.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut error = 0.0; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Data` [INFO] [stderr] --> src/neural.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | pub struct Data { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `import` [INFO] [stderr] --> src/neural.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn import(data: Data) -> NeuralNetwork { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `export` [INFO] [stderr] --> src/neural.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | pub fn export(&self) -> Data { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `render_digit` [INFO] [stderr] --> src/mnist.rs:136:1 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn render_digit(pixels: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `tanh_activation` [INFO] [stderr] --> src/functions.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | fn tanh_activation(x: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `tanh_derivative` [INFO] [stderr] --> src/functions.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn tanh_derivative(o: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `TANH` [INFO] [stderr] --> src/functions.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub static TANH: ActivationFn = (tanh_activation, tanh_derivative); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `run_xor` [INFO] [stderr] --> src/main.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | fn run_xor () { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/neural.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | let weights: Vec = (0..inputs_num) [INFO] [stderr] | _________________________________^ [INFO] [stderr] 47 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..inputs_num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn feed_forward(&mut self, inputs: &Vec, activation_fn: ActivationFn) [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:147:43 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn feed_forward(&self, inputs: &Vec) -> &Vec> [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:225:33 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn train(&self, inputs: &Vec, outputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/neural.rs:225:53 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn train(&self, inputs: &Vec, outputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `weight_index` is used to index `inputs` [INFO] [stderr] --> src/neural.rs:265:41 [INFO] [stderr] | [INFO] [stderr] 265 | for weight_index in 0..current_neuron.weights.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 265 | for (weight_index, ) in inputs.iter().enumerate().take(current_neuron.weights.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `previous_neuron_index` is used to index `previous_layer` [INFO] [stderr] --> src/neural.rs:283:46 [INFO] [stderr] | [INFO] [stderr] 283 | for previous_neuron_index in 0..previous_layer.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 283 | for (previous_neuron_index, ) in previous_layer.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mnist.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | file.read_exact(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | let pixel = (buf[index] as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[index])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | + buf[index + 1] as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[index + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | + buf[index + size] as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[index + size])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | + buf[index + size + 1] as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[index + size + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | buf.iter().map(|v| (*v as f64) / 256.0).collect::>() [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mnist.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | images_reader.seek(SeekFrom::Start(16 + (i * image_size) as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:89:49 [INFO] [stderr] | [INFO] [stderr] 89 | images_reader.seek(SeekFrom::Start(16 + (i * image_size) as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(i * image_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mnist.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | labels_reader.seek(SeekFrom::Start(8 + i as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mnist.rs:93:48 [INFO] [stderr] | [INFO] [stderr] 93 | labels_reader.seek(SeekFrom::Start(8 + i as u64)); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `outputs` [INFO] [stderr] --> src/mnist.rs:123:14 [INFO] [stderr] | [INFO] [stderr] 123 | for i in 0..outputs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 123 | for (i, ) in outputs.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mnist.rs:132:34 [INFO] [stderr] | [INFO] [stderr] 132 | pub fn outputs_to_digit(outputs: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mnist.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn render_digit(pixels: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | error = error / images_set as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error /= images_set as f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.22s [INFO] running `"docker" "inspect" "1c83c662240001e524f91e8e039b9326e2c99f69e602dbb81445710b174fbfa2"` [INFO] running `"docker" "rm" "-f" "1c83c662240001e524f91e8e039b9326e2c99f69e602dbb81445710b174fbfa2"` [INFO] [stdout] 1c83c662240001e524f91e8e039b9326e2c99f69e602dbb81445710b174fbfa2