[INFO] updating cached repository fudanchii/wp2l2d [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fudanchii/wp2l2d [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fudanchii/wp2l2d" "work/ex/clippy-test-run/sources/stable/gh/fudanchii/wp2l2d"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fudanchii/wp2l2d'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fudanchii/wp2l2d" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fudanchii/wp2l2d"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fudanchii/wp2l2d'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4c51422e12f9fe89b8c5ce4151b094a3fd7b7c61 [INFO] sha for GitHub repo fudanchii/wp2l2d: 4c51422e12f9fe89b8c5ce4151b094a3fd7b7c61 [INFO] validating manifest of fudanchii/wp2l2d on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fudanchii/wp2l2d on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fudanchii/wp2l2d [INFO] finished frobbing fudanchii/wp2l2d [INFO] frobbed toml for fudanchii/wp2l2d written to work/ex/clippy-test-run/sources/stable/gh/fudanchii/wp2l2d/Cargo.toml [INFO] started frobbing fudanchii/wp2l2d [INFO] finished frobbing fudanchii/wp2l2d [INFO] frobbed toml for fudanchii/wp2l2d written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fudanchii/wp2l2d/Cargo.toml [INFO] crate fudanchii/wp2l2d has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fudanchii/wp2l2d against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/fudanchii/wp2l2d:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4d620b7539198ab5c5c6aa011fbd9c7c30de4675997cf25617ba90532a432491 [INFO] running `"docker" "start" "-a" "4d620b7539198ab5c5c6aa011fbd9c7c30de4675997cf25617ba90532a432491"` [INFO] [stderr] Compiling actix-web v0.7.8 [INFO] [stderr] Checking envy v0.3.2 [INFO] [stderr] Checking serde_json v1.0.28 [INFO] [stderr] Checking ring v0.13.2 [INFO] [stderr] Checking crossbeam-epoch v0.6.0 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-signal v0.2.5 [INFO] [stderr] Checking sct v0.4.0 [INFO] [stderr] Checking webpki v0.18.1 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking rustls v0.13.1 [INFO] [stderr] Checking webpki-roots v0.15.0 [INFO] [stderr] Checking tokio-rustls v0.7.2 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking actix v0.7.4 [INFO] [stderr] Checking quick-xml v0.12.4 [INFO] [stderr] Checking rss v1.5.0 [INFO] [stderr] Checking wp2l2d v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linetoday.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | feed: feed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `feed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linetoday.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linetoday.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | feed: feed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `feed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linetoday.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/healthcheck.rs:34:60 [INFO] [stderr] | [INFO] [stderr] 34 | self.response_time = (duration.as_secs() * 1000) + duration.subsec_millis() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/linetoday.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | Func(Box, &mut Writer>) -> Result<(), XMLError> + 'a>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/linetoday.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | Box, &mut Writer>, usize) -> Result<(), XMLError> + 'a>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/linetoday.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | .map_err(|err| ErrorInternalServerError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ErrorInternalServerError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/linetoday.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | fn into_xml(&'a self) -> Result, XMLError> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/linetoday.rs:39:62 [INFO] [stderr] | [INFO] [stderr] 39 | let mut writer = Writer::new_with_indent(Vec::new(), ' ' as u8, 2); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/linetoday.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | .unwrap_or(Utc::now()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Utc::now())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/linetoday.rs:134:24 [INFO] [stderr] | [INFO] [stderr] 134 | let duration = self.config.publish_duration_in_weeks.unwrap_or(144) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.config.publish_duration_in_weeks.unwrap_or(144))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/linetoday.rs:167:34 [INFO] [stderr] | [INFO] [stderr] 167 | let title = item.title().unwrap_or(channel.title()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| channel.title())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/linetoday.rs:169:36 [INFO] [stderr] | [INFO] [stderr] 169 | let author = item.author().unwrap_or(channel.title()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| channel.title())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/linetoday.rs:170:34 [INFO] [stderr] | [INFO] [stderr] 170 | let source = item.link().unwrap_or(channel.link()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| channel.link())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/linetoday.rs:248:26 [INFO] [stderr] | [INFO] [stderr] 248 | let countries = &self [INFO] [stderr] | __________________________^ [INFO] [stderr] 249 | | .config [INFO] [stderr] 250 | | .line_pub_to_country [INFO] [stderr] 251 | | .clone() [INFO] [stderr] 252 | | .unwrap_or(String::new()); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 248 | let countries = &self [INFO] [stderr] 249 | .config [INFO] [stderr] 250 | .line_pub_to_country [INFO] [stderr] 251 | .clone().unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/linetoday.rs:259:26 [INFO] [stderr] | [INFO] [stderr] 259 | let countries = &self [INFO] [stderr] | __________________________^ [INFO] [stderr] 260 | | .config [INFO] [stderr] 261 | | .line_excl_from_country [INFO] [stderr] 262 | | .clone() [INFO] [stderr] 263 | | .unwrap_or(String::new()); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 259 | let countries = &self [INFO] [stderr] 260 | .config [INFO] [stderr] 261 | .line_excl_from_country [INFO] [stderr] 262 | .clone().unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/linetoday.rs:270:1 [INFO] [stderr] | [INFO] [stderr] 270 | / pub fn from<'l>(feed: Feed, config: &'l Config) -> LineToday { [INFO] [stderr] 271 | | LineToday { [INFO] [stderr] 272 | | feed: feed, [INFO] [stderr] 273 | | config: config, [INFO] [stderr] 274 | | } [INFO] [stderr] 275 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/wordpress.rs:26:55 [INFO] [stderr] | [INFO] [stderr] 26 | Channel::read_from(feed.as_ref()).map_err(|err| ErrorInternalServerError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ErrorInternalServerError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/healthcheck.rs:34:60 [INFO] [stderr] | [INFO] [stderr] 34 | self.response_time = (duration.as_secs() * 1000) + duration.subsec_millis() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/linetoday.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | Func(Box, &mut Writer>) -> Result<(), XMLError> + 'a>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/linetoday.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | Box, &mut Writer>, usize) -> Result<(), XMLError> + 'a>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/linetoday.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | .map_err(|err| ErrorInternalServerError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ErrorInternalServerError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/linetoday.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | fn into_xml(&'a self) -> Result, XMLError> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/linetoday.rs:39:62 [INFO] [stderr] | [INFO] [stderr] 39 | let mut writer = Writer::new_with_indent(Vec::new(), ' ' as u8, 2); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/linetoday.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | .unwrap_or(Utc::now()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Utc::now())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/linetoday.rs:134:24 [INFO] [stderr] | [INFO] [stderr] 134 | let duration = self.config.publish_duration_in_weeks.unwrap_or(144) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.config.publish_duration_in_weeks.unwrap_or(144))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/linetoday.rs:167:34 [INFO] [stderr] | [INFO] [stderr] 167 | let title = item.title().unwrap_or(channel.title()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| channel.title())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/linetoday.rs:169:36 [INFO] [stderr] | [INFO] [stderr] 169 | let author = item.author().unwrap_or(channel.title()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| channel.title())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/linetoday.rs:170:34 [INFO] [stderr] | [INFO] [stderr] 170 | let source = item.link().unwrap_or(channel.link()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| channel.link())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/linetoday.rs:248:26 [INFO] [stderr] | [INFO] [stderr] 248 | let countries = &self [INFO] [stderr] | __________________________^ [INFO] [stderr] 249 | | .config [INFO] [stderr] 250 | | .line_pub_to_country [INFO] [stderr] 251 | | .clone() [INFO] [stderr] 252 | | .unwrap_or(String::new()); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 248 | let countries = &self [INFO] [stderr] 249 | .config [INFO] [stderr] 250 | .line_pub_to_country [INFO] [stderr] 251 | .clone().unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/linetoday.rs:259:26 [INFO] [stderr] | [INFO] [stderr] 259 | let countries = &self [INFO] [stderr] | __________________________^ [INFO] [stderr] 260 | | .config [INFO] [stderr] 261 | | .line_excl_from_country [INFO] [stderr] 262 | | .clone() [INFO] [stderr] 263 | | .unwrap_or(String::new()); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 259 | let countries = &self [INFO] [stderr] 260 | .config [INFO] [stderr] 261 | .line_excl_from_country [INFO] [stderr] 262 | .clone().unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/linetoday.rs:270:1 [INFO] [stderr] | [INFO] [stderr] 270 | / pub fn from<'l>(feed: Feed, config: &'l Config) -> LineToday { [INFO] [stderr] 271 | | LineToday { [INFO] [stderr] 272 | | feed: feed, [INFO] [stderr] 273 | | config: config, [INFO] [stderr] 274 | | } [INFO] [stderr] 275 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/wordpress.rs:26:55 [INFO] [stderr] | [INFO] [stderr] 26 | Channel::read_from(feed.as_ref()).map_err(|err| ErrorInternalServerError(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ErrorInternalServerError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 25s [INFO] running `"docker" "inspect" "4d620b7539198ab5c5c6aa011fbd9c7c30de4675997cf25617ba90532a432491"` [INFO] running `"docker" "rm" "-f" "4d620b7539198ab5c5c6aa011fbd9c7c30de4675997cf25617ba90532a432491"` [INFO] [stdout] 4d620b7539198ab5c5c6aa011fbd9c7c30de4675997cf25617ba90532a432491